Skip to content

Change icon for empty workspace view in new room page #33331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techievivek merged 3 commits into from
Dec 29, 2023
Merged

Change icon for empty workspace view in new room page #33331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d85894
edit icon
dukenv0307 Dec 20, 2023
8d8d21f
update width and height of icon
dukenv0307 Dec 20, 2023
5bf071d
revert change
dukenv0307 Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions assets/images/product-illustrations/telescope.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions src/components/Icon/Illustrations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import SafeBlue from '@assets/images/product-illustrations/safe.svg';
import SmartScan from '@assets/images/product-illustrations/simple-illustration__smartscan.svg';
import TadaBlue from '@assets/images/product-illustrations/tada--blue.svg';
import TadaYellow from '@assets/images/product-illustrations/tada--yellow.svg';
import TeleScope from '@assets/images/product-illustrations/telescope.svg';
import ToddBehindCloud from '@assets/images/product-illustrations/todd-behind-cloud.svg';
import BankArrow from '@assets/images/simple-illustrations/simple-illustration__bank-arrow.svg';
import PinkBill from '@assets/images/simple-illustrations/simple-illustration__bill.svg';
Expand Down Expand Up @@ -100,4 +101,5 @@ export {
Hands,
HandEarth,
SmartScan,
TeleScope,
};
6 changes: 3 additions & 3 deletions src/pages/workspace/WorkspaceNewRoomPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,9 @@ function WorkspaceNewRoomPage(props) {
const renderEmptyWorkspaceView = () => (
<>
<BlockingView
icon={Illustrations.ToddBehindCloud}
iconWidth={variables.modalTopIconWidth}
iconHeight={variables.modalTopIconHeight}
icon={Illustrations.TeleScope}
iconWidth={variables.emptyWorkspaceIconWidth}
iconHeight={variables.emptyWorkspaceIconHeight}
title={translate('workspace.emptyWorkspace.notFound')}
subtitle={translate('workspace.emptyWorkspace.description')}
shouldShowLink={false}
Expand Down
2 changes: 2 additions & 0 deletions src/styles/variables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ export default {
avatarChatSpacing: 12,
chatInputSpacing: 52, // 40 + avatarChatSpacing
borderTopWidth: 1,
emptyWorkspaceIconWidth: 84,
emptyWorkspaceIconHeight: 84,
modalTopIconWidth: 200,
modalTopIconHeight: 164,
modalTopBigIconHeight: 244,
Expand Down