Skip to content

Feat/29780/hide list while initial scrolling #32777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deetergp merged 4 commits into from
Dec 11, 2023
Merged

Feat/29780/hide list while initial scrolling #32777

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2da6dd9
feat: hiding list while scrolling in initial render
barttom Dec 9, 2023
8316f7e
feat: hiding list while scrolling in initial render
barttom Dec 9, 2023
3a035bc
feat: hiding list while scrolling in initial render
barttom Dec 9, 2023
996f159
fix: fixed lin error, added styles to the variable
barttom Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/components/SelectionList/BaseSelectionList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ function BaseSelectionList({
const theme = useTheme();
const styles = useThemeStyles();
const {translate} = useLocalize();
const firstLayoutRef = useRef(true);
const listRef = useRef(null);
const textInputRef = useRef(null);
const focusTimeoutRef = useRef(null);
Expand All @@ -73,6 +72,8 @@ function BaseSelectionList({
const activeElement = useActiveElement();
const isFocused = useIsFocused();
const [maxToRenderPerBatch, setMaxToRenderPerBatch] = useState(shouldUseDynamicMaxToRenderPerBatch ? 0 : CONST.MAX_TO_RENDER_PER_BATCH.DEFAULT);
const [isInitialRender, setIsInitialRender] = useState(true);
const wrapperStyles = useMemo(() => ({opacity: isInitialRender ? 0 : 1}), [isInitialRender]);

/**
* Iterates through the sections and items inside each section, and builds 3 arrays along the way:
Expand Down Expand Up @@ -325,13 +326,13 @@ function BaseSelectionList({
setMaxToRenderPerBatch((Math.ceil(listHeight / itemHeight) || 0) + CONST.MAX_TO_RENDER_PER_BATCH.DEFAULT);
}

if (!firstLayoutRef.current) {
if (!isInitialRender) {
return;
}
scrollToIndex(focusedIndex, false);
firstLayoutRef.current = false;
setIsInitialRender(false);
},
[focusedIndex, scrollToIndex, shouldUseDynamicMaxToRenderPerBatch],
[focusedIndex, isInitialRender, scrollToIndex, shouldUseDynamicMaxToRenderPerBatch],
);

const updateAndScrollToFocusedIndex = useCallback(
Expand Down Expand Up @@ -359,7 +360,7 @@ function BaseSelectionList({

useEffect(() => {
// do not change focus on the first render, as it should focus on the selected item
if (firstLayoutRef.current) {
if (isInitialRender) {
return;
}

Expand Down Expand Up @@ -394,7 +395,7 @@ function BaseSelectionList({
>
<SafeAreaConsumer>
{({safeAreaPaddingBottomStyle}) => (
<View style={[styles.flex1, !isKeyboardShown && safeAreaPaddingBottomStyle]}>
<View style={[styles.flex1, !isKeyboardShown && safeAreaPaddingBottomStyle, wrapperStyles]}>
{shouldShowTextInput && (
<View style={[styles.ph5, styles.pb3]}>
<TextInput
Expand Down