Skip to content

[CP Staging] Match bank names for credit card icons #32410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiragsalian merged 3 commits into from
Dec 4, 2023
Merged

[CP Staging] Match bank names for credit card icons #32410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6e6fe3
loosely check bank name instead of requiring exact match
NikkiWines Dec 3, 2023
3430a75
add mapping for hungtington national
NikkiWines Dec 3, 2023
10aef7c
prettier
NikkiWines Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2873,6 +2873,7 @@ const CONST = {
FIDELITY: 'fidelity',
GENERIC_BANK: 'generic bank',
HUNTINGTON_BANK: 'huntington bank',
HUNTINGTON_NATIONAL: 'huntington national',
NAVY_FEDERAL_CREDIT_UNION: 'navy federal credit union',
PNC: 'pnc',
REGIONS_BANK: 'regions bank',
Expand Down
15 changes: 14 additions & 1 deletion src/components/Icon/BankIcons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ function getAssetIcon(bankNameKey: BankNameKey, isCard: boolean): React.FC<SvgPr
[CONST.BANK_NAMES.HUNTINGTON_BANK]: isCard
? (require('@assets/images/cardicons/huntington-bank.svg').default as React.FC<SvgProps>)
: (require('@assets/images/bankicons/huntington-bank.svg').default as React.FC<SvgProps>),
[CONST.BANK_NAMES.HUNTINGTON_NATIONAL]: isCard
? (require('@assets/images/cardicons/huntington-bank.svg').default as React.FC<SvgProps>)
: (require('@assets/images/bankicons/huntington-bank.svg').default as React.FC<SvgProps>),
[CONST.BANK_NAMES.NAVY_FEDERAL_CREDIT_UNION]: isCard
? (require('@assets/images/cardicons/navy-federal-credit-union.svg').default as React.FC<SvgProps>)
: (require('@assets/images/bankicons/navy-federal-credit-union.svg').default as React.FC<SvgProps>),
Expand Down Expand Up @@ -95,7 +98,17 @@ function getAssetIcon(bankNameKey: BankNameKey, isCard: boolean): React.FC<SvgPr
}

function getBankNameKey(bankName: string): BankNameKey {
const bank = Object.entries(CONST.BANK_NAMES).find(([, value]) => value?.toLowerCase() === bankName);
const bank = Object.entries(CONST.BANK_NAMES).find(([, value]) => {
const condensedValue = value.replace(/\s/g, '');
return (
bankName === value ||
bankName.includes(value) ||
bankName.startsWith(value) ||
bankName === condensedValue ||
bankName.includes(condensedValue) ||
bankName.startsWith(condensedValue)
);
});
return (bank?.[0] as BankNameKey) ?? '';
}

Expand Down