Skip to content

Fix: Undefined displayed in header when opening left thread in offline mode #32331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkuoch merged 6 commits into from
Dec 6, 2023
Merged

Fix: Undefined displayed in header when opening left thread in offline mode #32331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
197dcc3
fix: 28969
tienifr Oct 6, 2023
0e0898f
Merge branch 'main' into fix/28997
tienifr Nov 30, 2023
001aae3
fix: Undefined displayed in header offline when opening left thread
tienifr Nov 30, 2023
082d31d
Merge branch 'main' of https://github.com/tienifr/App into fix/28997
tienifr Dec 1, 2023
3510952
Merge branch 'main' of https://github.com/tienifr/App into fix/28997
tienifr Dec 1, 2023
baf668f
fix avatar for workspace thread
tienifr Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3849,7 +3849,7 @@ function getWhisperDisplayNames(participantAccountIDs?: number[]): string | unde
* Show subscript on workspace chats / threads and expense requests
*/
function shouldReportShowSubscript(report: OnyxEntry<Report>): boolean {
if (isArchivedRoom(report)) {
if (isArchivedRoom(report) && !isWorkspaceThread(report)) {

@mollfpr mollfpr Dec 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could explain why we need to add check here?

@shubham1206agra shubham1206agra Dec 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tienifr Can you answer this question? Since I am about to fix isWorkspaceThread function.

return false;
}

Expand Down
5 changes: 5 additions & 0 deletions src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2053,6 +2053,11 @@ function leaveRoom(reportID, isWorkspaceMemberLeavingWorkspaceRoom = false) {
value: {
stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,
statusNum: CONST.REPORT.STATUS.CLOSED,
chatType: report.chatType,
parentReportID: report.parentReportID,
parentReportActionID: report.parentReportActionID,
policyID: report.policyID,
type: report.type,

@mollfpr mollfpr Dec 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to retain the value policy?

},
},
];
Expand Down