Repository navigation
[TS Migration] migrate UnorderedList.js to TypeScript #30641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Gonals
merged 5 commits into
Expensify:main
from
JKobrynski:migrateUnorderedListToTypeScript
Nov 30, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8687ed3
migrate UnorderedList to TypeScript
JKobrynski 6a15a2d
minor fixes
JKobrynski 37ddcc0
Merge branch 'main' into migrateUnorderedListToTypeScript
JKobrynski 6079041
Merge branch 'main' into migrateUnorderedListToTypeScript
JKobrynski 5be74c4
Merge branch 'main' into migrateUnorderedListToTypeScript
JKobrynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import React from 'react'; | ||
| import {View} from 'react-native'; | ||
| import useThemeStyles from '@styles/useThemeStyles'; | ||
| import Text from './Text'; | ||
|
|
||
| type UnorderedListProps = { | ||
| /** An array of strings to display as an unordered list */ | ||
| items?: string[]; | ||
| }; | ||
|
|
||
| function UnorderedList({items = []}: UnorderedListProps) { | ||
| const styles = useThemeStyles(); | ||
|
|
||
| return items.map((itemText) => ( | ||
| <View | ||
| key={itemText} | ||
| style={[styles.flexRow, styles.alignItemsStart, styles.ml2]} | ||
| > | ||
| <Text style={[styles.mr2]}>{'\u2022'}</Text> | ||
| <Text>{itemText}</Text> | ||
| </View> | ||
| )); | ||
| } | ||
|
|
||
| UnorderedList.displayName = 'UnorderedList'; | ||
| export default UnorderedList; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.