fix: 28841 keyboard opens for a second when user switches to password protected PDF by tienifr · Pull Request #29331 · Expensify/App

tienifr · 2023-10-11T15:23:41Z

Details

Fixed Issues

$ #28841
PROPOSAL: #28841 (comment)

Tests

go to any chat
send a password protected PDF and one image or pdf
click on password protected PDF
click on enter password which will opens a keyboard
click on Next or previous arrow
again go to password protected PDF
verify that the input is focused and keyboard is shown

Verify that no errors appear in the JS console

Offline tests

QA Steps

go to any chat
send a password protected PDF and one image or pdf
click on password protected PDF
click on enter password which will opens a keyboard
click on Next or previous arrow
again go to password protected PDF
verify that the input is focused and keyboard is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-11.at.22.19.15.mov

Android: mWeb Chrome

Screenrecorder-2023-10-11-22-02-10-362.mp4

iOS: Native

Screen.Recording.2023-10-11.at.22.19.15.mov

iOS: mWeb Safari

Screen.Recording.2023-10-11.at.21.59.36.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-11.at.21.57.17.mov

MacOS: Desktop

Screen.Recording.2023-10-11.at.22.23.00.mov

… protected PDF

melvin-bot · 2023-10-11T15:23:59Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-10-13T02:48:59Z

@burczu any updates?

burczu · 2023-10-13T05:48:57Z

            return;
        }
-        textInputRef.current.focus();
+        focusTimeoutRef.current = setTimeout(() => {


I would add the comment with the link to Slack comment posted by Rory explaining why we should use setTimeout here.

@burczu Do we really need it? As this approach is used in many places in our app

I think we do - in general we are trying to avoid using setTimeout in the app so describing why we had to use it is a good habit.

Added comment

burczu · 2023-10-16T11:19:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

29331-web.mov

Mobile Web - Chrome

29331-web-chrome.mov

Mobile Web - Safari

29331-web-safari.mov

Desktop

29331-desktop.mov

iOS

29331-ios.mov

Android

29331-android.mov

burczu

LGTM

hayata-suenaga

LGTM

OSBotify · 2023-10-16T12:18:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-16T21:48:27Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:13:12Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:59:30Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:57:00Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: 28841 keyboard opens for a second when user switches to password…

74c85b4

… protected PDF

tienifr marked this pull request as ready for review October 11, 2023 15:23

tienifr requested a review from a team as a code owner October 11, 2023 15:23

melvin-bot Bot requested review from burczu and removed request for a team October 11, 2023 15:23

burczu reviewed Oct 13, 2023

View reviewed changes

fix: add comment

0a7b80b

burczu approved these changes Oct 16, 2023

View reviewed changes

melvin-bot Bot requested a review from hayata-suenaga October 16, 2023 11:24

hayata-suenaga approved these changes Oct 16, 2023

View reviewed changes

hayata-suenaga merged commit 8e6a74c into Expensify:main Oct 16, 2023

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

melvin-bot Bot mentioned this pull request Oct 17, 2023

[HOLD for payment 2023-10-24] [$500] keyboard opens for a second when user switches to password protected PDF #28841

Closed

6 tasks

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

Conversation

tienifr commented Oct 11, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 11, 2023

Uh oh!

tienifr commented Oct 13, 2023

Uh oh!

burczu Oct 13, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Oct 16, 2023

Choose a reason for hiding this comment

Uh oh!

burczu Oct 16, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Oct 16, 2023

Choose a reason for hiding this comment

Uh oh!

burczu commented Oct 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

burczu left a comment

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 16, 2023

Uh oh!

OSBotify commented Oct 16, 2023

Uh oh!

OSBotify commented Oct 17, 2023

Uh oh!

OSBotify commented Oct 17, 2023

Uh oh!

OSBotify commented Oct 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

burczu commented Oct 16, 2023 •

edited

Loading