prevent optimisticID creation for a user already existing in personal details by c3024 · Pull Request #29279 · Expensify/App

c3024 · 2023-10-11T10:07:01Z

Details

Fixed Issues

$ #29024
PROPOSAL: #29024 (comment)

Tests

Create a workspace X
Invite a user A to this workspace X
Go to #announce room of this workspace X
Split a bill in this room with the user A
Delete the workspace X
Create another workspace Y
Go to Invite page
Verify that user A is shown in the options below the TextInput

Verify that no errors appear in the JS console

Offline tests

Go online
Login
Create a workspace X
Invite a user A to this workspace X
Go to #announce room of this workspace X
Split a bill in this room with the user A
Go offline
Delete the workspace X
Create another workspace Y
Go to Invite page
Verify that user A is shown in the options below the TextInput

QA Steps

Create a workspace X
Invite a user A to this workspace X
Go to #announce room of this workspace X
Split a bill in this room with the user A
Delete the workspace X
Create another workspace Y
Go to Invite page
Verify that user A is shown in the options below the TextInput

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

androidMissingMember-compressed.mp4

Offline

androidMissingMemberOffline.mp4

Android: mWeb Chrome

mWebAndroidMissingMember-compressed.mp4

Offline

mWebMissingMemberOffline.mp4

iOS: Native

iOSNativeMissingMember.mp4

Offline

iOSNativeMissingMemberOffline.mp4

iOS: mWeb Safari

SafariMissingMember.mp4

Offline

iOSMissingMemberOffline.mp4

MacOS: Chrome / Safari

webMissingMember.mp4

Offline

webMissingNumberOffline.mp4

MacOS: Desktop

desktopMissingMember.mp4

Offline

desktopMissingMemberOffline.mp4

melvin-bot · 2023-10-11T10:07:06Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2023-10-11T10:20:32Z

@cubuspl42 because you have Offline tests in GH description, could you include offline test recordings in Screenshots/Videos? (To prove it works when network is offline) Thanks

hoangzinh · 2023-10-11T10:21:20Z

oops, wrong mention @cubuspl42. I'm really sorry. I meant @c3024

c3024 · 2023-10-11T10:28:25Z

My bad. All steps cannot be done offline. Removed them. @hoangzinh

hoangzinh · 2023-10-11T10:26:31Z

        let isNewOneOnOneChatReport = false;
        let shouldCreateOptimisticPersonalDetails = false;
-
+        const personalDetailExists = _.has(allPersonalDetails, accountID);


We should use lodash util instead of underscore https://expensify.slack.com/archives/C01GTK53T8Q/p1687477811950459

Done but there are other places in this file with _.has. I did not change them.

hoangzinh · 2023-10-11T10:45:55Z

        let isNewOneOnOneChatReport = false;
        let shouldCreateOptimisticPersonalDetails = false;
-
+        const personalDetailExists = lodashHas(allPersonalDetails, accountID);


NAB, I think we should keep an empty line as previously, I recall we have a rule that it should have an empty space before a comment.

Hmm. I'll add. Prettier and lint didn't object so I didn't mind.

hoangzinh · 2023-10-11T10:55:15Z

My bad. All steps cannot be done offline. Removed them. @hoangzinh

Could you explain the reason why we can't test offline for this fix? Thanks

c3024 · 2023-10-11T10:59:52Z

Split bill option in the + menu in composer for #announce room appears only when we invite the user when online.

hoangzinh · 2023-10-11T11:44:39Z

Split bill option in the + menu in composer for #announce room appears only when we invite the user when online.

@c3024 does it make sense if we do step 1->3 online, and do offline from step 4?

c3024 · 2023-10-11T11:47:18Z

I'll split steps into online and offline with as many offline steps as feasible and update the offline instructions.

c3024 · 2023-10-11T13:47:11Z

Updated offline steps and videos @hoangzinh

hoangzinh · 2023-10-11T14:45:29Z

Thanks @c3024 I'm appreciate it

hoangzinh · 2023-10-11T14:45:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-11.at.22.43.40.-.web.mov

Mobile Web - Chrome

Screen.Recording.2023-10-11.at.23.07.38.-.android.chrome.mp4

Mobile Web - Safari

Screen.Recording.2023-10-11.at.22.56.43.-.ios.safari.mp4

Desktop

Screen.Recording.2023-10-11.at.22.48.44.-.desktop.mov

iOS

Screen.Recording.2023-10-11.at.23.03.09.-.ios.mp4

Android

Screen.Recording.2023-10-11.at.23.11.59.-.android.mp4

hoangzinh

LGTM

hoangzinh · 2023-10-16T10:19:08Z

cc @Gonals for code review

OSBotify · 2023-10-16T14:09:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-16T21:48:18Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:13:03Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:59:15Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:56:45Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

no optimisticID creation for existing user

c75394a

c3024 requested a review from a team as a code owner October 11, 2023 10:07

melvin-bot Bot removed the request for review from a team October 11, 2023 10:07

melvin-bot Bot requested a review from hoangzinh October 11, 2023 10:07

hoangzinh reviewed Oct 11, 2023

View reviewed changes

use lodashHas instead of _.has

a3981c3

hoangzinh reviewed Oct 11, 2023

View reviewed changes

c3024 added 2 commits October 11, 2023 16:30

add empty line before comment

869ee9c

sync with prettier

55bc869

hoangzinh approved these changes Oct 11, 2023

View reviewed changes

melvin-bot Bot requested a review from Gonals October 11, 2023 16:22

Gonals approved these changes Oct 16, 2023

View reviewed changes

Gonals merged commit 955da1a into Expensify:main Oct 16, 2023

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

melvin-bot Bot mentioned this pull request Oct 17, 2023

[HOLD for payment 2023-10-24] [$500] Email not found in new workspace after adding as member, splitting bill, deleting old workspace. #29024

Closed

6 tasks

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

s77rt mentioned this pull request Oct 28, 2023

[HOLD for payment 2023-11-13] [$500] Chat - After creating a money request, email are first displayed, then changed to set name #30456

Closed

6 tasks

Conversation

c3024 commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 11, 2023

Uh oh!

hoangzinh commented Oct 11, 2023

Uh oh!

hoangzinh commented Oct 11, 2023

Uh oh!

c3024 commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

c3024 Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

hoangzinh Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

c3024 Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Oct 11, 2023

Uh oh!

c3024 commented Oct 11, 2023

Uh oh!

hoangzinh commented Oct 11, 2023

Uh oh!

c3024 commented Oct 11, 2023

Uh oh!

c3024 commented Oct 11, 2023

Uh oh!

hoangzinh commented Oct 11, 2023

Uh oh!

hoangzinh commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Oct 16, 2023

Uh oh!

OSBotify commented Oct 16, 2023

Uh oh!

OSBotify commented Oct 16, 2023

Uh oh!

OSBotify commented Oct 17, 2023

Uh oh!

OSBotify commented Oct 17, 2023

Uh oh!

OSBotify commented Oct 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

c3024 commented Oct 11, 2023 •

edited

Loading

c3024 commented Oct 11, 2023 •

edited

Loading

hoangzinh commented Oct 11, 2023 •

edited

Loading