Task Share Destination Fixes by Thanos30 · Pull Request #24019 · Expensify/App

Thanos30 · 2023-08-01T18:03:07Z

Details

Fixing Task Share Destination code to show only chats already available.

Fixed Issues

$ #20898
PROPOSAL: #20898 (comment)

Tests

Click the FAB button.
Click "Assign Task".
Fill in Task title.
Click on "Share somewhere".
Confirm that you are prompted with options only for already opened/available chats (+ you can't create a new chat by typing a valid email address or mobile phone that you haven't interacted with before)

Verify that no errors appear in the JS console

Offline tests

Click the FAB button.
Click "Assign Task".
Fill in Task title.
Click on "Share somewhere".
Confirm that you are prompted with options only for already opened/available chats (+ you can't create a new chat by typing a valid email address or mobile phone that you haven't interacted with before).

QA Steps

Click the FAB button.
Click "Assign Task".
Fill in Task title.
Click on "Share somewhere".
Confirm that you are prompted with options only for already opened/available chats (+ you can't create a new chat by typing a valid email address or mobile phone that you haven't interacted with before)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Uploading Screen Recording 2023-08-01 at 8.28.31 PM.mov…

Mobile Web - Chrome

Screen.Recording.2023-08-01.at.8.34.12.PM.mov

Mobile Web - Safari

Screen.Recording.2023-08-01.at.8.34.12.PM.mov

Desktop

iOS

Screen.Recording.2023-08-01.at.8.48.16.PM.mov

Android

Screen.Recording.2023-08-01.at.9.01.06.PM.mov

melvin-bot · 2023-08-01T18:03:13Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Thanos30 · 2023-08-01T18:09:06Z

@situchan @thienlnam Seems like a test is designed to expect the wrong results from getShareDestinationOptions function.

Do you want me to take a look and fix that test as well to work with are newly desired results?

thienlnam · 2023-08-01T18:19:32Z

Do you want me to take a look and fix that test as well to work with are newly desired results?

Yes please, we're changing the expected functionality so we'll need to update the test as well

Thanos30 · 2023-08-01T18:21:08Z

Do you want me to take a look and fix that test as well to work with are newly desired results?

Yes please, we're changing the expected functionality so we'll need to update the test as well

Roger that, on it now

Thanos30 · 2023-08-01T18:37:44Z

@situchan @thienlnam Also updated the test to match the new functionality

situchan · 2023-08-02T23:20:33Z

        includeThreads = false,
        includeTasks = false,
        includeMoneyRequests = false,
+        disallowNewChats = false,


Let's use exclude word to be consistent with others.
I suggest excludeUnknownUsers

Agreed, changed it to your suggestion. Thanks!

Thanks for the quick update. Also please pull main

Thank you @situchan , done!

I pulled main before I made my PR, seems like a lot of stuff was merged afterwards

…ination-fixes

situchan · 2023-08-03T00:21:03Z

@Thanos30 please exclude archived workspaces

Thanos30 · 2023-08-03T00:25:37Z

@Thanos30 please exclude archived workspaces

@situchan Archived rooms are disabled, you can also see that in the test for that function

situchan · 2023-08-03T00:27:25Z

@Thanos30 please exclude archived workspaces

@situchan Archived rooms are disabled, you can also see that in the test for that function

Still I am seeing them

Screen.Recording.2023-08-03.at.6.26.33.AM.mov

situchan · 2023-08-03T00:33:29Z

Also, Concierge cannot be destination. The condition should be exactly same as Assign task option visibility in Composer

App/src/pages/home/report/ReportActionCompose.js

Lines 453 to 469 in 2f750ad

    
           getTaskOption(reportParticipants) { 
        
               // We only prevent the task option from showing if it's a DM and the other user is an Expensify default email 
        
               if ( 
        
                   !Permissions.canUseTasks(this.props.betas) || 
        
                   (lodashGet(this.props.report, 'participantAccountIDs', []).length === 1 && _.some(reportParticipants, (accountID) => _.contains(CONST.EXPENSIFY_ACCOUNT_IDS, accountID))) 
        
               ) { 
        
                   return []; 
        
               } 
        
               return [ 
        
                   { 
        
                       icon: Expensicons.Task, 
        
                       text: this.props.translate('newTaskPage.assignTask'), 
        
                       onSelected: () => Task.clearOutTaskInfoAndNavigate(this.props.reportID), 
        
                   }, 
        
               ]; 
        
           }

Thanos30 · 2023-08-03T00:33:57Z

Still I am seeing them

Got it, thank you!

I added an extra condition on TaskShareDestinationSelectorModal.js file to exclude Archived Rooms.

situchan · 2023-08-03T01:02:15Z

+                (lodashGet(props.reports[reportKey], 'participantAccountIDs', []).length === 1 &&
+                    _.some(props.reports[reportKey].participantAccountIDs, (accountID) => _.contains(CONST.EXPENSIFY_ACCOUNT_IDS, accountID)))


Make common function in ReportUtils similar to isConciergeChatReport and use it both here and ReportActionCompose.
We avoid duplicated code.

@situchan Thank you for your feedback. Let me know what you think of the changes 🙏

situchan · 2023-08-03T01:25:08Z

+ * @returns {Boolean}
+ */
+
+function canShareTaskInReport(report) {


This can be general function, not tied to task.
So let's rename it to isExpensifyChatReport

Done, thanks 🙏

situchan · 2023-08-03T01:48:23Z

Last change:

-                                                       ...this.getTaskOption(reportParticipants),
+                                                       ...this.getTaskOption(),

Thanos30 · 2023-08-03T01:51:39Z

Last change:

Whoops, sorry I missed that

situchan · 2023-08-03T09:56:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web1.mov

web2.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

LGTM
@thienlnam all yours

thienlnam

Just a small comment, but rest is looking good!

Thanos30 · 2023-08-03T18:24:29Z

Just a small comment, but rest is looking good!

Got it, fixing that in a minute

Thanos30 · 2023-08-03T18:28:59Z

@thienlnam Done, thanks!

thienlnam · 2023-08-03T19:22:56Z

+ * @param {Object} report
+ * @returns {Boolean}
+ */
+


Added space

Removed, sorry

thienlnam · 2023-08-03T20:42:19Z

 import PropTypes from 'prop-types';
 import {withOnyx} from 'react-native-onyx';
 import OptionsSelector from '../../components/OptionsSelector';
+


Another space added here

@thienlnam sorry for the inconvenience, removed some code after the adjustments with the new functions. I thought npm run prettify would cover it. Done.

thienlnam

Great, thanks!

OSBotify · 2023-08-03T21:06:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-07T18:55:55Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:45:03Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:14:08Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:52:51Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-10T20:11:17Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2023-09-29T08:38:26Z

Just coming from this issue where Assign task incorrectly shows up as available in a threaded chat with Concierge. I think this PR partially caused the issue in that there was a missed case in isExpensifyOnlyParticipantInReport for threaded chats.

Here we filter participantAccountIDs to remove the current user's account in the first line, but then check length against the unfiltered participantAccountIDs, which means that in chats where both users are in the participantAccountIDs this function would return false (incorrectly).

App/src/libs/ReportUtils.js

Lines 483 to 486 in 0a7aabd

    
           function isExpensifyOnlyParticipantInReport(report) { 
        
               const reportParticipants = _.without(lodashGet(report, 'participantAccountIDs', []), currentUserAccountID); 
        
               return lodashGet(report, 'participantAccountIDs', []).length === 1 && _.some(reportParticipants, (accountID) => _.contains(CONST.EXPENSIFY_ACCOUNT_IDS, accountID)); 
        
           }

Thanos30 added 3 commits August 1, 2023 17:35

Task Share Destination Fixes

a262192

Apply options discussed in issue

8c98c9a

remove not needed parameter

b670ed5

Thanos30 requested a review from a team as a code owner August 1, 2023 18:03

melvin-bot bot requested review from situchan and removed request for a team August 1, 2023 18:03

Update test to match new functionality

c3591e5

Thanos30 added 2 commits August 1, 2023 21:48

prettify code and correct test to exclude archived rooms

603b305

add fic on workspace reports

3dd5301

situchan reviewed Aug 2, 2023

View reviewed changes

Thanos30 added 2 commits August 3, 2023 02:28

make name more obvious

157f56d

Merge remote-tracking branch 'upstream/main' into fix/task-share-dest…

b778073

…ination-fixes

exclude Archived Rooms

e938e74

exclude expensify accounts

1308dfd

situchan reviewed Aug 3, 2023

View reviewed changes

Thanos30 added 2 commits August 3, 2023 04:20

Use common function to determine if we can share a task in a report

a21355e

prettify

c703f7d

situchan reviewed Aug 3, 2023

View reviewed changes

fix name accuracy

6bac6dc

remove unneeded parameter

de39deb

situchan approved these changes Aug 3, 2023

View reviewed changes

melvin-bot bot requested a review from thienlnam August 3, 2023 16:35

thienlnam suggested changes Aug 3, 2023

View reviewed changes

Comment thread src/libs/ReportUtils.js Outdated

Comment thread src/libs/ReportUtils.js Outdated

update function's docs and name

b9cc192

thienlnam reviewed Aug 3, 2023

View reviewed changes

remove unneeded space

ce779cc

thienlnam reviewed Aug 3, 2023

View reviewed changes

remove space

18daf91

thienlnam approved these changes Aug 3, 2023

View reviewed changes

thienlnam merged commit 245b81d into Expensify:main Aug 3, 2023

Beamanator mentioned this pull request Aug 4, 2023

🍒 Cherry pick PR #24091 to staging 🍒 #24166

Merged

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

lanitochka17 mentioned this pull request Aug 8, 2023

[$1000] Search - User custom avatar is not shown in search suggestion #24282

Closed

6 tasks

GItGudRatio mentioned this pull request Aug 8, 2023

Assign Task - "User can not be found..." appears when selecting existing user to Share #24285

Closed

6 tasks

melvin-bot bot mentioned this pull request Aug 9, 2023

[HOLD for payment 2023-08-16] [$2000] Assign task - Unable to select a user for Share somewhere #20898

Closed

6 tasks

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

thienlnam mentioned this pull request Aug 9, 2023

Assign Task- When user tap share somewhere, all activities with last message are shown #24340

Closed

6 tasks

jjcoffee mentioned this pull request Sep 12, 2023

[C+ Checklist Needs Completion] [$500] Inconsistency bug: "Assign task" appear in modal of "+" actions button in thread of flagging #26229

Closed

6 tasks

		(lodashGet(props.reports[reportKey], 'participantAccountIDs', []).length === 1 &&
		_.some(props.reports[reportKey].participantAccountIDs, (accountID) => _.contains(CONST.EXPENSIFY_ACCOUNT_IDS, accountID)))

Conversation

Thanos30 commented Aug 1, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 1, 2023

Uh oh!

Thanos30 commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thienlnam commented Aug 1, 2023

Uh oh!

Thanos30 commented Aug 1, 2023

Uh oh!

Thanos30 commented Aug 1, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan commented Aug 3, 2023

Uh oh!

Thanos30 commented Aug 3, 2023

Uh oh!

situchan commented Aug 3, 2023

Uh oh!

situchan commented Aug 3, 2023

Uh oh!

Thanos30 commented Aug 3, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan commented Aug 3, 2023

Uh oh!

Thanos30 commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Thanos30 commented Aug 3, 2023

Uh oh!

Thanos30 commented Aug 3, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thienlnam left a comment

Thanos30 commented Aug 1, 2023 •

edited

Loading

Thanos30 commented Aug 3, 2023 •

edited

Loading

situchan commented Aug 3, 2023 •

edited

Loading