IOU Details Modal - #2394

Merged

marcaaron merged 153 commits into

mainfrom

jules-iouDetailsModal

May 18, 2021

Commits on Apr 26, 2021

create dynamic IOU Details route and empty Modal
Julesssss
committed
d0190cd
replace preview HTML with a React View, to simplify 'view details' callback
Julesssss
committed
113825f
retrieve IOU report dynamically
Julesssss
committed
73640e3
add basic button
Julesssss
committed
bbd260f
start using originalMessage json data, now that API returns it
Julesssss
committed
fdb1338
refactor transaction Views to own component
Julesssss
committed
6707a31
rename IOUDetailPage to IOUDetailsModal
Julesssss
committed
a5bc309
attempt to depend on two onyx subscriptions
Julesssss
committed
e7084b1
formatting
Julesssss
committed
3e5dc11
use user email to determine whether payment is possible
Julesssss
committed
8e2dc07
add isLoading to state
Julesssss
committed
7f07909
add padding to IOU Detail Modal
Julesssss
committed
32e00f4
use email const
Julesssss
committed
867bd47
add PayIOU request/action
Julesssss
committed
3ced807
open IOUReport dynamically, by retrieving ID from transaction
Julesssss
committed
a03e474
fix double Onyx subscription
Julesssss
committed
d755943
update TransactionItem component to take action
Julesssss
committed
0c76ef1
find action and pass to TransactionItem
Julesssss
committed
57c4789
post rebase formatting fixes
Julesssss
committed
80d373f
prep and comments for post Preview UI work
Julesssss
committed
d5bec43
display temp button to unblock removeTransaction functionality
Julesssss
committed
b063b9c
add rejectTransaction API call and IOU Action function
Julesssss
committed
f15262e
rename ...IOUPreview Component to ...IOUAction
Julesssss
committed
5de6dc9
refactor IOUAction, splitting out IOUPreview to reusable Component
Julesssss
committed
74a0d53
format IOU Action
Julesssss
committed
68c0041

Commits on Apr 27, 2021

Commits on Apr 28, 2021

Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
a8aa309
display transaction in same style as chat comment
Julesssss
committed
178bb00

Commits on Apr 29, 2021

Commits on Apr 30, 2021

Commits on May 4, 2021

refactor IOUTransactions name and file location
Julesssss
committed
7fd307d
fix bad View import
Julesssss
committed
e43f51c

Commits on May 5, 2021

use the updated IOUAction data
Julesssss
committed
5de2094
display loading indicator while IOU Report is fetched
Julesssss
committed
718c712

Commits on May 6, 2021

Commits on May 7, 2021

hide settlement button for settled IOUs
Julesssss
committed
827eb35
show 'userA paid userB' in Preview if IOU is settled
Julesssss
committed
5bab22b
remove divider from IOUModal
Julesssss
committed
959d3e7
IOUPreview formatting
Julesssss
committed
c3ef642
update the IOU report after settling it
Julesssss
committed
c33a2bd
implement basic logic for preventing rejection of settled report transactions
Julesssss
committed
297f905
simplify IOU Detail transactions
Julesssss
committed
7796cae
ensure reportIDs props are passed as Number
Julesssss
committed
c70a2f9
clear IOU state on app restart
Julesssss
committed
005c34f
formatting improvements and fixes
Julesssss
committed
5efb7d4
remove comments
Julesssss
committed
360ccfd

Commits on May 10, 2021

replace error with debug log
Julesssss
committed
ae72d44
active IOuReportID was passed, should instead be retrieved from the IOUACTION
Julesssss
committed
6f9cb9a
simplify isDMChat logic
Julesssss
committed
d2a4c24
remove rejectTransaction logic for next PR
Julesssss
committed
93dc2e5
Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
0b5fd65
fix IOU prop default
Julesssss
committed
f523ba5
allow IOU transactions to scroll, fix padding
Julesssss
committed
5d28272
replace error with log
Julesssss
committed
6b674ad
proptype fixes
Julesssss
committed
544246d
update podfile
Julesssss
committed
ebe94d3
pass unique key to transaction Components
Julesssss
committed
55501d6
fix issue where reportID was passed outside of array
Julesssss
committed
5a5a69f
remove useless comment
Julesssss
committed
900ff6c
ensure a null IOU report will not be rendered
Julesssss
committed
ec0e19c
remove useless style
Julesssss
committed
84d1c9f
re-enables flipper, I'll leave a note in the PR instead
Julesssss
committed
2a6a661
remove useless console log
Julesssss
committed
4e92ed0
fix bug where incorrect import is used
Julesssss
committed
fdec47e
change iouReportID default
Julesssss
committed
e8e9f4e
format podfile, to avoid any change
Julesssss
committed
d5057de
reverse podfile commit
Julesssss
committed
643e768
add additional comments
Julesssss
committed
d0a5329
revert pod changes, to exclude Flipper workaround
Julesssss
committed
8634f3d

Commits on May 11, 2021

Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
d0ce923
iou error is now of type string
Julesssss
committed
c74cf3f
improve prop name
Julesssss
committed
73d7e87
invert hasMultipleParticipants logic to simplify
Julesssss
committed
01403b8
move IOUPreview session subscription out of parent
Julesssss
committed
e1920fa
remove useless outer style for Preview comp
Julesssss
committed
adfa4b3
various prop improvements
Julesssss
committed
2841e9a
improvements to IOUDetailModal
Julesssss
committed
8ee1595
replace IOUTransaction PureComponent with Component
Julesssss
committed
d14fff9
refactor style name
Julesssss
committed
96471cd
document getSimplifiedIOUReport function
Julesssss
committed
6368d7f
add explanation for removing the IOU Report empty error message
Julesssss
committed
aead72e
improve comments
Julesssss
committed
7d33d18
Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
a0d49a4
further formatting and code review adjustments
Julesssss
committed
6973227
throw error instead of just printing an error message
Julesssss
committed
e3575d8
improve and simplify logic for updating reports, with better documentation
Julesssss
committed
2e57b60
additional formatting
Julesssss
committed
bf76b01
Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
427283d
minor formatting fix
Julesssss
committed
762d452

Commits on May 12, 2021

rename iouTransactionProp to camelCase
Julesssss
committed
a3906dc
make ReportActionItemIOUAction a stateless function
Julesssss
committed
b12022a
Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
158bd98
clarify transaction/action matching logic
Julesssss
committed
4ae8b85
replace null check with undefined check
Julesssss
committed
ed2a838
remove iouTransaction props
Julesssss
committed
eb80f91
replace prop-type file with camelCase (case change wasn't recognised by git)
Julesssss
committed
95d1758
Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
6256019
modify pPromise chain to take function
Julesssss
committed
124a547

Commits on May 13, 2021

Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
cc3c2ea
locallize hardcoded strings
Julesssss
committed
fc637b8
further document the logic behind linking chat and iou reports
Julesssss
committed
50f8dbb
further function documentation
Julesssss
committed
d780c1b
add back blockquote for web override
Julesssss
committed
cc6a450
fix lint warning
Julesssss
committed
918b7b6
refactor ReportActionItem IOU Components and rename
Julesssss
committed
db86f85
define const for launch modal callback
Julesssss
committed
bdbc65e
replace reference to settled with paid, improve other comments
Julesssss
committed
4c3ccf9
remove unnecessary use of View, reorder defaultProps, remove function
Julesssss
committed
1984da1
style improvements, based on review feedback
Julesssss
committed
61e0446
further review feedback applied
Julesssss
committed
d17e8bd

Commits on May 14, 2021

Commits on May 17, 2021

refactor IOU components back to original location and name for now
Julesssss
committed
a990a54
update prop type to fix type warning
Julesssss
committed
9f85df1
Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
4fa35c2
reuse the translate function
Julesssss
committed
260aca9
rewrite the fetchIOUReportByID... function docs to make clearer
Julesssss
committed
8fbe49d
improved comment formatting
Julesssss
committed
c10d6ac
update fetchIOUReportID... param docs too
Julesssss
committed
d7f213c
migrate to new latest propType style
Julesssss
committed
c1c5c2e
apply code review feedback fixes and improvements
Julesssss
committed
bfaef8e
switch transactionID type to String, to prevent conversion bug
Julesssss
committed
e548db2
further improve comments based upon review feedback
Julesssss
committed
129dded
reverse accidental removal of image
Julesssss
committed
f43bbf0
additional usage of sync
Julesssss
committed
9054afc
Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
3fdc230
prevents .toString from being called on undefined
Julesssss
committed
b403daa
simplify fetchIOUReportByIDAndUpdateChatReport function name, reuse 'fetchIOUReportByID'
Julesssss
committed
d173c81
fixed exception that was recently introduced, to ensure that the PR is testable
Julesssss
committed
92e2263

Commits on May 18, 2021

additional comment improvements
Julesssss
committed
5a7a25a
Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
eeb1a7a
Merge branch 'main' into jules-iouDetailsModal
Julesssss
committed
49b3787
ensure that activityIndicator displays when loading paid reports
Julesssss
committed
a1ef2b9
remove iouReport isRequired, as this is no longer true
Julesssss
committed
3f6fafd
reverse user 'paid' user message
Julesssss
committed
2edf67d