Disable go to profile page for optimistic user by dukenv0307 · Pull Request #23802 · Expensify/App

dukenv0307 · 2023-07-28T15:04:39Z

Details

Disable go to profile page for optimistic user

Fixed Issues

$ #22691
PROPOSAL: #22691 (comment)

Tests

Login with any account
Go offline
Create a new chat with the user that isn't a recent contact
In the report, click the header
Verify that the cursor is disabled and can not open profile page
Click on the display of the user in welcome message text
Verify that the cursor is text and can not open profile page
Create a group chat with the user that isn't a recent contact
In the report, click the header to open participant page
Click on the avatar of this user
Verify that the cursor is disable and can not open profile page
Go online and verify that the cursor is changed to pointer and can open profile page
Go to FAB > request money
Enter any amount to go to the next step
Search and select the user that isn't a recent contact
In confirm page, verify that the cursor is disabled when hovering over the avatar and can not open profile page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with any account
Go offline
Create a new chat with the user that isn't a recent contact
In the report, click the header
Verify that the cursor is disabled and can not open profile page
Click on the display of the user in welcome message text
Verify that the cursor is text and can not open profile page
Create a group chat with the user that isn't a recent contact
In the report, click the header to open participant page
Click on the avatar of this user
Verify that the cursor is disable and can not open profile page
Go online and verify that the cursor is changed to pointer and can open profile page
Go to FAB > request money
Enter any amount to go to the next step
Search and select the user that isn't a recent contact
In confirm page, verify that the cursor is disabled when hovering over the avatar and can not open profile page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.29-07-2023.14.33.57.webm

Mobile Web - Chrome

Record_2023-07-29-14-38-51.1.mp4

Mobile Web - Safari

Screen.Recording.2023-07-29.at.15.54.59.mp4

Desktop

Screen.Recording.2023-07-29.at.15.46.05.2.mp4

iOS

Screen.Recording.2023-07-29.at.16.16.36.mp4

Android

22691.mp4

melvin-bot · 2023-07-29T09:29:53Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss

Just to confirm, after creating the request we should NOT be able to view the profile? In my case I could, but maybe this is due to my dev build not being truly offline?

Screen.Recording.2023-07-31.at.09.14.04.mov

sobitneupane

I was also able to reproduce the issue mentioned by @Julesssss.

Screen.Recording.2023-07-31.at.14.52.17.mov

dukenv0307 · 2023-07-31T10:05:04Z

@sobitneupane @Julesssss Yes, I've missed this avatar yet. Updated the PR to fix this issue.

dukenv0307 · 2023-08-01T03:07:36Z

@sobitneupane Could you check again? Thanks
cc @Julesssss

sobitneupane

@dukenv0307 In split bill, I was unable to deselect newly added contact in offline.

Screen.Recording.2023-08-01.at.13.57.16.mov

sobitneupane · 2023-08-01T08:18:24Z

The other thing I noticed was Disabled Mouse Cursor. @Julesssss Do we want to show disabled mouse cursor when user won't be able to go to Profile page? I think showing normal cursor instead of hand pointer should convey the message to user that the item is not pressable.

dukenv0307 · 2023-08-01T08:37:13Z

@sobitneupane I think it's hard to display normal cursor because disable style of base components is disable cursor.

dukenv0307 · 2023-08-01T08:40:43Z

@dukenv0307 In split bill, I was unable to deselect newly added contact in offline.

@sobitneupane Updated to resolve this case. Please help to continue the review.

Julesssss · 2023-08-01T09:22:11Z

I think it's hard to display normal cursor because disable style of base components is disable cursor.

Damn, in that case lets leave it for now.

dukenv0307 · 2023-08-02T07:47:38Z

@sobitneupane Please help to review again when you have a chance.

sobitneupane

Screenshots/Videos

Web

Screen.Recording.2023-08-02.at.14.59.45.mov

Screen.Recording.2023-08-02.at.15.09.01.mov

Mobile Web - Chrome

Mobile Web - Safari

Screen.Recording.2023-08-02.at.15.31.37.mov

Desktop

Screen.Recording.2023-08-02.at.15.20.49.mov

Screen.Recording.2023-08-02.at.15.24.09.mov

iOS

Screen.Recording.2023-08-02.at.15.34.16.mov

Android

Screen.Recording.2023-08-02.at.15.27.59.mov

Screen.Recording.2023-08-02.at.15.30.00.mov

sobitneupane · 2023-08-02T10:10:54Z

@dukenv0307 There were few issues in the request money flow. Can you please merge main and check the following issues.

Console error on pressing request money
Had to press Next button twice in request money flow

Screen.Recording.2023-08-02.at.15.34.16.mov

dukenv0307 · 2023-08-02T10:12:41Z

@sobitneupane I just tested request money flow in main branch and has the same issue. This PR doesn't cause this issue.

dukenv0307 · 2023-08-02T10:21:15Z

@sobitneupane #23962 Here is the deploy blocker of this issue above. I just run npm install to update react-native-onyx lib again and this issue above doesn't happen.

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Julesssss

Testing nicely. The only case we don't show the cursor is the LHn, which I think is fine.

OSBotify · 2023-08-02T11:15:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

hungvu193 · 2023-08-03T11:02:01Z

Hey guys, is this expected to prevent member of the room or anonymous from clicking header detail?

hover.mov

dukenv0307 · 2023-08-03T11:05:44Z

@hungvu193 Seems shouldDisablePage function is not working as expected.

hungvu193 · 2023-08-03T11:08:45Z

@hungvu193 Seems shouldDisablePage function is not working as expected.

Yeah. There're 2 cases I think you need to improve that function, member of the room and anonymous user.
Here's the slack report btw:
https://expensify.slack.com/archives/C049HHMV9SM/p1691038592033389

dukenv0307 · 2023-08-03T11:17:26Z

@sobitneupane I think we have a regression here because I missed the case for chat room in shouldDisableDetailPage, do we need to create PR to fix it quickly?

dukenv0307 · 2023-08-03T13:18:34Z

@sobitneupane The draft is created, do we need to wait for issue created to open it or not?

OSBotify · 2023-08-03T17:42:22Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Julesssss · 2023-08-07T10:16:42Z

The draft is created, do we need to wait for issue created to open it or not?

I think you know this now, but yeah the PR should be created against the new bug issue. Then we can link it to this one via a comment.

OSBotify · 2023-08-07T18:30:42Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:57:55Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:47:03Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ntdiary · 2024-02-27T13:35:05Z

        } else {
+            const formattedSelectedParticipants = _.map(props.selectedParticipants, (participant) => ({
+                ...participant,
+                isDisabled: ReportUtils.isOptimisticPersonalDetail(participant.accountID),


Coming from #33976.
workspace's accountID is always 0, which resulting in it's always disabled. :)

dukenv0307 added 2 commits July 28, 2023 21:50

disable go to profile page for optimistic user

c5cfe64

fix lint

9241de7

dukenv0307 marked this pull request as ready for review July 29, 2023 09:29

dukenv0307 requested a review from a team as a code owner July 29, 2023 09:29

melvin-bot bot requested review from sobitneupane and removed request for a team July 29, 2023 09:29

dukenv0307 mentioned this pull request Jul 29, 2023

[HOLD for checklist][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money #22691

Closed

6 tasks

Julesssss assigned dukenv0307 Jul 31, 2023

Julesssss reviewed Jul 31, 2023

View reviewed changes

sobitneupane reviewed Jul 31, 2023

View reviewed changes

dukenv0307 added 2 commits July 31, 2023 16:50

Merge branch 'main' into fix/22691

48e015e

disable go to profile page for avatar of action item created

d77ff1a

disable for actor's avatar of action

bcd13a9

sobitneupane reviewed Aug 1, 2023

View reviewed changes

fix split bill option

7d25e64

Merge branch 'main' into fix/22691

cf90c13

sobitneupane reviewed Aug 2, 2023

View reviewed changes

Merge branch 'main' into fix/22691

b0c21aa

sobitneupane approved these changes Aug 2, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss August 2, 2023 10:48

Julesssss approved these changes Aug 2, 2023

View reviewed changes

Julesssss merged commit 577152d into Expensify:main Aug 2, 2023

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

StevenKKC mentioned this pull request Aug 3, 2023

[HOLD for payment 2023-08-16] User can't click on header to open detail of public room #24124

Closed

6 tasks

sobitneupane mentioned this pull request Aug 4, 2023

[CP Staging] Fix user cannot open detail page of chat room #24091

Merged

58 tasks

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

sobitneupane mentioned this pull request Aug 21, 2023

Add tooltips and nav to bill details #20746

Merged

57 tasks

kameshwarnayak mentioned this pull request Aug 25, 2023

[$1000] Web - Avatar Unresponsiveness When Starting New Chat with New Email #25798

Closed

6 tasks

DylanDylann mentioned this pull request Nov 6, 2023

[$500] Scan - Chat header is disabled when creating a Scan request with a user with no prior chat #29563

Closed

6 tasks

bernhardoj mentioned this pull request Dec 14, 2023

[$500] Chat-Email id is not shown as link and directed to profile page. #33044

Closed

6 tasks

tienifr mentioned this pull request Dec 28, 2023

[$500] Chat - In offline mode, starting a new chat results in the header being greyed out and tapping on it doesn't trigger any action #33678

Closed

6 tasks

ntdiary reviewed Feb 27, 2024

View reviewed changes

ntdiary mentioned this pull request Feb 27, 2024

[HOLD for payment 2024-02-26] [$500] Workspace name in Distance request flow is wrong color #33976

Closed

6 tasks

rojiphil mentioned this pull request Jul 25, 2024

[HOLD for payment 2024-07-22] [$250] Categorizing- Workspace chat under To field opens not here page when new WS is not created yet #42552

Closed

6 tasks

Conversation

dukenv0307 commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 29, 2023

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jul 31, 2023

Uh oh!

dukenv0307 commented Aug 1, 2023

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

Uh oh!

sobitneupane commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julesssss commented Aug 1, 2023

Uh oh!

dukenv0307 commented Aug 2, 2023

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

Uh oh!

sobitneupane commented Aug 2, 2023

Uh oh!

dukenv0307 commented Aug 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Aug 2, 2023

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 2, 2023

Uh oh!

hungvu193 commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Aug 3, 2023

Uh oh!

hungvu193 commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Aug 3, 2023

Uh oh!

dukenv0307 commented Aug 3, 2023

Uh oh!

OSBotify commented Aug 3, 2023

Uh oh!

Julesssss commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 9, 2023

dukenv0307 commented Jul 28, 2023 •

edited

Loading

sobitneupane commented Aug 1, 2023 •

edited

Loading

dukenv0307 commented Aug 1, 2023 •

edited

Loading

dukenv0307 commented Aug 1, 2023 •

edited

Loading

dukenv0307 commented Aug 2, 2023 •

edited

Loading

hungvu193 commented Aug 3, 2023 •

edited

Loading

hungvu193 commented Aug 3, 2023 •

edited

Loading