Update header subtitle styles for thread (child) reports by grgia · Pull Request #23621 · Expensify/App

grgia · 2023-07-26T09:39:55Z

Details

Updates the header parentNavigationSubtitle to use this styling:

Requirements:

Room is blue
Entire line is clickable

Fixed Issues

$ #22641

Tests / QA Steps

Verify that no errors appear in the JS console

Step 2: Open a thread report from a DM.

QA Style matches the following:
- Format is From <DM report title>
- Only room title is blue
- Entire row is still clickable (NOT A BUG)

Step 2: Open a thread report from a Workspace Room.

QA Style matches the following:
- Format is From <DM report title> in <workspace name>
- Only room title is blue
- Entire row is still clickable (NOT A BUG)

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-07-27T12:53:20Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2023-07-27T12:53:52Z

@s77rt getting my emulators up to get screenshots on all platforms now, so that shouldn't block C+ review, thank you!

grgia · 2023-07-28T14:08:30Z

@s77rt ready for another review

s77rt · 2023-07-28T15:18:08Z

+        return {rootReportName, workspaceName};
    }
-    return '';
+    return {};


Update the JSDoc that this returns an object and not a string

s77rt · 2023-07-28T21:45:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

grgia · 2023-08-02T12:59:22Z

@s77rt pushed your suggestions, thank you.
A friendly suggestion for next time, let's aim to keep to PRs moving smoothly by avoiding blocking them on NAB changes for internal PRs. Thanks again for your review! 😊

s77rt · 2023-08-02T13:39:23Z

Sorry for that. Should I have approved the PR back then? There was only this remaining suggestion.

s77rt · 2023-08-02T13:41:48Z

Warning: Failed prop type: Invalid prop parentReportID of type number supplied to ParentNavigationSubtitle, expected string.

I don't think this is caused by this PR.

s77rt · 2023-08-02T14:35:18Z

Some onyx reports (e.g. task reports) seems to have parentReportID stored as a number. This is unrelated to this PR.

s77rt

LGTM! 🚀

melvin-bot · 2023-08-02T14:36:18Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi

looks good to me as well!

OSBotify · 2023-08-02T18:05:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

makiour · 2023-08-03T02:33:21Z

The last PR is causing bug in the mentionned issue above.
Explanation: The changes from Avatar to MultipleAvatars in this commit has caused the issue. The MultipleAvatar component doesn't conserve the avatarContainerStyles and it doesn't have containerStyles in its properties.

s77rt · 2023-08-03T10:51:34Z

@makiour I think you are commenting in the wrong PR. Did you meant #22467?

Pujan92 · 2023-08-03T13:22:33Z

@grgia Seems a regression from this PR
https://expensify.slack.com/archives/C049HHMV9SM/p1691035111039979

not a regression from this PR, seems to be a backend issue as passing parentReportID as a number.

OSBotify · 2023-08-03T17:41:46Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:30:06Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:57:19Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:46:27Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Pujan92 · 2024-11-30T12:39:06Z

+            style={[...props.pressableStyles]}
+        >
+            <Text
+                style={[styles.optionAlternateText]}


We need to set color here too for the ellipses as it caused issue #52381

Make only roomTitle blue

6356815

grgia self-assigned this Jul 26, 2023

grgia marked this pull request as ready for review July 27, 2023 12:53

grgia requested a review from a team as a code owner July 27, 2023 12:53

melvin-bot bot requested review from s77rt and removed request for a team July 27, 2023 12:53

s77rt suggested changes Jul 27, 2023

View reviewed changes

Comment thread src/libs/ReportUtils.js Outdated

Comment thread src/pages/home/HeaderView.js

Comment thread src/components/AvatarWithDisplayName.js Outdated

Comment thread src/components/ParentNavigationSubtitle.js

Comment thread src/components/parentNavigationPropTypes.js Outdated

grgia added 3 commits July 28, 2023 14:04

Merge branch 'main' into georgia-headerHoverLinkStyle

3a7f3d1

remove parentNavigationPropTypes

efe1132

remove hasParentNavigationSubtitle, add pressable styles, boolean check

99296ec

grgia requested a review from s77rt July 28, 2023 13:23

prettier

9ff6383

s77rt reviewed Jul 28, 2023

View reviewed changes

update jsDocs

82a2ef1

s77rt suggested changes Jul 28, 2023

View reviewed changes

Comment thread src/components/ParentNavigationSubtitle.js Outdated

only pass parentReportID

ca26b36

grgia requested a review from s77rt July 31, 2023 12:25

s77rt suggested changes Jul 31, 2023

View reviewed changes

Comment thread src/components/AvatarWithDisplayName.js Outdated

Merge branch 'main' into georgia-headerHoverLinkStyle

b361d2b

grgia requested a review from s77rt August 2, 2023 12:43

remove default to empty string for parentReportID

0ffabc8

s77rt approved these changes Aug 2, 2023

View reviewed changes

melvin-bot bot requested a review from srikarparsi August 2, 2023 14:36

srikarparsi approved these changes Aug 2, 2023

View reviewed changes

srikarparsi merged commit 811a83e into main Aug 2, 2023

srikarparsi deleted the georgia-headerHoverLinkStyle branch August 2, 2023 18:00

makiour mentioned this pull request Aug 3, 2023

[HOLD for payment 2023-08-10] Avatar style is broken in anonymous footer #24085

Closed

6 tasks

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

Nodebrute mentioned this pull request Aug 4, 2023

[HOLD for payment 2023-08-24] [$1000] Dev: Web - Console log on clicking IOU preview component #23645

Closed

6 tasks

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

Pujan92 reviewed Nov 30, 2024

View reviewed changes

Conversation

grgia commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests / QA Steps

Step 2: Open a thread report from a DM.

Step 2: Open a thread report from a Workspace Room.

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 27, 2023

Uh oh!

grgia commented Jul 27, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

grgia commented Jul 28, 2023

Uh oh!

s77rt Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

s77rt commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

grgia commented Aug 2, 2023

Uh oh!

s77rt commented Aug 2, 2023

Uh oh!

s77rt commented Aug 2, 2023

Uh oh!

s77rt commented Aug 2, 2023

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Aug 2, 2023

Uh oh!

srikarparsi left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 2, 2023

Uh oh!

makiour commented Aug 3, 2023

Uh oh!

s77rt commented Aug 3, 2023

Uh oh!

Pujan92 commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Aug 3, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

Pujan92 Nov 30, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

grgia commented Jul 26, 2023 •

edited

Loading

s77rt commented Jul 28, 2023 •

edited

Loading

Pujan92 commented Aug 3, 2023 •

edited

Loading