Fix: cannot change assignee after task created by dukenv0307 · Pull Request #23530 · Expensify/App

dukenv0307 · 2023-07-25T07:57:57Z

Details

We should use props.report and reportID from route instead of props.task.report

Fixed Issues

$ #23556
PROPOSAL: #23556 (comment)

Tests

Go to any task report
Click + on composer > Assign task
Click back button to close modal
Click Assignee field
Select a contact you have a chat with already.
Verify that selecting new contact successful without error
Repeat the process but this time when selecting a new contact, select someone you never talked to via chat.

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Go to any task report
Click + on composer > Assign task
Click back button to close modal
Click Assignee field
Select a contact you have a chat with already.
Verify that selecting new contact successful without error
Repeat the process but this time when selecting a new contact, select someone you never talked to via chat.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen-Recording-2023-08-01-at-13.29.47.mp4

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

Screen-Recording-2023-08-01-at-16.36.17.mp4

Android

android.mov

melvin-bot · 2023-08-01T10:19:38Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-08-02T07:46:03Z

@situchan Bump, Please help to review this PR

situchan · 2023-08-02T21:40:17Z

@dukenv0307 this is what I suggest. does it make sense?

+   const report = useMemo(() => {
+       if (!props.route.params || !props.route.params.reportID) {
+           return null;
+       }
+       return props.reports[`${ONYXKEYS.COLLECTION.REPORT}${props.route.params.reportID}`];
+   }, [props.reports, props.route.params]);

...

        // Check to see if we're editing a task and if so, update the assignee
-       if (props.route.params.reportID && props.task.report.reportID === props.route.params.reportID) {
+       if (report) {
            // There was an issue where sometimes a new assignee didn't have a DM thread
            // This would cause the app to crash, so we need to make sure we have a DM thread
-           Task.setAssigneeValue(option.login, option.accountID, props.task.shareDestination, OptionsListUtils.isCurrentUser(option));
+           Task.setAssigneeValue(option.login, option.accountID, props.route.params.reportID, OptionsListUtils.isCurrentUser(option));

            // Pass through the selected assignee
-           Task.editTaskAndNavigate(props.task.report, props.session.accountID, {
+           Task.editTaskAndNavigate(report, props.session.accountID, {
                assignee: option.login,
                assigneeAccountID: option.accountID,
            });
        }
    };

    return (
        <ScreenWrapper includeSafeAreaPaddingBottom={false}>
            {({didScreenTransitionEnd, safeAreaPaddingBottomStyle}) => (
                <>
                    <HeaderWithBackButton
                        title={props.translate('task.assignee')}
-                       onBackButtonPress={() => (lodashGet(props.task.report, 'isExistingTaskReport') ? Navigation.dismissModal() : Navigation.goBack(ROUTES.NEW_TASK))}
+                       onBackButtonPress={() => (report ? Navigation.dismissModal() : Navigation.goBack(ROUTES.NEW_TASK))}
                    />

dukenv0307 · 2023-08-03T02:54:16Z

@situchan Thanks for suggestion, I just updated

situchan · 2023-08-03T09:35:15Z

@dukenv0307 please pull main

dukenv0307 · 2023-08-03T09:49:17Z

@situchan Updated

situchan · 2023-08-03T09:52:07Z

+        if (!props.route.params || !props.route.params.reportID) {
+            return null;
+        }
+        return lodashGet(props.reports, `${ONYXKEYS.COLLECTION.REPORT}${props.route.params.reportID}`, undefined);


I don't think lodashGet is necessary here as props.reports and props.route.params always exist

@situchan Make sense. Thanks for your comment. I updated

situchan · 2023-08-03T09:57:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

LGTM
@pecanoro all yours

dukenv0307 · 2023-08-07T03:35:26Z

@pecanoro Friendly bump, please help to review this PR, thanks

pecanoro

Can you pull main? We just merged this one #24055 and I think we can simply use the reportID instead of having to get the whole report

situchan · 2023-08-07T17:43:16Z

I think we can simply use the reportID instead of having to get the whole report

Task.editTaskAndNavigate requires whole report as first param.
But agree in onBackButtonPress only reportID can be used while fixing conflict.

dukenv0307 · 2023-08-08T02:31:49Z

@situchan @pecanoro I just updated. Sorry for my lateness because it was the night at my place 😄

pecanoro · 2023-08-08T12:39:32Z

@dukenv0307 @situchan So I tested it again and it's not working when assigning someone to the existing task after closing the new task, I am getting an error in the console as well:

situchan · 2023-08-08T12:51:39Z

I just tested again and no issue for me.
Are you sure that you tested this branch, not main?

pecanoro · 2023-08-08T12:57:42Z

Hmm, I am on the branch for sure, let me test again

pecanoro · 2023-08-08T12:58:24Z

I also checked I am in the last commit:

pecanoro · 2023-08-08T13:12:46Z

Ok, it happens when you assign someone you have never talked to, if you assign someone for which you already have a report, it works fine:

Monosnap.screencast.2023-08-08.15-09-09.mp4

situchan · 2023-08-08T13:29:32Z

ok, reproduced. Seems like different root cause which also happens on main.

On this line:

App/src/libs/actions/Task.js

Line 422 in fdcae9f

    
           assigneeChatReportID = ReportUtils.getChatByParticipants([assigneeAccountID]).reportID;

dukenv0307 · 2023-08-08T14:11:57Z

@situchan @pecanoro I just fixed it, help to review again. Thanks

pecanoro

LGTM and it's working well now!

OSBotify · 2023-08-08T14:51:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-09T09:11:29Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:50:12Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-10T20:08:38Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

use props.report instead of task.report

94a04ac

This was referenced Jul 25, 2023

[HOLD for payment 2023-08-03] [$1000] IOS - The title field is cleared when the Confirm task button is pressed #22078

Closed

[HOLD for payment 2023-08-17] [$1000] Cannot change assignee after task created #23556

Closed

dukenv0307 added 2 commits August 1, 2023 13:05

ussing reportID from route

5e5fd81

run prettier

14073e8

dukenv0307 changed the title ~~use props.report instead of task.report~~ Fix: cannot change assignee after task created Aug 1, 2023

dukenv0307 marked this pull request as ready for review August 1, 2023 10:19

dukenv0307 requested a review from a team as a code owner August 1, 2023 10:19

melvin-bot bot removed the request for review from a team August 1, 2023 10:19

melvin-bot bot requested a review from situchan August 1, 2023 10:19

situchan reviewed Aug 2, 2023

View reviewed changes

Comment thread src/pages/tasks/TaskAssigneeSelectorModal.js Outdated

make code dry

f94b259

merge main

1c48cdd

situchan reviewed Aug 3, 2023

View reviewed changes

dukenv0307 added 2 commits August 3, 2023 17:07

remove lodashget

32efe36

remove lodashget

47414f8

situchan approved these changes Aug 3, 2023

View reviewed changes

melvin-bot bot requested a review from pecanoro August 3, 2023 15:58

pecanoro requested changes Aug 7, 2023

View reviewed changes

merge main

5644e7f

situchan approved these changes Aug 8, 2023

View reviewed changes

melvin-bot bot requested a review from pecanoro August 8, 2023 02:34

fix error when assign totalnew person

a1e39d1

pecanoro approved these changes Aug 8, 2023

View reviewed changes

pecanoro merged commit b812cfe into Expensify:main Aug 8, 2023

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

Conversation

dukenv0307 commented Jul 25, 2023 • edited by pecanoro Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 1, 2023

Uh oh!

dukenv0307 commented Aug 2, 2023

Uh oh!

Uh oh!

situchan commented Aug 2, 2023

Uh oh!

dukenv0307 commented Aug 3, 2023

Uh oh!

situchan commented Aug 3, 2023

Uh oh!

dukenv0307 commented Aug 3, 2023

Uh oh!

situchan Aug 3, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Aug 7, 2023

Uh oh!

pecanoro left a comment

Choose a reason for hiding this comment

Uh oh!

situchan commented Aug 7, 2023

Uh oh!

dukenv0307 commented Aug 8, 2023

Uh oh!

pecanoro commented Aug 8, 2023

Uh oh!

situchan commented Aug 8, 2023

Uh oh!

pecanoro commented Aug 8, 2023

Uh oh!

pecanoro commented Aug 8, 2023

Uh oh!

pecanoro commented Aug 8, 2023

Uh oh!

situchan commented Aug 8, 2023

Uh oh!

dukenv0307 commented Aug 8, 2023

Uh oh!

pecanoro left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 8, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

dukenv0307 commented Jul 25, 2023 •

edited by pecanoro

Loading

dukenv0307 Aug 3, 2023 •

edited

Loading

situchan commented Aug 3, 2023 •

edited

Loading