Ishpaul777/rhn no dropzone by ishpaul777 · Pull Request #23528 · Expensify/App

ishpaul777 · 2023-07-25T07:32:17Z

Details

Fixed Issues

$ #22305
PROPOSAL: #22305 (comment)

Tests

Verify that no errors appear in the JS console
Verify user can drop a file on a chat report.
Verfify user can't drop file on LHN.
Navigate to RHN, Verify user can't drop a file when RHN is open,( if file is dropped no new tab opens)
Close RHN, Verify we can drop file on Chat report.

Offline tests

Go Offline.
Verify user can drop a file on a chat report.
Verfify user can't drop file on LHN.
Navigate to RHN, Verify user can't drop a file when RHN is open,( if file is dropped no new tab opens)
Close RHN, Verify we can drop file on Chat report.

QA Steps

Verify that no errors appear in the JS console
Verify user can drop a file on a chat report.
Verfify user can't drop file on LHN.
Navigate to RHN, Verify user can't drop a file when RHN is open,( if file is dropped no new tab opens)
Close RHN, Verify we can drop file on Chat report.

PR Author Checklist

Screenshots/Videos

Web

Mac (chrome)-

mac-chrome.mp4

Mac (safari)-

safari.mp4

Windows (chrome) -

win-chrome.mp4

Mobile Web - Chrome

mobile-web.mp4

Mobile Web - Safari

safari-ios.mp4

Desktop

(Same as before changes)

mac-desktop.mp4

iOS

ios-app.mp4

Android

android.mp4

melvin-bot · 2023-07-25T07:32:22Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

robertKozik · 2023-07-25T07:57:22Z

@ishpaul777, ping me when you have completed the checklist and the PR will be ready for review.

ishpaul777 · 2023-07-25T08:14:26Z

@robertKozik done! PR is ready.

ishpaul777 · 2023-07-25T13:43:50Z

@robertKozik any updates?

robertKozik · 2023-07-25T21:41:09Z

Sorry, I was focused on other issues. I'll address it tomorrow.

robertKozik · 2023-07-26T07:15:09Z

BUG: when overing over RHN options with attachments, options are being highlighted (not reproducible on main)

VIDEO:

bug-rhn-highlightling.mov

CC. @ishpaul777

ishpaul777 · 2023-07-26T11:51:14Z

@robertKozik Are you sure this is not reproducable on the main. I can repro on production.

bug.on.prod.mp4

tried a few things to fix it, but couldn't find a satisfactory solution.

robertKozik · 2023-07-26T12:14:50Z

I see, I'll check it once again, It can by my fault.

But still, I think this PR can try address issue. Can't we disable any pointer interactions on drag?

ishpaul777 · 2023-07-26T16:24:06Z

@robertKozik
I couldn't get to a satisfactory solution for this bug. Love to get your thoughts. Here are potential solutions explored:

used a state to capture whether user is dragging over and when isDraggingOver applied pointerEvents='none' to View.

 <NoDropZone
   key={route.key}
   setIsDraggingOver={setIsDraggingOver}
   isDraggingOver={isDraggingOver}
>
   <View
       pointerEvents={isDraggingOver ? 'none' : 'auto'}
       style={[
           styles.flexRow,
           styles.pAbsolute,
           styles.w100,
           styles.h100,
           StyleUtils.getBackgroundColorWithOpacityStyle(themeColors.shadow, CONST.RIGHT_MODAL_BACKGROUND_OVERLAY_OPACITY),
           StyleUtils.displayIfTrue(props.state.index === i),
       ]}
   >
       <PressableWithoutFeedback
           style={[styles.flex1]}
           onPress={() => props.navigation.goBack()}
           accessibilityLabel={translate('common.close')}
           accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
       />
       <View style={styles.rightPanelContainer}>{props.descriptors[route.key].render()}</View>
   </View>
</NoDropZone>

having a transparent overlay while dragging over on full screen.

<NoDropZone
  key={route.key}
  setIsDraggingOver={setIsDraggingOver}
  isDraggingOver={isDraggingOver}
>
  <View        
  style={[
          styles.flexRow,
          styles.pAbsolute,
          styles.w100,
          styles.h100,
          StyleUtils.getBackgroundColorWithOpacityStyle(themeColors.shadow, CONST.RIGHT_MODAL_BACKGROUND_OVERLAY_OPACITY),
          StyleUtils.displayIfTrue(props.state.index === i),
      ]}
  >
      {{isDraggingOver && (<View style={styles.dropZoneTopInvisibleOverlay} />)}}
      <PressableWithoutFeedback
          style={[styles.flex1]}
          onPress={() => props.navigation.goBack()}
          accessibilityLabel={translate('common.close')}
          accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
      />
      <View style={styles.rightPanelContainer}>{props.descriptors[route.key].render()}</View>
  </View>
</NoDropZone>

Problem applying them:

We set the isdraggingOver event like below, here when we dragover the child elments (say the RHN), unwanted dragleave event fires set isDraggingover state back to false, and then again dragover event kicks in set the isdraggingover to true, this results in continuous state changing while dragover, to tackle the same situation here we applied another transparent overlay, which here is not possible because it blocks the user interaction completly.

function NoDropZone(props) {
   const {setIsDraggingOver, isDraggingOver} = props;

   function handleDragEnter(event) {
       event.preventDefault();
       // eslint-disable-next-line no-param-reassign
       event.dataTransfer.dropEffect = 'none';
       if (isDraggingOver) {
           return;
       }
       setIsDraggingOver(true);
   }

   function handleDragOver(event) {
       event.preventDefault();
       // eslint-disable-next-line no-param-reassign
       event.dataTransfer.dropEffect = 'none';
   }


   function handleDragLeave(event) {
       event.preventDefault();
       setIsDraggingOver(false);
   }

   useEffect(() => {
       document.addEventListener('dragenter', handleDragEnter);
       document.addEventListener('dragover', handleDragOver);
       document.addEventListener('dragleave', handleDragLeave);

       return () => {
           document.removeEventListener('dragenter', handleDragEnter);
           document.removeEventListener('dragover', handleDragOver);
           document.removeEventListener('dragleave', handleDragLeave);
       };
   }, []);

// rest of code

ishpaul777 · 2023-07-27T05:32:00Z

Bump @robertKozik, can you please update me. thanks!

robertKozik · 2023-07-27T07:48:58Z

Thank you for your insights on this. I thought It would be more simple to solve. This said I think we can proceed with this PR without fixing it, as it can be also reproduced on main. I'll post a bug report afterwards about it

robertKozik · 2023-07-27T07:50:24Z

@ishpaul777 Could you clean up your code from the noDropZoneTopInvisibleOverlay tryouts? I'll proceed with the reviewer checklist then

ishpaul777 · 2023-07-27T08:02:24Z

@robertKozik thanks for pointing this out, I commited unnecessary changes by mistake, did the clean up

ishpaul777 · 2023-07-27T09:37:40Z

Bump @robertKozik for final review! thanks

robertKozik · 2023-07-27T11:01:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.-.web.mov

Mobile Web - Safari

iOS.-.web.mov

Desktop

Desktop.mov

iOS

IOS.-.native.mov

Android

Screen.Recording.2023-07-27.at.15.13.32.mov

robertKozik

One minor change: unnesessary comment and we will be ready to go.

Also if you would be able to fill remaining videos/screenshots. I know they are unrelated to drop zone behaviour, just show that RHN is render correctly and there is nothing wrong with it after your changes

ishpaul777 · 2023-07-27T13:59:27Z

@robertKozik ~~how can i build the app for mobile chrome. Can you please guide me?~~

ishpaul777 · 2023-07-27T14:12:29Z

@robertKozik done! update the videos

robertKozik

Great, thanks for your cooperation @ishpaul777

dangrous

Looks good, though we should definitely file a new bug report for that existing bug, can you handle that in Slack if you haven't already? Thanks!

OSBotify · 2023-07-27T16:41:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

robertKozik · 2023-07-27T16:42:05Z

@dangrous Posted already, here is a link

OSBotify · 2023-07-27T22:06:22Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dangrous · 2023-07-28T14:23:13Z

Lovely thank you!

Beamanator · 2023-07-31T11:45:03Z

Possible regression: #23881

OSBotify · 2023-07-31T18:34:51Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ishpaul777 added 8 commits July 21, 2023 23:10

Update Permissions.js

42fa1f6

Merge branch 'Expensify:main' into main

f792bed

Merge branch 'Expensify:main' into main

4797e42

Merge branch 'Expensify:main' into main

ad73827

made RHN modal no dropzone

c6ba18f

Merge branch 'Expensify:main' into main

b6f8f2a

Merge branch 'main' into ishpaul777/RHN-no-dropzone

f1f6e94

code linting and permission reverted

79bc7d2

ishpaul777 requested a review from a team as a code owner July 25, 2023 07:32

melvin-bot bot removed the request for review from a team July 25, 2023 07:32

melvin-bot bot requested a review from robertKozik July 25, 2023 07:32

remove consoles and fixes lint errrors

3134ac2

ishpaul777 added 2 commits July 26, 2023 16:31

fixes flickering cursor on continuous dragover

e3ddd35

code linting

1f2edf6

code clean up

4f1cbc3

robertKozik suggested changes Jul 27, 2023

View reviewed changes

Comment thread src/components/DragAndDrop/NoDropZone/index.native.js Outdated

remove unnecessary comments

4ab39f8

ishpaul777 requested a review from robertKozik July 27, 2023 14:12

robertKozik approved these changes Jul 27, 2023

View reviewed changes

melvin-bot bot requested a review from dangrous July 27, 2023 14:30

dangrous approved these changes Jul 27, 2023

View reviewed changes

dangrous merged commit 98ec467 into Expensify:main Jul 27, 2023

OSBotify mentioned this pull request Jul 27, 2023

Deploy Checklist: New Expensify 2023-07-27 #23765

Closed

79 tasks

allroundexperts mentioned this pull request Jul 29, 2023

[HOLD for payment 2023-09-04] [$1000] Not allowed sign does not show when an attachment is drag and dropped #22218

Closed

6 tasks

getusha mentioned this pull request Jul 30, 2023

[HOLD for payment 2023-08-08] [$1000] Dev: Web - Can't click plus button after leaving a room #23881

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 31, 2023

[HOLD for payment 2023-08-08] [$1000] Web - The Not Allowed sign is not shown when dragging & dropping attachments if the settings or search bar is open #22305

Closed

6 tasks

Conversation

ishpaul777 commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 25, 2023

Uh oh!

robertKozik commented Jul 25, 2023

Uh oh!

ishpaul777 commented Jul 25, 2023

Uh oh!

ishpaul777 commented Jul 25, 2023

Uh oh!

robertKozik commented Jul 25, 2023

Uh oh!

robertKozik commented Jul 26, 2023

Uh oh!

ishpaul777 commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robertKozik commented Jul 26, 2023

Uh oh!

ishpaul777 commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem applying them:

Uh oh!

ishpaul777 commented Jul 27, 2023

Uh oh!

robertKozik commented Jul 27, 2023

Uh oh!

robertKozik commented Jul 27, 2023

Uh oh!

ishpaul777 commented Jul 27, 2023

Uh oh!

ishpaul777 commented Jul 27, 2023

Uh oh!

robertKozik commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

robertKozik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ishpaul777 commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Jul 27, 2023

Uh oh!

robertKozik left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 27, 2023

Uh oh!

robertKozik commented Jul 27, 2023

Uh oh!

OSBotify commented Jul 27, 2023

Uh oh!

dangrous commented Jul 28, 2023

Uh oh!

Beamanator commented Jul 31, 2023

Uh oh!

OSBotify commented Jul 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

ishpaul777 commented Jul 25, 2023 •

edited

Loading

ishpaul777 commented Jul 26, 2023 •

edited

Loading

ishpaul777 commented Jul 26, 2023 •

edited

Loading

robertKozik commented Jul 27, 2023 •

edited

Loading

ishpaul777 commented Jul 27, 2023 •

edited

Loading