Disabling spell check on multiple pages by chiragxarora · Pull Request #23447 · Expensify/App

chiragxarora · 2023-07-23T20:18:56Z

Details

Pronouns input and multiple others show spelling error by red underline

Fixed Issues

$ #23303
PROPOSAL: #23303 (comment)

Tests

open the app
go to settings > profile > pronouns
select fae/faer and go back
open the pronouns page again and see no red underline
go to profile > display name and enter ksnkdnsd for first name and last name
observe no red underline
do the same for legal name
go to FAB > new chat and enter ksnkdnsd
o to FAB > new group and enter ksnkdnsd
request money > enter amount > now again enter ksnkdnsd
split bill > enter amount > now again enter ksnkdnsd
go to settings > workspaces > new workspace > settings > WS name, do the same
go to workspace > pick one > members > enter ksnkdnsd
go to workspace > members > invite > enter ksnkdnsd
click FAB > assign task > enter ksnkdnsd in title > complete other details > open the task again from report
go to settings > payments > debit card > enter ksnkdnsd in name & shipping address
go to settings > profile > personal details > home address > enter ksnkdnsd in address lines, state, city
click FAB > new room > enter ksnkdnsd in room name
observe that in all of the above, there is no red underline

Verify that no errors appear in the JS console

Offline tests

QA Steps

open the app
go to settings > profile > pronouns
select fae/faer and go back
open the pronouns page again and see no red underline
go to profile > display name and enter ksnkdnsd for first name and last name
observe no red underline
do the same for legal name
go to FAB > new chat and enter ksnkdnsd
o to FAB > new group and enter ksnkdnsd
request money > enter amount > now again enter ksnkdnsd
split bill > enter amount > now again enter ksnkdnsd
go to settings > workspaces > new workspace > settings > WS name, do the same
go to workspace > pick one > members > enter ksnkdnsd
go to workspace > members > invite > enter ksnkdnsd
click FAB > assign task > enter ksnkdnsd in title > complete other details > open the task again from report
go to settings > payments > debit card > enter ksnkdnsd in name & shipping address
go to settings > profile > personal details > home address > enter ksnkdnsd in address lines, state, city
click FAB > new room > enter ksnkdnsd in room name
observe that in all of the above, there is no red underline

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-25.at.11.24.38.PM.mov

Mobile Web - Chrome

256022293-2c15e912-fc18-40f8-beb6-3a386479f5e7.mov

Mobile Web - Safari

256022270-486e0bad-4d97-4355-92cc-21ed9c78f15b.mov

Desktop

Screen.Recording.2023-07-26.at.1.02.23.AM.mov

iOS

Screen.Recording.2023-07-26.at.12.53.14.AM.mov

Android

256022629-66dad2ba-2cac-44a3-b3d1-22da448a7f69.mov

melvin-bot · 2023-07-23T20:19:00Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-07-23T20:19:01Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chiragxarora · 2023-07-25T13:55:54Z

@parasharrajat can you review the PR?

parasharrajat

Replace shouldEnableSpellCheck with spellCheck everywhere https://reactnative.dev/docs/textinput#spellcheck-ios

chiragxarora · 2023-07-25T18:04:05Z

fixed, pls check now @parasharrajat

parasharrajat · 2023-07-25T18:30:13Z

We should allow it be checked here.

Suggested change

spellCheck={false}

parasharrajat · 2023-07-25T18:30:58Z

Can you please rename the component name in this file to be NewTaskDetailsPage?

parasharrajat · 2023-07-25T18:33:46Z

Same as previous.

Suggested change

spellCheck={false}

parasharrajat · 2023-07-25T18:34:22Z

Suggested change

spellCheck={false}

parasharrajat · 2023-07-25T18:35:28Z

Suggested change

spellCheck={false}

this is for workspaces's name, here too? I think for any kind of name spell check should be off, I can remove it if its supposed to, just asking again for confirmation

IMO, we should keep spell check on this. because this does not come under

Person Name.

Place name.

Entity Name.

Fixed terms.

Preselection list.

filter.

Search.

What do you say?

These can be proper words too so it is better so show spell errors on mistype.

I think in most cases they will have names of some organizations which usually aren't proper english words

Ok, then its fine. We can turn off spellcheck here.

as you mentioned disabled it.

parasharrajat · 2023-07-25T18:38:02Z

Bump @chiragxarora

parasharrajat · 2023-07-25T18:39:14Z

Attach following.

parasharrajat · 2023-07-25T19:10:00Z

I am waiting on your updates. Please let me know when done.

chiragxarora · 2023-07-25T19:25:28Z

done @parasharrajat , uploading attachments

parasharrajat · 2023-07-25T19:37:19Z

@chiragxarora Can you please merge main?

chiragxarora · 2023-07-25T19:38:45Z

done

chiragxarora · 2023-07-25T19:47:34Z

Screen.Recording.2023-07-26.at.1.15.40.AM.mov

I'm unable to test for msafari, its not letting me sign in, was facing this error on web browser too, its throwing 429 error "too many requests"
@parasharrajat can you try this?

parasharrajat · 2023-07-25T19:57:02Z

#23447 (comment)

You should be after merging main. That's why I asked. Restart all servers and test on the latest commit of this branch.

parasharrajat · 2023-07-25T19:57:15Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-07-26.at.1.25.16.AM.mov

🔲 iOS / Safari

Screen.Recording.2023-07-26.at.1.23.33.AM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-07-26.at.1.19.52.AM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-07-26.at.1.18.25.AM.mov

🔲 Android / Chrome

Screen.Recording.2023-07-26.at.1.24.25.AM.mov

🔲 Android / native

Screen.Recording.2023-07-26.at.1.28.37.AM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2023-07-26T15:22:10Z

@chiragxarora Please merge main. Bump @grgia for review.

chiragxarora · 2023-07-26T17:05:17Z

merge conflicts were too complex(for me I guess), I've merged main and reapplied the changes, you can have a look @parasharrajat

grgia · 2023-07-28T15:42:58Z

@chiragxarora sorry, there's one more conflicts

chiragxarora · 2023-07-28T16:48:27Z

conflicts resolved @grgia , pls have a look again, thankyou

chiragxarora · 2023-07-31T13:54:00Z

bump: @grgia

OSBotify · 2023-08-02T11:10:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-03T17:42:25Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:30:45Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:57:58Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:47:06Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

chiragxarora requested a review from a team as a code owner July 23, 2023 20:18

melvin-bot bot removed the request for review from a team July 23, 2023 20:18

melvin-bot bot requested a review from parasharrajat July 23, 2023 20:19

chiragxarora mentioned this pull request Jul 23, 2023

[HOLD for payment 2023-08-14] [$250] Chat - Red underline on some pronouns #23303

Closed

6 tasks

parasharrajat suggested changes Jul 25, 2023

View reviewed changes

Comment thread src/components/TextInput/baseTextInputPropTypes.js Outdated

Comment thread src/components/TextInput/baseTextInputPropTypes.js Outdated

parasharrajat suggested changes Jul 25, 2023

View reviewed changes

parasharrajat reviewed Jul 25, 2023

View reviewed changes

Comment thread src/pages/tasks/NewTaskDetailsPage.js Outdated

chiragxarora requested a review from parasharrajat July 25, 2023 19:50

parasharrajat approved these changes Jul 25, 2023

View reviewed changes

melvin-bot bot requested a review from grgia July 25, 2023 20:01

chiragxarora closed this Jul 26, 2023

chiragxarora force-pushed the fix/23303 branch 2 times, most recently from 39a4385 to 75e737b Compare July 26, 2023 16:37

reapplying changes

aeb76f2

chiragxarora reopened this Jul 26, 2023

parasharrajat approved these changes Jul 26, 2023

View reviewed changes

Merge branch 'main' into fix/23303

74c82ea

grgia approved these changes Aug 2, 2023

View reviewed changes

grgia merged commit d228257 into Expensify:main Aug 2, 2023

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

Conversation

chiragxarora commented Jul 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 23, 2023

Uh oh!

melvin-bot bot commented Jul 23, 2023

Uh oh!

chiragxarora commented Jul 25, 2023

Uh oh!

parasharrajat left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chiragxarora commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Jul 25, 2023

Uh oh!

parasharrajat commented Jul 25, 2023

Uh oh!

parasharrajat commented Jul 25, 2023

Uh oh!

Uh oh!

chiragxarora commented Jul 25, 2023

Uh oh!

parasharrajat commented Jul 25, 2023

Uh oh!

chiragxarora commented Jul 25, 2023

Uh oh!

chiragxarora commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

chiragxarora commented Jul 23, 2023 •

edited

Loading

parasharrajat left a comment •

edited

Loading

chiragxarora commented Jul 25, 2023 •

edited

Loading

chiragxarora commented Jul 25, 2023 •

edited

Loading

parasharrajat commented Jul 25, 2023 •

edited

Loading

parasharrajat commented Jul 25, 2023 •

edited

Loading