Add an option for distance requests by neil-marcellini · Pull Request #23048 · Expensify/App

neil-marcellini · 2023-07-18T00:43:57Z

Details

Simple first step of adding a distance request option and generating a transaction for the IOU request optimistically, as per the design doc.

Fixed Issues

$ #22698
PROPOSAL: N/A

Tests

Sign in with an account on the expensifail.com domain
Click the green plus > Request Money
Verify that you see a Distance icon and text
Select it
Verify that you see "Distance request" and a transactionID

Verify that no errors appear in the JS console

Offline tests

Sign in with an account on the expensifail.com domain
Go offline
Run steps 2-5 above

QA Steps

Run tests above

Sign in with an account not on the expensifail.com domain
Click the green plus > Request Money
Verify that you do not see a Distance icon and text

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

I only tested on web because the code is platform independent.

Web

Screen.Recording.2023-07-19.at.6.29.41.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-07-20T01:43:56Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2023-07-20T01:51:35Z

This is ready for review, but I'll hold it on Andrew's PR so that we don't make his PR larger than it needs to be.

neil-marcellini · 2023-08-04T03:33:45Z

@AndrewGable @arosiclair @eVoloshchak ready for review!

allroundexperts · 2023-08-07T18:48:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-08.at.7.18.38.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-08.at.7.25.59.AM.mov

Mobile Web - Safari

Screen.Recording.2023-08-08.at.7.23.49.AM.mov

Desktop

Screen.Recording.2023-08-08.at.7.21.51.AM.mov

iOS

Screen.Recording.2023-08-08.at.7.39.22.AM.mov

Android

Screen.Recording.2023-08-08.at.8.06.29.AM.mov

allroundexperts · 2023-08-08T02:11:54Z

+function createEmptyTransaction() {
+    const transactionID = NumberUtils.rand64();
+    Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {});
+    Onyx.merge(ONYXKEYS.IOU, {transactionID});


This will not reset the iou key rather just add transactionID as a key. Are you sure this is what we want to do here?

Yeah I think other flows should handle resetting the iou key. It should be in a good state.

allroundexperts · 2023-08-08T02:16:11Z

@neil-marcellini We might want to add the added route in .well-known/apple-app-site-association & android/app/src/main/AndroidManifest.xml.

allroundexperts

Changes are testing well. Two small comments but feel free to merge if this is urgent.

melvin-bot · 2023-08-08T03:11:32Z

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2023-08-08T18:57:41Z

@neil-marcellini We might want to add the added route in .well-known/apple-app-site-association & android/app/src/main/AndroidManifest.xml.

I'll do that in this PR as a quick follow up.

OSBotify · 2023-08-08T19:02:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-09T09:11:17Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:50:00Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-10T20:08:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fedirjh · 2023-09-08T18:07:36Z

Coming from #25661, We should've disabled the drag & drop for the distance page, it was disabled only for the manual tab

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 83 in a2096c8

neil-marcellini added 5 commits July 17, 2023 16:11

Add beta check for distance requests

d09e353

Tab for distance requests if on beta

6c0487b

Extract tab constants

57ef1de

WIP add distance request tab

980ed82

Add dummy DistanceRequest component

3538981

neil-marcellini self-assigned this Jul 18, 2023

neil-marcellini added 12 commits July 17, 2023 17:51

Fix simple distance request component

8f3c610

Add car Expensicon

f32c077

Merge branch 'andrew-scan' into neil-distance-option

65d12b5

Translate distance tab selector

7810fb0

Fix tab contents

623be15

accessibility label is required

8045c1a

Create empty transaction linked to iou

f7326a4

Merge branch 'andrew-scan' into neil-distance-option

2ff0b3d

Make tab title required for accessibility

8f75d97

Remove unused props for now

a1421ba

Clean up and prettify

f68f998

Use selector per checklist

f72a4af

neil-marcellini marked this pull request as ready for review July 20, 2023 01:43

neil-marcellini requested a review from a team as a code owner July 20, 2023 01:43

melvin-bot bot removed the request for review from a team July 20, 2023 01:43

melvin-bot bot requested a review from eVoloshchak July 20, 2023 01:43

neil-marcellini requested review from AndrewGable and arosiclair July 20, 2023 01:44

neil-marcellini changed the title ~~Add an option for distance requests~~ [HOLD 23046] Add an option for distance requests Jul 20, 2023

arosiclair reviewed Jul 20, 2023

View reviewed changes

Comment thread src/pages/iou/MoneyRequestSelectorPage.js Outdated

eVoloshchak reviewed Jul 20, 2023

View reviewed changes

Comment thread src/libs/Permissions.js

Destructure props

26abf92

Fix access on undefined in selector

ca0d60d

neil-marcellini requested a review from arosiclair August 4, 2023 03:32

AndrewGable previously approved these changes Aug 4, 2023

View reviewed changes

Comment thread src/pages/iou/MoneyRequestSelectorPage.js

Fix routes

c861785

neil-marcellini dismissed AndrewGable’s stale review via c861785 August 5, 2023 00:24

Show tabs if you can use scan or distance

5da8d78

neil-marcellini requested a review from AndrewGable August 5, 2023 00:28

arosiclair approved these changes Aug 7, 2023

View reviewed changes

AndrewGable requested review from allroundexperts and removed request for eVoloshchak August 7, 2023 15:18

allroundexperts reviewed Aug 8, 2023

View reviewed changes

allroundexperts approved these changes Aug 8, 2023

View reviewed changes

melvin-bot bot requested a review from jasperhuangg August 8, 2023 03:11

neil-marcellini mentioned this pull request Aug 8, 2023

Add waypoints list and add stop button #23698

Merged

59 tasks

neil-marcellini merged commit fb53a49 into main Aug 8, 2023

neil-marcellini deleted the neil-distance-option branch August 8, 2023 18:58

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

amyevans mentioned this pull request Aug 9, 2023

Request money - When switching between manual input and distance, the scan option flashes #24338

Closed

6 tasks

melvin-bot bot mentioned this pull request Aug 10, 2023

NEWDOT PAYMENT DUE [HOLD for payment 2023-08-17] Add an option for distance requests #22698

Closed

fedirjh mentioned this pull request Sep 8, 2023

[HOLD for payment 2023-09-07] [$1000] Web - Money Request - Dev - On money request page distance page user is able drag & drop file #25661

Closed

6 tasks

Conversation

neil-marcellini commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 20, 2023

Uh oh!

neil-marcellini commented Jul 20, 2023

Uh oh!

Uh oh!

Uh oh!

neil-marcellini commented Aug 4, 2023

Uh oh!

Uh oh!

allroundexperts commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts commented Aug 8, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Aug 8, 2023

Uh oh!

neil-marcellini commented Aug 8, 2023

Uh oh!

OSBotify commented Aug 8, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 10, 2023

Uh oh!

fedirjh commented Sep 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

neil-marcellini commented Jul 18, 2023 •

edited

Loading

allroundexperts commented Aug 7, 2023 •

edited

Loading