Remove passwordless beta logic by NikkiWines · Pull Request #22461 · Expensify/App

NikkiWines · 2023-07-08T01:53:48Z

Details

Removes a lot of password-based code and passwordless beta logic that's no longer necessary now we've flipped everyone over

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/249398

PROPOSAL:

Tests

Create a new account and validate it
Log out of the account and log back in
Navigate to Settings > Profile > Contact Method > New Contact Method
Add a new contact method and validate it
Navigate to Settings > Payments > Add Payment Method > Debit Card
Add a new debit card and confirm you're not asked for a password

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Create a new account and validate it
Log out of the account and log back in
Navigate to Settings > Profile > Contact Method > New Contact Method
Add a new contact method and validate it
Navigate to Settings > Payments > Add Payment Method > Debit Card
Add a new debit card and confirm you're not asked for a password

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

newuser-contactmethod-web.mov

debitcard-web.mov

Mobile Web - Chrome

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-17.at.18.16.21.mp4

Desktop

desktop.mov

iOS

ios.mp4

Android

Screen.Recording.2023-07-18.at.10.55.31.mov

…uire passwords

remove password validation regex

…swordless-dependencies

NikkiWines · 2023-07-15T01:33:32Z

This should be good for review! Gonna add screenshots first thing Monday 🙇

melvin-bot · 2023-07-15T01:34:10Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…swordless-dependencies

NikkiWines · 2023-07-18T01:32:31Z

Did some testing today, will follow up with android tomorrow 🙇

johnmlee101

updatePasswordAndSignin should be removed as well from Session/index.js, right?

NikkiWines · 2023-07-18T21:38:59Z

updatePasswordAndSignin should be removed as well from Session/index.js, right?

Oops yes, and now I have conflicts 😢

…swordless-dependencies

NikkiWines · 2023-07-18T22:13:24Z

@johnmlee101 updated!

NikkiWines · 2023-07-18T22:13:48Z

Android mWeb is up but my android sim won't load newDot 😭

…swordless-dependencies

NikkiWines · 2023-07-20T18:31:51Z

@srikarparsi @johnmlee101 friendly bump here just cause this one gets conflicts every day 😭

johnmlee101 · 2023-07-20T18:34:50Z

@srikarparsi will you be able to work on the checklist?

johnmlee101 · 2023-07-20T18:41:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-21.at.4.29.52.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-21.at.4.31.00.PM.mov

Mobile Web - Safari

Screen.Recording.2023-07-21.at.4.33.47.PM.mov

Desktop

DesktopRecording.mov

iOS

Screen.Recording.2023-07-21.at.4.52.02.PM.mov

Android

Screen.Recording.2023-07-21.at.4.57.39.PM.mov

srikarparsi · 2023-07-20T21:13:04Z

Hey @johnmlee101! Yup, I can test on the other platforms and will add screenshots into your checklist

srikarparsi · 2023-07-20T21:47:21Z

@NikkiWines Should I be on a specific branch of web when testing this PR. I'm getting the following error:

These are the logs:

2023-07-20T21:31:55.536618+00:00 expensidev2004 php-fpm: tAivwu /api.php srikar3@gmail.com !ecash1.3.43-4! ?api? [info] [trace] StackTrace start
2023-07-20T21:31:55.536621+00:00 expensidev2004 php-fpm: tAivwu /api.php srikar3@gmail.com !ecash1.3.43-4! ?api? [info] [trace] 0/1. file '/vagrant/Web-Expensify/lib/UserAPI.php' function 'createFund' line '4165'
2023-07-20T21:31:55.536624+00:00 expensidev2004 php-fpm: tAivwu /api.php srikar3@gmail.com !ecash1.3.43-4! ?api? [info] [trace] 1/1. file '/vagrant/Web-Expensify/api.php' function 'addPaymentCard' line '2507'
2023-07-20T21:31:55.536626+00:00 expensidev2004 php-fpm: tAivwu /api.php srikar3@gmail.com !ecash1.3.43-4! ?api? [info] [trace] StackTrace end
2023-07-20T21:31:55.536646+00:00 expensidev2004 php-fpm: tAivwu /api.php srikar3@gmail.com !ecash1.3.43-4! ?api? [hmmm] An error occurred when adding payment card ExpException - 91b8a833cf82c94e68eabace586d24aa ~~ exceptionMessage: 'Auth CreateFund returned an error' exceptionFile: '/vagrant/Web-Expensify/lib/Auth.php' exceptionLine: '1541' exceptionCode: '402'

I also logged the error code and it's 402 which doesn't make sense based on the header of this file since I also tried an actual debit card and it didn't work either.

johnmlee101 · 2023-07-21T16:41:43Z

Do you have the most up-to-date version of auth?

NikkiWines · 2023-07-21T16:46:30Z

Hmm, @srikarparsi this isn't dependent on any web PRs so you should be fine. FWIW when I test adding a debit card in dev I always use 4242424242424242 because that's one of stripes testing card numbers (here).

srikarparsi · 2023-07-21T20:10:23Z

I'll try that, I do have the most up to date version of auth and also did a buildAll and restarted auth in the vm.

srikarparsi

Added in the recordings and completed the checklist.

johnmlee101 · 2023-07-21T21:08:19Z

Thank you so much for finishing testing! Excited that this is out!

OSBotify · 2023-07-21T21:09:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-25T01:44:00Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

techievivek · 2023-07-25T09:41:18Z

        useExpensifyLogin: parameters.useExpensifyLogin,
        partnerName: parameters.partnerName,
-        partnerPassword: parameters.partnerPassword,
+        partnerPassword: parameters.partnerPassyword,


We had a typo here 😢

P.s.: Fixing this here #23532

Ah oops, nice catch - thank you

mountiny · 2023-07-26T13:48:48Z

Verified the contact method part works

OSBotify · 2023-07-26T15:53:31Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

NikkiWines · 2023-07-26T17:40:16Z

+        // A fresh session will not have credentials.login available.
+        if (!login) {


Changing this (and the other if in src/pages/ValidateLoginPage/index.website.js) resulted in this regression where users couldn't log in using magic links.

I should've added QA steps for testing logging in with magic links for this PR, my bad 😞

NikkiWines added 3 commits July 7, 2023 18:44

remove canUsePasswordless

0ed9b58

remove password form and resendvalidatecode form from sign in

12f524b

remove forms

f43cc2e

NikkiWines self-assigned this Jul 8, 2023

NikkiWines added 9 commits July 7, 2023 19:01

remove change password view from settings

81d8d05

remove password popover

e98b651

remove updatePassword and remove password from updateContactMethod

a2918cf

update basepayment page and makeDefaultPaymentMethod to no longer req…

bfaf167

…uire passwords

remove resetPassword and resendResetPassword

97480a9

remove password validation regex

remove password from signIn

f40958c

comment updates

5cb825f

prettier style

05e4a51

Merge branch 'main' of github.com:Expensify/App into nikki-remove-pas…

ab55c1c

…swordless-dependencies

NikkiWines requested a review from johnmlee101 July 15, 2023 00:31

NikkiWines added 3 commits July 14, 2023 18:21

Merge branch 'main' of github.com:Expensify/App into nikki-remove-pas…

caf8267

…swordless-dependencies

prettier style

fd6f4c6

remove unused import

5f457ce

NikkiWines marked this pull request as ready for review July 15, 2023 01:33

NikkiWines requested a review from a team as a code owner July 15, 2023 01:33

melvin-bot bot requested review from srikarparsi and removed request for a team July 15, 2023 01:34

NikkiWines added 2 commits July 17, 2023 17:09

Merge branch 'main' of github.com:Expensify/App into nikki-remove-pas…

00d1509

…swordless-dependencies

addDebitCard merge fix

5b53848

johnmlee101 suggested changes Jul 18, 2023

View reviewed changes

NikkiWines added 2 commits July 18, 2023 15:11

Merge branch 'main' of github.com:Expensify/App into nikki-remove-pas…

9cb8b9e

…swordless-dependencies

remove updatepasswordandsignin

914d9e7

NikkiWines added 2 commits July 19, 2023 14:25

Merge branch 'main' of github.com:Expensify/App into nikki-remove-pas…

f1aa14c

…swordless-dependencies

Merge branch 'main' of github.com:Expensify/App into nikki-remove-pas…

972d0ad

…swordless-dependencies

johnmlee101 approved these changes Jul 20, 2023

View reviewed changes

srikarparsi approved these changes Jul 21, 2023

View reviewed changes

srikarparsi merged commit c9e7f19 into main Jul 21, 2023

srikarparsi deleted the nikki-remove-passwordless-dependencies branch July 21, 2023 21:04

johnmlee101 mentioned this pull request Jul 24, 2023

Migrate BasePasswordPopover.js to function component #22891

Merged

58 tasks

StevenKKC mentioned this pull request Jul 24, 2023

[HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] [$1000] Dev: Web - User is unable to authenticate with magic link #23504

Closed

6 tasks

NikkiWines mentioned this pull request Jul 24, 2023

[CP staging] Fix email delivery failed login view #23512

Merged

58 tasks

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

techievivek reviewed Jul 25, 2023

View reviewed changes

NikkiWines commented Jul 26, 2023

View reviewed changes

tgolen mentioned this pull request Aug 1, 2023

[HOLD for payment 2023-08-17] [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Payments - App crashed when try to set default if added BA #24005

Closed

6 tasks

Beamanator mentioned this pull request Aug 1, 2023

refactored BasePaymentsPage to function based component #22412

Merged

58 tasks

tgolen mentioned this pull request Aug 1, 2023

[CP Staging] Remove reference to missing method #24010

Merged

58 tasks

		// A fresh session will not have credentials.login available.
		if (!login) {

Conversation

NikkiWines commented Jul 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

NikkiWines commented Jul 15, 2023

Uh oh!

melvin-bot bot commented Jul 15, 2023

Uh oh!

NikkiWines commented Jul 18, 2023

Uh oh!

johnmlee101 left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines commented Jul 18, 2023

Uh oh!

NikkiWines commented Jul 18, 2023

Uh oh!

NikkiWines commented Jul 18, 2023

Uh oh!

NikkiWines commented Jul 20, 2023

Uh oh!

johnmlee101 commented Jul 20, 2023

Uh oh!

johnmlee101 commented Jul 20, 2023 • edited by srikarparsi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

srikarparsi commented Jul 20, 2023

Uh oh!

srikarparsi commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnmlee101 commented Jul 21, 2023

Uh oh!

NikkiWines commented Jul 21, 2023

Uh oh!

srikarparsi commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srikarparsi left a comment

Choose a reason for hiding this comment

Uh oh!

johnmlee101 commented Jul 21, 2023

Uh oh!

OSBotify commented Jul 21, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

techievivek Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikkiWines Jul 25, 2023

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jul 26, 2023

Uh oh!

OSBotify commented Jul 26, 2023

Uh oh!

NikkiWines Jul 26, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NikkiWines commented Jul 8, 2023 •

edited

Loading

johnmlee101 commented Jul 20, 2023 •

edited by srikarparsi

Loading

srikarparsi commented Jul 20, 2023 •

edited

Loading

srikarparsi commented Jul 21, 2023 •

edited

Loading

techievivek Jul 25, 2023 •

edited

Loading