Fix invited members does not reflect in offline mode by rezkiy37 · Pull Request #22410 · Expensify/App

rezkiy37 · 2023-07-07T12:41:56Z

Details

Actually, the changes improve how the app handles the inviting members to a workspace during the offline mode. The app previews new members like a pending state. It follows Optimistic With Feedback Pattern B.
Also, once our users back online, the app sends a request to add the new members. A response includes new members with own ids. It is important to clear local created members (local ids) and replace them with those members come from the backend.

Fixed Issues

$ #21891
PROPOSAL: #21891 (comment)

Tests

Open the app.
Click on "Settings" (your user avatar).
Click on "Workspaces".
Click on any existed workspace/Click on "New workspace" and create a new one, if you do not have already one.
Click on "Members".
Click on "Invite".
Select any amount of new members.
Click on "Next".
Click on "Invite".
Verify that all invited users are being included in workspace members.

Verify that no errors appear in the JS console

Offline tests

Open the app.
Click on "Settings" (your user avatar).
Click on "Workspaces".
Click on any existed workspace/Click on "New workspace" and create a new one, if you do not have already one.
Click on "Members".
Open the "Network" tap of DevTools and select the offline mode.
Click on "Invite".
Select any amount of new members.
Click on "Next".
Click on "Invite".
Verify that all invited users are being included in workspace members and has a pending state (translucent).
Disable the offline mode.
Verify that all invited users are being included in workspace members.

QA Steps

Same as "Tests" or "Offline tests".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

MacOS.Chrome.Offline.mp4

MacOS.Chrome.Online.mp4

MacOS.Safari.Offline.mp4

MacOS.Safari.Online.mp4

Mobile Web - Chrome

IOS.Chrome.Offline.mp4

IOS.Chrome.Online.mp4

Mobile Web - Safari

IOS.Safari.Offline.mp4

IOS.Safari.Online.mp4

Desktop

Desktop.Offline.mp4

Desktop.Online.mp4

iOS

IOS.Online.mp4

Android

Android.Offline.mp4

Android.Online.mp4

…/21891-invited-users-offline

melvin-bot · 2023-07-14T13:00:25Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

0xmiroslav · 2023-07-18T19:20:13Z

@rezkiy37 please pull main and fix lint. personalDetails is replaced with allPersonalDetails in Policy.js

0xmiroslav · 2023-07-18T20:12:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop.mov

iOS

Android

…/21891-invited-users-offline

rezkiy37 · 2023-07-19T09:04:52Z

@rezkiy37 please pull main and fix lint. personalDetails is replaced with allPersonalDetails in Policy.js

@0xmiroslav, thank you, done!

0xmiroslav

LGTM!

0xmiroslav · 2023-07-20T03:14:54Z

It seems conflict came from #22904

madmax330 · 2023-07-21T08:57:57Z

@0xmiroslav can you fix the conflict?

0xmiroslav · 2023-07-21T09:12:06Z

Oh, it's @rezkiy37's PR. I don't have write permission.

rezkiy37 · 2023-07-24T09:10:30Z

@madmax330, I've fixed conflicts and applied your suggestions. Thank you!

rezkiy37 · 2023-07-25T15:08:52Z

@madmax330, just a friendly reminder 🙂

0xmiroslav · 2023-07-25T15:11:02Z

@rezkiy37 just to confirm that you fixed conflict by full reverting #22904 right?

rezkiy37 · 2023-07-25T15:42:53Z

@rezkiy37 just to confirm that you fixed conflict by full reverting #22904 right?

I haven't reverted these changes #22904. This is a merge commit - 157de09.

rezkiy37 · 2023-07-25T15:46:45Z

I see they removed:

const logins = _.map(_.keys(invitedEmailsToAccountIDs), (memberLogin) => OptionsListUtils.addSMSDomainIfPhoneNumber(memberLogin));

However, I need this data and I have it.

madmax330 · 2023-07-26T06:55:46Z

@0xmiroslav can you please re-review?

…/21891-invited-users-offline

rezkiy37 · 2023-07-26T09:30:21Z

@0xmiroslav, ready for re-review 🙂

rezkiy37 · 2023-07-28T09:06:17Z

@0xmiroslav, just a friendly reminder 🙂

madmax330 · 2023-08-01T11:10:16Z

Bump @0xmiroslav

rushatgabhane · 2023-08-03T21:35:52Z

I can review this. (saw this comment on slack)

situchan

Sorry I was reviewing this already based on https://expensify.slack.com/archives/C02NK2DQWUX/p1691056044424399?thread_ts=1691055547.528309&cid=C02NK2DQWUX.
It didn't get passed 1 day yet after I got suggested to review.

situchan · 2023-08-04T00:23:50Z

Console error: (this also happens on main so out of scope, seems regression from #23705)

situchan · 2023-08-04T00:26:42Z

Tried to invite both existing and non-existing users.
Confirmed optimistic accountID (non-existing user) is removed from both personalDetailsList and policyMembers_xxx upon api success.

Screen.Recording.2023-08-04.at.5.18.56.AM.mov

situchan · 2023-08-04T00:57:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-04.at.5.18.56.AM.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios1.mov

ios2.mov

Android

android.mov

situchan

from me

…/21891-invited-users-offline

OSBotify · 2023-08-07T18:26:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-09T09:12:02Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:50:45Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-10T20:09:11Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rezkiy37 added 11 commits July 4, 2023 18:03

draft generation of personal details

fd15ea9

filter optimistic and success data before add a new member

a1cc5da

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

f44c631

…/21891-invited-users-offline

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

06bcda0

…/21891-invited-users-offline

fix success data generation

22138cd

simplify personal details optimistic

0fbb45d

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

6747d05

…/21891-invited-users-offline

simplify

c983520

remove extra changes

a1fec4b

left comments

df45fc5

clarify condition

f704ce3

fabioh8010 reviewed Jul 14, 2023

View reviewed changes

Comment thread src/libs/actions/Policy.js Outdated

rezkiy37 marked this pull request as ready for review July 14, 2023 13:00

rezkiy37 requested a review from a team as a code owner July 14, 2023 13:00

melvin-bot bot requested review from 0xmiroslav and removed request for a team July 14, 2023 13:00

rezkiy37 mentioned this pull request Jul 14, 2023

[HOLD for payment 2023-08-17] [$1000] Web - invited members does not reflect in offline mode #21891

Closed

6 tasks

rezkiy37 added 2 commits July 19, 2023 11:03

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

f4ca9d3

…/21891-invited-users-offline

use renamed var

66611d2

0xmiroslav approved these changes Jul 19, 2023

View reviewed changes

melvin-bot bot requested a review from madmax330 July 19, 2023 09:06

madmax330 reviewed Jul 19, 2023

View reviewed changes

Comment thread src/libs/actions/Policy.js Outdated

Comment thread src/libs/actions/Policy.js Outdated

Comment thread src/libs/actions/Policy.js Outdated

0xmiroslav mentioned this pull request Jul 20, 2023

fix: optimistically add personal details #22904

Merged

58 tasks

0xmiroslav reviewed Jul 26, 2023

View reviewed changes

Comment thread src/libs/actions/Policy.js Outdated

rezkiy37 added 2 commits July 26, 2023 11:10

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

98e7b67

…/21891-invited-users-offline

remove duplicate

8dad144

rushatgabhane suggested changes Aug 3, 2023

View reviewed changes

Comment thread src/libs/actions/Policy.js Outdated

situchan reviewed Aug 3, 2023

View reviewed changes

situchan approved these changes Aug 4, 2023

View reviewed changes

melvin-bot bot requested a review from madmax330 August 4, 2023 00:59

rezkiy37 added 2 commits August 4, 2023 11:23

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

0a6ce4e

…/21891-invited-users-offline

rename

3b7448e

madmax330 approved these changes Aug 7, 2023

View reviewed changes

madmax330 merged commit ab4dc4b into Expensify:main Aug 7, 2023

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

Conversation

rezkiy37 commented Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot bot commented Jul 14, 2023

Uh oh!

0xmiroslav commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xmiroslav commented Jul 18, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

rezkiy37 commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xmiroslav commented Jul 20, 2023

Uh oh!

madmax330 commented Jul 21, 2023

Uh oh!

0xmiroslav commented Jul 21, 2023

Uh oh!

rezkiy37 commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rezkiy37 commented Jul 25, 2023

Uh oh!

0xmiroslav commented Jul 25, 2023

Uh oh!

rezkiy37 commented Jul 25, 2023

Uh oh!

rezkiy37 commented Jul 25, 2023

Uh oh!

madmax330 commented Jul 26, 2023

Uh oh!

Uh oh!

rezkiy37 commented Jul 26, 2023

Uh oh!

rezkiy37 commented Jul 28, 2023

Uh oh!

madmax330 commented Aug 1, 2023

Uh oh!

rushatgabhane commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

situchan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan commented Aug 4, 2023

Uh oh!

situchan commented Aug 4, 2023

Uh oh!

situchan commented Aug 4, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

rezkiy37 commented Jul 7, 2023 •

edited

Loading

0xmiroslav commented Jul 18, 2023 •

edited

Loading

rezkiy37 commented Jul 19, 2023 •

edited

Loading

rezkiy37 commented Jul 24, 2023 •

edited

Loading

rushatgabhane commented Aug 3, 2023 •

edited

Loading

situchan left a comment •

edited

Loading