Skip to content

Grab the users custom avatar or default avatar to display properly #20727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bondydaa wants to merge 1 commit into from
Closed

Grab the users custom avatar or default avatar to display properly #20727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libs/ReportUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,8 +883,9 @@ function getDisplayNameForParticipant(login, shouldUseShortForm = false) {
*/
function getDisplayNamesWithTooltips(participants, isMultipleParticipantReport) {
return _.map(participants, (participant) => {
const personalDetails = getPersonalDetailsForLogin(participant.login);
const displayName = getDisplayNameForParticipant(participant.login, isMultipleParticipantReport);
const avatar = UserUtils.getDefaultAvatar(participant.login);
const avatar = UserUtils.getAvatar(personalDetails.avatar, participant.login);

@fedirjh fedirjh Jun 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const avatar = UserUtils.getAvatar(personalDetails.avatar, participant.login);
const {avatar} = getPersonalDetailsForLogin(participant.login);

@bondydaa I think we can simply get avatar from getPersonalDetailsForLogin

@Santhosh-Sellavel Santhosh-Sellavel Jun 13, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedirjh Please have a look again getPersonalDetailsForLogin doesn't always have an avatar, so it seems fine to me!

@fedirjh fedirjh Jun 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Santhosh-Sellavel It either return allPersonalDetails[login] which have avatar , or it construct a default object.

@Santhosh-Sellavel Santhosh-Sellavel Jun 13, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allPersonalDetails[login] might not have an avatar if not set

@fedirjh fedirjh Jun 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If avatar is not set it will fallback to default avatar. API always return avatar with personalDetails

Screenshot 2023-06-14 at 12 39 24 AM

@Santhosh-Sellavel Santhosh-Sellavel Jun 13, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then!

const accountID = participant.accountID;

let pronouns = participant.pronouns;
Expand Down