fix: update height for text container by dukenv0307 · Pull Request #19653 · Expensify/App

dukenv0307 · 2023-05-26T04:22:05Z

Details

We need to make sure the dash is included in the TextInput height so that when the TextInput is fully visible, the dash will also be visible.

Fixed Issues

$ #19387
PROPOSAL: #19387 (comment)

Tests

Go to settings > security > Two factor authentication
Click on copy codes and the next button
Check the authenticator field
Verify that authenticator field with dashes (___) should be fully visible

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to settings > security > Two factor authentication
Click on copy codes and the next button
Check the authenticator field
Verify that authenticator field with dashes (___) should be fully visible

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

348465459_6234288053355215_7671907135518787479_n.mp4

Mobile Web - Safari

Screen.Recording.2023-05-26.at.10.59.32.mov

Desktop

iOS

Uploading Screen-Recording-2023-05-26-at-10.55.57.mp4…

Android

Screen.Recording.2023-05-26.at.11.34.14.mov

melvin-bot · 2023-05-26T04:22:11Z

@amyevans @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-05-27T14:37:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-30.at.21.23.08.mov

Mobile Web - Chrome

WhatsApp.Video.2023-05-30.at.21.28.57.mp4

Mobile Web - Safari

Screen.Recording.2023-05-30.at.21.24.26.mov

Desktop

iOS

Screen.Recording.2023-05-30.at.21.20.33.mov

Android

WhatsApp.Video.2023-05-30.at.21.28.55.mp4

rushatgabhane · 2023-05-27T14:42:15Z

+                        <View
+                            style={[
+                                styles.textInputContainer,
+                                {height: styles.magicCodeInputContainer.minHeight - styles.textInputContainer.borderBottomWidth},


@dukenv0307 inline styles are not allowed. Could you please create a util function for it.
Thanks!

App/contributingGuides/STYLING.md

Line 3 in 12d2f3c

## Where to Define Styles

@rushatgabhane Because this style only applies to a single-use component. So I think we should define it in component as the guideline

## When to Create a New Style If we need some minimal set of styling rules applied to a single-use component then it's almost always better to use an array of helper styles rather than create an entirely new style if it will only be used once. Resist the urge to create a new style for every new element added to a screen. There is a very good chance the style we are adding is a "single-use" style. // Bad - Since we only use this style once in this component const TextWithPadding = props => ( <Text style={styles.textWithPadding}> {props.children} </Text> ); // Good const TextWithPadding = props => ( <Text style={[ styles.p5, styles.noWrap, ]} > {props.children} </Text> );

@dukenv0307 good point! But it only applies when we're creating a custom style using the existing styles, and no math is involved.

But I'm suggesting to create a function that returns a style in StyleUtils file
Because I don't think we do that anywhere in the code {height: x}

@rushatgabhane Thanks, Just updated

rushatgabhane

@amyevans LGTM!

amyevans

Code looks good, test/QA steps look good, tests well 🚀

OSBotify · 2023-05-30T16:40:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-31T17:21:50Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

strepanier03 · 2023-05-31T20:30:39Z

QA Steps

Go to settings > security > Two factor authentication
Click on copy codes and the next button
Check the authenticator field
Verify that authenticator field with dashes (___) should be fully visible
Verify that no errors appear in the JS console

Devices:

Web - staging, -- Worked perfectly
iOS - Staging via Browserstack, -- Worked perfectly
Android - Staging via Pixel 6 Pro, -- Worked perfectly
mWeb - Staging Android / Chrome -- Worked perfectly
Desktop - staging, - Worked perfectly

OSBotify · 2023-06-01T03:04:20Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.21-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: update height for text container

d2ac397

dukenv0307 requested a review from a team as a code owner May 26, 2023 04:22

melvin-bot Bot requested review from amyevans and rushatgabhane and removed request for a team May 26, 2023 04:22

fix: lint

f190a8f

rushatgabhane reviewed May 27, 2023

View reviewed changes

dukenv0307 added 3 commits May 30, 2023 11:12

fix: create new function to calculate the height

a2cc7fa

fix: merge main

a12127e

fix: lint

a4f6f2a

rushatgabhane approved these changes May 30, 2023

View reviewed changes

amyevans approved these changes May 30, 2023

View reviewed changes

amyevans merged commit a98f3bc into Expensify:main May 30, 2023

OSBotify mentioned this pull request May 31, 2023

Deploy Checklist: New Expensify 2023-05-31 #19896

Closed

37 tasks

melvin-bot Bot mentioned this pull request Jun 1, 2023

[HOLD for payment 2023-06-08] [$1000] Authenticator field is partially covered by keyboard on iOS #19387

Closed

6 tasks

DanutGavrus mentioned this pull request Jun 29, 2023

Magic code input doesn't work if the user changes the focus by clicking on the magic code field bottom border. #21870

Closed

6 tasks

kavimuru mentioned this pull request Jul 13, 2023

[WAITING ON SLACK] Bottom part of OTP input does not work #22807

Closed

6 tasks

Navigation Menu

fix: update height for text container - #19653

fix: update height for text container#19653
amyevans merged 5 commits into
Expensify:mainfrom
dukenv0307:fix/19387

dukenv0307 commented May 26, 2023 •

edited

Loading

Uh oh!

melvin-bot Bot commented May 26, 2023

Uh oh!

rushatgabhane commented May 27, 2023 •

edited

Loading

Uh oh!

rushatgabhane May 27, 2023

Uh oh!

dukenv0307 May 27, 2023

Uh oh!

rushatgabhane May 29, 2023 •

edited

Loading

Uh oh!

dukenv0307 May 30, 2023

Uh oh!

rushatgabhane May 30, 2023

Uh oh!

rushatgabhane left a comment

Uh oh!

amyevans left a comment

Uh oh!

OSBotify commented May 30, 2023

Uh oh!

OSBotify commented May 31, 2023

Uh oh!

strepanier03 commented May 31, 2023 •

edited

Loading

Uh oh!

OSBotify commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dukenv0307 commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 26, 2023

Uh oh!

rushatgabhane commented May 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane May 27, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 May 27, 2023

Choose a reason for hiding this comment

Uh oh!

rushatgabhane May 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 May 30, 2023

Choose a reason for hiding this comment

Uh oh!

rushatgabhane May 30, 2023

Choose a reason for hiding this comment

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 30, 2023

Uh oh!

OSBotify commented May 31, 2023

Uh oh!

strepanier03 commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dukenv0307 commented May 26, 2023 •

edited

Loading

rushatgabhane commented May 27, 2023 •

edited

Loading

rushatgabhane May 29, 2023 •

edited

Loading

strepanier03 commented May 31, 2023 •

edited

Loading