Repository navigation
[No QA] Enable App CI for production PRs - #105942
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
jayeshmangwani
and removed request for
a team
November 4, 2026 18:04
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Beamanator
requested review from
blimpich
and removed request for
jayeshmangwani
November 4, 2026 21:57
Contributor
Author
blimpich
approved these changes
Nov 4, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Posted by Codex, an AI coding agent acting for @Beamanator.
Explanation of Change
Enable the same 24 currently active
pull_requestCI workflows for PRs targetingproductionthat #104370 enabled forstaging. Remove theproductionexclusion from 21 workflows and addproductionto the three explicit branch lists. Keep existing path filters and bot job guards. This does not add anypushtrigger toproduction.The human-authored staging smoke test passed all 24 workflows: #105931. Individual run links and scope limits are in #101609 (comment). The former standalone
.github/workflows/oxlint.ymlhas since been removed; Oxlint now runs through.github/workflows/lint.yml.Fixed Issues
$ #101609
PROPOSAL: #101609 (comment)
Tests
git diff --checkandnpm run lint-changedsuccessfully; lint reported no lintable changed files.npm run spell-changedsuccessfully; the script excludes top-level.githubfiles, so it checked zero files.AI Tests
./.github/scripts/verifyActions.shrebuilt 25 unrelated generated JavaScript bundles when using the main checkout'snode_modulesin this isolated clone, then reported a diff. Those generated outputs were discarded, leaving only the intended workflow YAML changes. CI'sValidate Github Actionsrun passed: https://github.com/Expensify/App/actions/runs/41883334423. Schema, actionlint, and immutable-action-reference checks also passed: https://github.com/Expensify/App/actions/runs/41883333627.On commit
a4baa1a3cfd27c02236931127b57496742494be0, 28 PR check jobs passed, including the performance comparison (https://github.com/Expensify/App/actions/runs/41883334384). The image bot job skipped. The separate independent-approval check failed because the PR has not yet been reviewed.Offline tests
Not applicable. This change only controls CI for PRs targeting
production; it does not affect application behavior.QA Steps
production, open a human-authored PR targetingproductionthat changes covered files and confirm the applicable workflows start and pass.productiondo not start thesepull_requestworkflows.PR Author Checklist
Fixed Issues.production.Screenshots/Videos
Not applicable. There are no UI changes.