Skip to content

[No QA] Enable App CI for production PRs - #105942

Merged
blimpich merged 1 commit into
mainfrom
codex/enable-production-pr-ci-20261104
Nov 5, 2026
Merged

blimpich merged 1 commit into
mainfrom
codex/enable-production-pr-ci-20261104

Conversation

@Beamanator

@Beamanator Beamanator commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Posted by Codex, an AI coding agent acting for @Beamanator.

Explanation of Change

Enable the same 24 currently active pull_request CI workflows for PRs targeting production that #104370 enabled for staging. Remove the production exclusion from 21 workflows and add production to the three explicit branch lists. Keep existing path filters and bot job guards. This does not add any push trigger to production.

The human-authored staging smoke test passed all 24 workflows: #105931. Individual run links and scope limits are in #101609 (comment). The former standalone .github/workflows/oxlint.yml has since been removed; Oxlint now runs through .github/workflows/lint.yml.

Fixed Issues

$ #101609
PROPOSAL: #101609 (comment)

Tests

  1. Parsed all 71 workflow YAML files with Ruby Psych.
  2. Checked formatting on all 24 changed workflow files with Oxfmt.
  3. Ran git diff --check and npm run lint-changed successfully; lint reported no lintable changed files.
  4. Ran npm run spell-changed successfully; the script excludes top-level .github files, so it checked zero files.
  5. Reviewed the staged diff against App coding standards; no findings. Verified the commit's GPG signature.
  • Verify that no errors appear in the JS console — not applicable; no application code changed.

AI Tests

./.github/scripts/verifyActions.sh rebuilt 25 unrelated generated JavaScript bundles when using the main checkout's node_modules in this isolated clone, then reported a diff. Those generated outputs were discarded, leaving only the intended workflow YAML changes. CI's Validate Github Actions run passed: https://github.com/Expensify/App/actions/runs/41883334423. Schema, actionlint, and immutable-action-reference checks also passed: https://github.com/Expensify/App/actions/runs/41883333627.

On commit a4baa1a3cfd27c02236931127b57496742494be0, 28 PR check jobs passed, including the performance comparison (https://github.com/Expensify/App/actions/runs/41883334384). The image bot job skipped. The separate independent-approval check failed because the PR has not yet been reviewed.

Offline tests

Not applicable. This change only controls CI for PRs targeting production; it does not affect application behavior.

QA Steps

  1. After these workflow changes reach production, open a human-authored PR targeting production that changes covered files and confirm the applicable workflows start and pass.
  2. Confirm an OSBotify conflict PR skips the computational jobs and that a human resolution push runs the applicable checks.
  3. Confirm direct pushes to production do not start these pull_request workflows.
  • Verify that no errors appear in the JS console — not applicable; no application code changed.

PR Author Checklist

  • I linked the issue and proposal in Fixed Issues.
  • I documented local checks, the validation limitation, and repeatable QA steps.
  • I kept the change limited to workflow branch filters and related comments.
  • Production PR smoke test — to be completed after these workflow changes reach production.
  • Platform, UI, offline, accessibility, and application unit tests — not applicable to workflow branch filters.

Screenshots/Videos

Not applicable. There are no UI changes.

@Beamanator
Beamanator requested a review from a team as a code owner November 4, 2026 18:04
@melvin-bot
melvin-bot Bot requested review from jayeshmangwani and removed request for a team November 4, 2026 18:04
@melvin-bot

melvin-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T18:16:41.930469Z a4baa1a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Beamanator

Copy link
Copy Markdown
Contributor Author

@blimpich kindly asking for your review since you helped review the staging version #104370 🙏

@blimpich
blimpich merged commit e0d6446 into main Nov 5, 2026
32 of 33 checks passed
@blimpich
blimpich deleted the codex/enable-production-pr-ci-20261104 branch November 5, 2026 00:10
@OSBotify

OSBotify commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants