Repository navigation
Conversation
Onyx.disconnect() is removed in favor of calling unsubscribe() directly on the Connection returned by connect()/connectWithoutView().
…ct-removal # Conflicts: # src/libs/actions/Link.ts # src/libs/migrations/ConvertGpsPointsTo2DArray.ts # tests/actions/IOUTest/HoldTest.ts
…ct-removal # Conflicts: # package-lock.json # package.json # src/setup/addUtilsToWindow.ts # tests/unit/DistanceRateTest.ts
…ct-removal # Conflicts: # package-lock.json # package.json
…ct-removal # Conflicts: # package-lock.json # package.json
…unsubscribe() Co-Authored-By: Fabio Henriques <fabioh8010@gmail.com>
Contributor
|
|
42 tasks done
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Based on #103351 - Onyx.disconnect changes
For testing react-native-onyx PR: Expensify/react-native-onyx#884
Only real change is pinning to onyx commit
cb8bdd5, the head of onyx#884, which sits 4 commits ahead of onyxmainand is therefore not published to npm.The pin alone would not run, so this branch also carries #103351:
Onyx.disconnect()was removed from Onyx in Expensify/react-native-onyx@513b3ef and the pinned commit no longer exports it, so without the rename all 646 call sites insrc/andtests/throw on first use.Fixed Issues
$
PROPOSAL:
Tests
Offline tests
Not run. The cache-miss diagnostic reads from storage, so it is worth watching for the two messages above while going offline, navigating around, and reconnecting.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Testing build for an unpublished Onyx commit, not intended to merge. Adhoc builds install dependencies from the npm registry, so they would not pick up this pin.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not tested.
Android: mWeb Chrome
Not tested.
iOS: Native
Not tested.
iOS: mWeb Safari
Not tested.
MacOS: Chrome / Safari
Not tested in a browser. Verified locally with
npm run typecheck,npm run lint-changed,npm run fmt,npm run spell-changedandnpm run react-compiler-compliance-check check-changed(all green), plus Jest on the suites covering the renamed call sites:SequentialQueueTest,MiddlewareTest,LinkTest,LinkOpenReportFromDeepLinkTest,DeepLinkHandlerTest,OnyxUpdateManagerTest,QueuedOnyxUpdatesTest,OnyxDerivedTest,OnyxDerivedRestoredValueTest,OnyxDerivedSelfHealTest(212 tests passed).