Thread parentReportActions into isOneTransactionThread > getDisplayedReportID - 2 by cretadn22 · Pull Request #105453 · Expensify/App

cretadn22 · 2026-10-30T04:35:13Z

Explanation of Change

Fixed Issues

$ #66419
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

On a workspace with a report holding one expense, open that expense's thread and hold it with a reason. The hold and reason actions appear
On a report with two expenses, hold one from its thread. The thread itself is announced.
In the report view, select both expenses and hold them in bulk. Both are held and each thread gets its hold action.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-10-30T04:35:24Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-30T04:35:28Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-30T14:54:24.089949Z	`3383908`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

codecov · 2026-10-30T04:39:00Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/Hold.ts	`90.00% <100.00%> (ø)`
src/pages/iou/DynamicHoldReasonPage.tsx	`0.00% <ø> (ø)`
src/pages/Search/SearchHoldReasonPage.tsx	`0.00% <0.00%> (ø)`
... and 13 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9063c16a72

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

situchan · 2026-10-30T05:06:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

test.mov

MelvinBot · 2026-10-30T14:41:27Z

Review

The change looks correct, and CI is green. The only failures are the checklist and independent-approval checks. I have one non-blocking suggestion and one optional cleanup.

1. Search single-hold path uses partial snapshot actions (non-blocking)

SearchHoldReasonPage.tsx:115 reads reportActions_<id> straight from the search snapshot. Before this PR, getDisplayedReportID fell back to the full Onyx collection here. A snapshot can hold only some of a report's IOU actions. When it does, the one-expense check runs on partial data. Your reply to Codex shows this has no visible effect today, because nothing that notifyNewAction scrolls is mounted. Still, the code now classifies the hold wrongly in that case.

getReportActionsFromSearchSnapshot(..., true) exists for exactly this whole-history check. It merges the snapshot over the live actions. You could subscribe to just the relevant report-action keys with a selector, as the page already does for relevantReports, and pass the merged result. Then the threaded value matches the old behavior. If you'd rather keep it as is, a short code comment on why partial data is acceptable here would help the next reader.

2. Bulk path still reads the IOU action from the global store (optional)

putTransactionsOnHold now receives reportActions. But Hold.ts:405 still finds childReportID with getIOUActionForReportID, which reads the global store. getIOUActionForTransactionID(Object.values(reportActions ?? {}), transactionID) would use the passed data. The page already does this at line 68. This is fine to leave for a later part of the refactor.

Checked and fine:

DynamicHoldReasonPage passes the actions of report.parentReportID. That is the same key getDisplayedReportID used to read, so behavior is unchanged.
In both Search paths, the actions belong to the held thread's parent (transaction.reportID or the bulk reportID). This also holds when putOnHold creates a new thread.
The new tests follow Given/When/Then. They rely on the afterEach jest.clearAllMocks(), so the toHaveBeenNthCalledWith assertions don't see calls from earlier tests.

MelvinBot · 2026-10-30T14:44:41Z

Regression check

I found no user-facing regressions. The PR only changes which report ID putOnHold passes to notifyNewAction. All the hold data (actions, violations, and totals) is built exactly as before.

Hold path	Behavior vs. `main`
Expense thread (`DynamicHoldReasonPage`)	Same. It passes `reportActions_<report.parentReportID>` from `useOnyx`, which is the key `getDisplayedReportID` read before.
Bulk hold in report view (`SearchHoldReasonPage` bulk route)	Same. It passes `reportActions_<reportID>` from `useOnyx`, which is the parent of every held thread.
Search list hold (`SearchHoldReasonPage.tsx:115`)	The announced ID can differ, but with no visible effect (see below).

Why the Search list difference has no visible effect

When the search snapshot holds only some of a report's expenses, the one-expense check can now announce the parent report instead of the thread. Neither subscriber that notifyNewAction could reach acts on this event from Search:

The chat/thread list returns early unless the Reports split navigator is on top or a report RHP route is active (useReportActionsNewActionLiveTail.ts:102). Neither is true on the Search page, even if that report is still mounted in another tab.
The expense report view ignores events without an ADD_COMMENT action (useMoneyRequestReportScroll.ts:232). putOnHold always sends undefined for the action.

Also unchanged: when the expense has no thread yet, putOnHold creates one, and getDisplayedReportID still returns that new thread's ID, as before. The data change doesn't affect that case.

I checked this by reading the code only. I didn't run the hold flows in the app.

chatgpt-codex-connector · 2026-10-30T14:54:22Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 3383908dce

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mollfpr

LGTM! Thanks!

github-actions · 2026-11-02T08:29:47Z

🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-11-02T08:33:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-11-02T08:35:03Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105453 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e0fddc42-f89e1f8-a02a25b2ef4857bcdbf865d328187eee84419a7a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e0fddc42-f89e1f8-b3153120339c6d47d6f6786ac86fa7ee9b0456a7/index.html

Web 🕸️
https://105453.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-11-02T18:53:31Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.5.28-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-11-02T18:56:17Z

No help site update needed. This PR is an internal refactor that removes an Onyx.connect() dependency by passing report actions into the hold flow, so how you hold an expense and what you see afterward stay the same.

view run

OSBotify · 2026-11-03T17:58:36Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.5.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-11-03T19:04:29Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Thread parentReportActions into getDisplayedReportID

9063c16

cretadn22 requested review from a team as code owners October 30, 2026 04:35

melvin-bot Bot assigned cretadn22 Oct 30, 2026

melvin-bot Bot requested review from situchan and removed request for a team October 30, 2026 04:35

melvin-bot Bot requested review from garrettmknight and removed request for a team October 30, 2026 04:35

Thread parentReportActions into getDisplayedReportID

3383908

chatgpt-codex-connector Bot reviewed Oct 30, 2026

View reviewed changes

Comment thread src/pages/Search/SearchHoldReasonPage.tsx Resolved

situchan approved these changes Oct 30, 2026

View reviewed changes

melvin-bot Bot requested a review from mollfpr October 30, 2026 14:49

mollfpr approved these changes Nov 2, 2026

View reviewed changes

mollfpr merged commit e0fddc4 into Expensify:main Nov 2, 2026
39 of 45 checks passed

OSBotify mentioned this pull request Nov 2, 2026

Deploy Checklist: New Expensify 2026-11-02 #105665

Closed

75 tasks done

melvin-bot Bot mentioned this pull request Nov 3, 2026

[Partial Payment] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_ACTIONS in src/libs/ReportUtils.ts #66419

Open

Conversation

cretadn22 commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 30, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

codecov Bot commented Oct 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

situchan commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Oct 30, 2026

Review

Uh oh!

MelvinBot commented Oct 30, 2026

Regression check

Uh oh!

chatgpt-codex-connector Bot commented Oct 30, 2026

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

MelvinBot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 3, 2026

Uh oh!

OSBotify commented Nov 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cretadn22 commented Oct 30, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 30, 2026 •

edited

Loading

codecov Bot commented Oct 30, 2026 •

edited by github-actions Bot

Loading

situchan commented Oct 30, 2026 •

edited

Loading