[Beamanator]

🤖 Posted by Codex, an AI coding agent acting for @Beamanator.

Explanation of Change

Uses the subtitle prop for the Vendors table empty state, so the translated string is rendered through the shared styled Text component instead of being passed as an unstyled custom React node.

Follow-up to the review discussion: #96143 (comment)

Fixed Issues

$ N/A — regression follow-up; no standalone issue was created.
PROPOSAL: N/A

Tests

1. Open a workspace with the Vendors page available and no imported vendors.
2. Verify the empty-state subtitle is centered and uses the normal supporting-text style.
3. Verify no errors appear in the JS console.

• Verify that no errors appear in the JS console

Offline tests

1. With cached workspace data, go offline and open the empty Vendors page.
2. Verify the same centered supporting-text subtitle is shown.
3. Reconnect and verify the empty-state styling remains correct.

QA Steps

Same as Tests.

• Verify that no errors appear in the JS console

AI Tests

• npm run lint-changed — passed.
• npm run react-compiler-compliance-check check-changed — passed.
• npm run spell-changed — passed.
• npm run typecheck — repository-wide dependency/type errors unrelated to this file; the changed file did not appear in the output.
• No focused existing Vendors-table test covers this prop wiring.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Verified.

Android: mWeb Chrome

Verified.

iOS: Native

Verified.

iOS: mWeb Safari

Verified.

MacOS: Chrome / Safari

Verified.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-29T22:09:44.083610Z	0cb9bbd	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[melvin-bot]

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../components/Tables/WorkspaceVendorsTable/index.tsx	0.00% <0.00%> (ø)
... and 11 files with indirect coverage changes

[JmillsExpensify]

No concerns from me, though does this PR need design review?

[Beamanator]

ya let's get design approval, i'll get screenshots soon of the design diff from this PR

[MelvinBot]

🤖 Web test steps verification results: ❌ fail

I couldn't reach the Vendors page, so none of the steps were tested. This is a test-environment blocker, not a bug found in this PR. The Vendors page only appears after a workspace connects an accounting integration. NetSuite needs a Control plan upgrade. QuickBooks Online "Connect" sent the browser to an OAuth page that doesn't resolve in the test environment, which ended the session.

Step	Status
Open a workspace with the Vendors page available and no imported vendors (empty state shown) Not reached. I created a workspace and turned on Accounting, but Vendors only shows after an accounting connection. NetSuite is paywalled on Collect, and QuickBooks Online "Connect" left the app for an OAuth domain that doesn't resolve here, which broke the session.	❌
Empty-state subtitle is centered with normal supporting-text style Not checked in the app. In the code, subtitle now goes through the shared EmptyStateComponent, the same path other empty states use for centered supporting text.	❌
No errors appear in the JS console Not checked. The Vendors page was never reached.	❌
Offline: with cached workspace data, open the empty Vendors page Not attempted. Blocked by step 1.	❌
Offline: same centered supporting-text subtitle is shown Not attempted. Blocked by step 1.	❌
Reconnect: empty-state styling remains correct Not attempted. Blocked by step 1.	❌

To test this on Web, Melvin needs a test account whose workspace already has an accounting connection, or permission to open /workspaces/<policyID>/vendors directly.

---

view run · view recording

[JmillsExpensify]

cc @Expensify/design

[shawnborton]

Let us know when the screenshots are ready.

[mollfpr]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

MacOS: Chrome / Safari

Before

After

[mollfpr]

LGTM!

@shawnborton I have attached the screenshot.

[dubielzyk-expensify]

That looks better to me 👍

[shawnborton]

Much better, thanks!

[github-actions]

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105425 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1b78dfc1-f89e1f8-a02a25b2ef4857bcdbf865d328187eee84419a7a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1b78dfc1-f89e1f8-b3153120339c6d47d6f6786ac86fa7ee9b0456a7/index.html

Web 🕸️
https://105425.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/shawnborton in version: 9.5.28-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

No help site update needed. This PR only changes how the Vendors empty-state subtitle is styled; the text, features, and workflows stay the same, so no help article sentence is now incorrect.

---

view run

[OSBotify]

🚀 Deployed to staging by https://github.com/shawnborton in version: 9.5.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS