Skip to content

[No QA] Docs updates for E/A#103535 Update submission schedule days and workspace timezone - #105320

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsSubmissionSchedules103535
Oct 30, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsSubmissionSchedules103535

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Add configurable submission schedules and workspace timezone UI lets admins pick the day for Weekly, both dates for Twice a month, and adds a workspace Timezone setting that controls when scheduled submissions run. These article sentences became incorrect:

docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.md

  • "Weekly — Reports are submitted weekly on Sundays" → now submitted on the day you select.
  • "Twice a month — Reports are submitted on the 15th and last day of the month" → now submitted on the two days you select.
  • "Daily — Reports are submitted each evening (Pacific Time)" and "All scheduled report submissions occur in the evening (Pacific Time)…" → now based on the workspace Timezone in Workspaces > [workspace name] > Overview.
  • "Selecting a frequency updates the checkmark…" → frequencies are now pills, so the checkmark reference is removed.

docs/articles/new-expensify/workspaces/Workspace-Workflows.md

  • "Weekly – … Violations are submitted on Sunday after correction." → now the next selected day.
  • "Twice a month – Reports are submitted on the 15th and the last day of the month." → now the two selected days.
  • "All automatic report submissions occur in the evening Pacific Time (PT)." → now based on the workspace Timezone.

UI labels (Frequency, Weekly, Twice a month, Timezone, Overview) were checked against the live web app:

Workflows Submissions section with Frequency row Frequency page with Submit frequency pills and Submit on row Workspace Overview Timezone row

@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #103535
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…pace timezone

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 29, 2026 01:21
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 29, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#103535 Update submission schedule days and workspace timezone [No QA] Docs updates for E/A#103535 Update submission schedule days and workspace timezone Oct 29, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

@stephanieelliott
stephanieelliott marked this pull request as ready for review October 30, 2026 21:03
@stephanieelliott
stephanieelliott self-requested a review as a code owner October 30, 2026 21:03
@melvin-bot

melvin-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @garrettmknight

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-30T22:04:30.528000Z
We couldn’t complete this review. Comment @codex review to try again.
cb1ebeb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team October 30, 2026 21:03
- **Daily** — Reports are submitted each evening (Pacific Time)
- **Weekly** — Reports are submitted weekly on Sundays
- **Twice a month** — Reports are submitted on the 15th and last day of the month
- **Daily** — Reports are submitted each evening in the workspace timezone

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming consistency: This line generalizes the setting as "the workspace timezone," but line 70 of this same article references the exact UI label Timezone (in Workspaces > [workspace name] > Overview). Per HELPSITE_NAMING_CONVENTIONS.md ("Use the exact text shown in the product UI" / "Do not generalize UI elements"), use the exact label here too, e.g. "submitted each evening based on the workspace Timezone." Keeping it consistent with line 70 also helps AI retrieval.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes targeted factual corrections to two articles following a product change that lets admins pick submission days for Weekly and Twice a month, and adds a workspace Timezone setting that controls when scheduled submissions run. The changes are small (8 additions, 8 deletions), accurate, and well-scoped. They only touch running text within existing frequency lists and FAQ answers, bringing the copy back in line with the current UI.

Scores Summary

  • Readability: 9/10 - Sentences remain clear, concise, and scannable. Removing the redundant checkmark clause ("Selecting a frequency updates the checkmark but does not take effect until you save" to "Selecting a frequency does not take effect until you save") is a clean tightening.
  • AI Readiness: 9/10 - Full feature names and exact UI labels (Weekly, Twice a month, Timezone, Overview) are preserved, and the workspace location is now explicit, improving retrieval precision. No headings or metadata changed, so hierarchy remains intact.
  • Style Compliance: 9/10 - The new navigation reference uses the correct bolded navigation path with a lowercase placeholder (Workspaces > [workspace name] > Overview), UI labels are bolded and match the UI, and generic terms ("workspace timezone") are lowercased in running text. Strong adherence to HELPSITE_NAMING_CONVENTIONS.md.

Key Findings

  • Replacing hardcoded schedules ("Sundays", "15th and last day") and "Pacific Time" with configurable, timezone-aware wording is accurate and matches the linked product PR (Add configurable submission schedules and workspace timezone UI #103535).
  • The navigation path Workspaces > [workspace name] > Overview follows the Navigation Paths convention exactly (bolded, > separators, lowercase bracketed placeholder).
  • Minor consistency nit: How-to-Set-Up-Automatic-Report-Submissions.md says submissions occur "in the evening" while Workspace-Workflows.md drops the "evening" qualifier in the parallel FAQ answer. Consider aligning both so the timing reads identically across articles.

Recommendations

  • No blocking issues. Optionally align the "evening" wording between the two FAQ answers for cross-article consistency.
  • Confirm the live UI label is exactly Timezone (one word) as written, since it is quoted and bolded.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.md - Accurate frequency and timezone corrections; compliant.
  • docs/articles/new-expensify/workspaces/Workspace-Workflows.md - Accurate frequency and timezone corrections; compliant.

Note: This review covers only the proposed diff lines, not unchanged content.

@stephanieelliott
stephanieelliott merged commit e3f13f4 into main Oct 30, 2026
26 of 27 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsSubmissionSchedules103535 branch October 30, 2026 21:15
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.27-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants