Repository navigation
[No QA] Docs updates for E/A#103535 Update submission schedule days and workspace timezone - #105320
Conversation
…pace timezone Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://adf90891.helpdot.pages.dev ⚡️ Updated articles: |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| - **Daily** — Reports are submitted each evening (Pacific Time) | ||
| - **Weekly** — Reports are submitted weekly on Sundays | ||
| - **Twice a month** — Reports are submitted on the 15th and last day of the month | ||
| - **Daily** — Reports are submitted each evening in the workspace timezone |
There was a problem hiding this comment.
Naming consistency: This line generalizes the setting as "the workspace timezone," but line 70 of this same article references the exact UI label Timezone (in Workspaces > [workspace name] > Overview). Per HELPSITE_NAMING_CONVENTIONS.md ("Use the exact text shown in the product UI" / "Do not generalize UI elements"), use the exact label here too, e.g. "submitted each evening based on the workspace Timezone." Keeping it consistent with line 70 also helps AI retrieval.
HelpDot Documentation ReviewOverall AssessmentThis PR makes targeted factual corrections to two articles following a product change that lets admins pick submission days for Weekly and Twice a month, and adds a workspace Timezone setting that controls when scheduled submissions run. The changes are small (8 additions, 8 deletions), accurate, and well-scoped. They only touch running text within existing frequency lists and FAQ answers, bringing the copy back in line with the current UI. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review covers only the proposed diff lines, not unchanged content. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.27-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Add configurable submission schedules and workspace timezone UI lets admins pick the day for Weekly, both dates for Twice a month, and adds a workspace Timezone setting that controls when scheduled submissions run. These article sentences became incorrect:
docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.mddocs/articles/new-expensify/workspaces/Workspace-Workflows.mdUI labels (Frequency, Weekly, Twice a month, Timezone, Overview) were checked against the live web app:
@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #103535
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari