fix: Widen the date columns of expanded Search groups for past-year dates by sam5235 · Pull Request #105307 · Expensify/App

sam5235 · 2026-10-28T23:49:01Z

Explanation of Change

Expanded groups in Spend (e.g. Group by From) only ever sized the Date column for past-year dates. getGroupColumnWidthFlags checked shouldShowYear alone, and TransactionGroupListExpanded and the group sub-header in GroupHeader passed only dateColumnSize down. So Submitted, Approved, Paid, Posted and Exported stayed at the narrow width (62px), and a date that shows the year ("Oct 22, 2025") was truncated. The ungrouped table already sizes these columns from the same row flags.

This is already on production for Submitted and Approved (the production branch, which doesn't include #103956, passes only the Date, Amount and Tax sizes to expanded rows). Paid follows the same pattern as Approved, so it showed the same truncation once it was added.

Changes:

getGroupColumnWidthFlags also returns shouldShowYearSubmitted, shouldShowYearApproved, shouldShowYearPaid, shouldShowYearPosted and shouldShowYearExported, set when any transaction in the group needs the year in that column.
TransactionGroupListExpanded passes the matching column sizes to each row and the flags to its header.
GroupHeader passes the same flags to its sticky sub-header, so the header and rows stay aligned.

Columns whose dates are all from the current year keep the narrow width. Only expanded groups on wide layouts are affected; the ungrouped table and narrow layouts are unchanged.

Fixed Issues

$ #105276
PROPOSAL: #105276 (comment)

Tests

Precondition: an account with paid expenses that were submitted, approved and paid in a previous year.

Go to Spend > Expenses on a wide layout.
Apply Filters > Status > Paid, and Filters > Date > Last year.
Set Display > Group by > From.
In Display > Edit columns, enable Submitted, Approved and Paid, and save.
Expand any group.
Verify the Submitted, Approved and Paid dates show in full with the year (e.g. "Oct 22, 2025") and are not truncated.
Verify the group's column sub-header lines up with the rows, including after scrolling the list so the sub-header sticks.
Change Filters > Date to This year and expand a group.
Verify the dates show without the year (e.g. "Oct 22") and the date columns keep their narrow width.
Remove Group by and verify the ungrouped Expenses table still shows the same dates and widths as before.

Verify that no errors appear in the JS console

Offline tests

Complete steps 1-5 above while online.
Go offline and collapse and expand the group again.
Verify the date columns keep the same widths and the dates are not truncated.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screenshot iPhone 17 Pro Max 10-28-2026 at 10 59 06 PM

iOS: mWeb Safari

Screenshot iPhone 17 Pro Max 10-28-2026 at 11 00 14 PM

MacOS: Chrome / Safari

The test account has no past-year data, so the browser clock was moved forward a year to make the 2026 dates past-year dates.

After (past-year dates):

Screen.Recording.2026-10-28.at.10.31.01.PM.mp4

After (current-year dates, unchanged):

Screen.Recording.2026-10-28.at.10.35.12.PM.mp4

Before (main):

…ates

melvin-bot · 2026-10-28T23:49:11Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-28T23:49:13Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-29T00:05:22.443239Z	`3b9cc32`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

codecov · 2026-10-28T23:54:02Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ponents/Search/SearchList/ListItem/GroupHeader.tsx	`90.95% <100.00%> (+0.23%)`	⬆️
...archList/ListItem/TransactionGroupListExpanded.tsx	`77.82% <100.00%> (+1.73%)`	⬆️
src/libs/SearchUIUtils.ts	`75.83% <100.00%> (+0.45%)`	⬆️
... and 12 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b9cc32592

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-10-29T00:05:19Z

+    const submittedColumnSize = shouldShowYearSubmitted ? CONST.SEARCH.TABLE_COLUMN_SIZES.WIDE : CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL;
+    const approvedColumnSize = shouldShowYearApproved ? CONST.SEARCH.TABLE_COLUMN_SIZES.WIDE : CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL;
+    const paidColumnSize = shouldShowYearPaid ? CONST.SEARCH.TABLE_COLUMN_SIZES.WIDE : CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL;
+    const postedColumnSize = shouldShowYearPosted ? CONST.SEARCH.TABLE_COLUMN_SIZES.WIDE : CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL;
+    const exportedColumnSize = shouldShowYearExported ? CONST.SEARCH.TABLE_COLUMN_SIZES.WIDE : CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL;


Include widened dates in the group scroll threshold

On wide web just above the 1024px breakpoint, when users enable several of these historical-date columns plus other fixed-width columns, these assignments add 40px per date while getGroupTableScrollLayout() still calls getTableMinWidth() without any of the new width flags (and therefore keeps its static estimates, such as 72px for Submitted/Approved/Paid/Posted). It can consequently leave shouldScrollHorizontally false after the fixed row width exceeds the viewport; because the ScrollView is then omitted, the rightmost columns overflow or are clipped. Pass the actual date-column minima/flags into the shared scroll-layout calculation so the header and rows enable scrolling at the new widths.

Useful? React with 👍 / 👎.

Good catch, fixed!

getGroupTableScrollLayout now takes the group's width flags and counts 102px for each date column that shows the year, so the header and rows switch to horizontal scrolling before those columns get clipped. Groups with only current-year dates keep the same estimate as before.

Added tests for both cases.

sam5235 · 2026-10-29T00:51:44Z

Expanded groups now use the same date column widths as the ungrouped table (62px, or 102px when a date shows the year). cc @Expensify/design in case you want to review.

FitseTLT · 2026-10-29T11:49:16Z

@sam5235 did you apply the fix to submitted and approved columns too.

sam5235 · 2026-10-29T11:54:34Z

Yes. Each date column (Date, Submitted, Approved, Paid, Posted and Exported) is widened on its own when any expense in the group has a past-year date in that column. The width is also counted when deciding whether the group's table scrolls horizontally.

FitseTLT · 2026-10-29T15:56:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

garrettmknight

Looks good from a product perspective.

github-actions · 2026-10-30T11:36:31Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-30T11:40:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-30T11:41:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105307 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-adbeeb35-b074b1f-28cd454f22481b22f007b45066ed5e6053b24bd3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-adbeeb35-b074b1f-aa64b6920365b78754c0f497628815afbfeb2741/index.html

Web 🕸️
https://105307.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-31T07:21:56Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.27-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-31T07:24:43Z

No help site update needed. This PR is a layout bug fix that widens date columns in expanded Spend groups so past-year dates no longer get cut off, and no help article describes column widths.

view run

OSBotify · 2026-11-02T18:23:29Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

fix: Widen the date columns of expanded Search groups for past-year d…

3b9cc32

…ates

sam5235 requested review from a team as code owners October 28, 2026 23:49

melvin-bot Bot assigned sam5235 Oct 28, 2026

melvin-bot Bot requested review from FitseTLT and removed request for a team October 28, 2026 23:49

melvin-bot Bot requested a review from garrettmknight October 28, 2026 23:49

melvin-bot Bot removed the request for review from a team October 28, 2026 23:49

chatgpt-codex-connector Bot reviewed Oct 29, 2026

View reviewed changes

Count widened date columns in the expanded group's scroll threshold

e059915

FitseTLT approved these changes Oct 29, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 October 29, 2026 16:13

garrettmknight approved these changes Oct 30, 2026

View reviewed changes

JS00001 approved these changes Oct 30, 2026

View reviewed changes

JS00001 merged commit adbeeb3 into Expensify:main Oct 30, 2026
39 of 45 checks passed

sam5235 mentioned this pull request Oct 30, 2026

[Due for payment 2026-11-05] [CFI] [$250] Spend - Add a Paid column option to the reports table #103650

Open

OSBotify mentioned this pull request Oct 31, 2026

Deploy Checklist: New Expensify 2026-10-31 #105544

Closed

77 tasks done

melvin-bot Bot mentioned this pull request Nov 2, 2026

[Due for payment 2026-11-09] Web - Spend - Paid date is truncated in table view #105276

Open

2 of 7 tasks

sam5235 mentioned this pull request Nov 4, 2026

[$175] Spend- From column Is missing when filtering by From is owner account #104247

Open

1 of 7 tasks

Conversation

sam5235 commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

codecov Bot commented Oct 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 29, 2026

Choose a reason for hiding this comment

Uh oh!

sam5235 Oct 29, 2026

Choose a reason for hiding this comment

Uh oh!

sam5235 commented Oct 29, 2026

Uh oh!

FitseTLT commented Oct 29, 2026

Uh oh!

sam5235 commented Oct 29, 2026

Uh oh!

FitseTLT commented Oct 29, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

garrettmknight left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

OSBotify commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

OSBotify commented Oct 31, 2026

Uh oh!

MelvinBot commented Oct 31, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sam5235 commented Oct 28, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 28, 2026 •

edited

Loading

codecov Bot commented Oct 28, 2026 •

edited by github-actions Bot

Loading