[CFI] Report anchored dropdown by DylanDylann · Pull Request #105028 · Expensify/App

DylanDylann · 2026-10-26T16:59:13Z

Explanation of Change

Implement a new Report dropdown

Fixed Issues

$ #101573
PROPOSAL:

Tests

Same QA steps

Verify that no errors appear in the JS console

Offline tests

Same QA steps

QA Steps

Override anchoredFieldDropdowns beta to true
Sign in and open a workspace chat on a workspace that has multiple reports created (> 12 reports)
Start a manual expense and continue to the confirmation form.
Click the Report row.
verify a pop-over opens
Pick a Report. Verify the pop-over closes and the row shows the picked Report

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-10-28.at.15.41.31.mov

Android: mWeb Chrome

Screen.Recording.2026-10-28.at.15.48.00.mov

iOS: HybridApp

Screen.Recording.2026-10-28.at.15.40.38.mov

iOS: mWeb Safari

Screen.Recording.2026-10-28.at.15.48.38.mov

MacOS: Chrome / Safari

Screen.Recording.2026-10-28.at.15.44.43.mov

melvin-bot · 2026-10-26T16:59:22Z

@ikevin127 @thelullabyy One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-26T16:59:25Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T16:19:29.501855Z	`ea5e6ca`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

codecov · 2026-10-26T17:05:17Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`95.90% <ø> (ø)`
src/components/AnchoredSelectionListPopover.tsx	`100.00% <100.00%> (ø)`
...eyRequestConfirmationList/sections/ReportField.tsx	`77.35% <100.00%> (+1.35%)`	⬆️
src/components/ReportPicker/ReportPickerModal.tsx	`100.00% <100.00%> (ø)`
...s/iou/request/step/DynamicIOURequestStepReport.tsx	`93.75% <100.00%> (+6.43%)`	⬆️
...questStepReport/hooks/useReportSelectionActions.ts	`87.12% <100.00%> (+5.31%)`	⬆️
...tConfirmationList/sections/ReportFieldDropdown.tsx	`96.42% <96.42%> (ø)`
...es/iou/request/step/IOURequestEditReportCommon.tsx	`87.96% <95.00%> (+0.33%)`	⬆️
...URequestStepReport/navigateAwayFromReportPicker.ts	`71.42% <71.42%> (ø)`
...URequestStepReport/hooks/useReportPickerActions.ts	`94.48% <94.48%> (ø)`
... and 7 files with indirect coverage changes

DylanDylann · 2026-10-26T17:08:51Z

There are a few minor issues on native. I’ll mark it as ready again once I’ve figured them out

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea5e6ca30d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…anchored-dropdown

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea5e6ca30d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ikevin127 · 2026-10-27T23:17:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

iOS: Native

Screen.Recording.iPhone.18.Pro.10-27-2026.at.17.51.58.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-10-27.at.17.26.57.mov

ikevin127

6 findings during code-review (1 🟠, 2 🟡, 3 🟢).

I left out what the bots already raised:

Fixed in the PR: PERF-10 (the effect is now renderInContainer) and Codex's "restricted-action route" finding (now handled by onNavigateAway)
Still open, not repeated: Codex's blockDistanceRequestIfNeeded → home-address navigation finding

You also commented "a few minor issues on native", so I understand that the PR may not be fully ready yet.

DylanDylann · 2026-10-28T08:47:21Z

@ikevin127 I resolved all comments

trjExpensify · 2026-10-28T20:58:24Z

@DylanDylann you have conflicts :)

DylanDylann · 2026-10-29T04:39:45Z

@ikevin127 All done

ikevin127

🟢 LGTM - Thanks for applying the changes

…tPickerActions.ts Co-authored-by: Puneet Lath <puneet@expensify.com>

DylanDylann · 2026-10-29T16:44:46Z

Thoughts on this?

@puneetlath Could you clarify what you mean? Are you saying goBack and onNavigateAway are duplicated? In the useReportPickerActions caller in DynamicIOURequestStepReport, I intentionally didn’t pass onNavigateAway

puneetlath · 2026-10-29T16:56:06Z

Oh, I'm just saying that there's an unresponded-to unresolved comment from the AI reviewer so I'm asking for your opinion on what it said.

I think in general we should always respond to these comments and either address the feedback or say why we're not taking the feedback and then resolve the comment.

github-actions · 2026-10-29T22:33:44Z

🚧 trjExpensify has triggered a test Expensify/App build. You can view the workflow run here.

trjExpensify

Why is the report field non-editable until I add a second open report? I would think it should be editable with the two options:

Create report
The existing open report

2026-10-29_23-38-20.mp4

DylanDylann · 2026-10-30T03:45:39Z

@trjExpensify This is the current behavior on staging, so it’s not caused by this PR. Currently, when creating an expense in a workspace chat, we only allow editing the report field if there’s more than one outstanding report. If you think we need to update that, I will do it in a follow-up PR

    // When creating an expense in an individual report, the report field becomes read-only
    // since the destination is already determined and there's no need to show a selectable list.
    const shouldReportBeEditable = (isUnreported ? outstandingReports.length >= 1 : outstandingReports.length > 1) && !isMoneyRequestReport(reportID);

puneetlath · 2026-10-30T15:20:18Z

@DylanDylann conflicts.

I do think we should make it possible to create the report from that flow, so let's make a follow-up PR for that.

github-actions · 2026-10-30T16:02:11Z

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-30T16:06:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-30T16:07:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105028 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-22f51349-b074b1f-28cd454f22481b22f007b45066ed5e6053b24bd3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-22f51349-b074b1f-aa64b6920365b78754c0f497628815afbfeb2741/index.html

Web 🕸️
https://105028.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-31T07:21:23Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.27-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-31T07:23:31Z

No help site update needed. The new Report pop-over only appears behind the ANCHORED_FIELD_DROPDOWNS beta (isBetaEnabled(CONST.BETAS.ANCHORED_FIELD_DROPDOWNS) in ReportField.tsx), and the rest of the PR refactors the full-page report selector without changing what users see.

view run

jponikarchuk · 2026-10-31T08:50:35Z

Deploy Blocker #105549 was identified to be related to this PR.

trjExpensify · 2026-11-02T13:47:27Z

I do think we should make it possible to create the report from that flow, so let's make a follow-up PR for that.

Agreed. I think you should be able to create unreported as well. So with autoReporting enabled I was expecting:

No existing eligible reports:

Create report [Default]
None <— the option to create it unreported.

Has eligible reports (one or more):

Create report
None
The open report it will go on [Default]
Other eligible report(s) listed

OSBotify · 2026-11-02T18:22:56Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

report-anchored-dropdown

ea5e6ca

DylanDylann requested review from a team as code owners October 26, 2026 16:59

melvin-bot Bot assigned DylanDylann Oct 26, 2026

melvin-bot Bot requested review from ikevin127 and thelullabyy and removed request for a team October 26, 2026 16:59

melvin-bot Bot requested review from trjExpensify and removed request for a team October 26, 2026 16:59

DylanDylann changed the title ~~[CFI] Tax anchored dropdown~~ [CFI] Report anchored dropdown Oct 26, 2026

github-actions Bot reviewed Oct 26, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestEditReportCommon.tsx Resolved

DylanDylann marked this pull request as draft October 26, 2026 17:08

chatgpt-codex-connector Bot reviewed Oct 26, 2026

View reviewed changes

Comment thread src/components/ReportPicker/ReportPickerModal.tsx Resolved

DylanDylann marked this pull request as ready for review October 27, 2026 15:53

DylanDylann added 3 commits October 27, 2026 23:04

Merge remote-tracking branch 'origin/main' into dylann/101573-report-…

39fb608

…anchored-dropdown

address comment

12af85a

Merge branch 'main' into dylann/101573-report-anchored-dropdown

638c310

chatgpt-codex-connector Bot reviewed Oct 27, 2026

View reviewed changes

Comment thread src/components/MoneyRequestConfirmationList/sections/ReportFieldDropdown.tsx Resolved

thelullabyy removed their request for review October 27, 2026 19:00

ikevin127 suggested changes Oct 28, 2026

View reviewed changes

ikevin127 reviewed Oct 28, 2026

View reviewed changes

Comment thread src/components/MoneyRequestConfirmationList/sections/ReportField.tsx Resolved

DylanDylann added 2 commits October 28, 2026 14:25

address comments

cd3b905

Merge branch 'main' into dylann/101573-report-anchored-dropdown

c042608

ikevin127 approved these changes Oct 29, 2026

View reviewed changes

melvin-bot Bot requested a review from puneetlath October 29, 2026 04:42

puneetlath requested changes Oct 29, 2026

View reviewed changes

Comment thread src/components/MoneyRequestConfirmationList/sections/ReportFieldDropdown.tsx Resolved

Comment thread src/pages/iou/request/step/IOURequestStepReport/hooks/useReportPickerActions.ts Resolved

Update src/pages/iou/request/step/IOURequestStepReport/hooks/useRepor…

5b3bc50

…tPickerActions.ts Co-authored-by: Puneet Lath <puneet@expensify.com>

This comment has been minimized.

Sign in to view

trjExpensify reviewed Oct 29, 2026

View reviewed changes

DylanDylann requested a review from puneetlath October 30, 2026 03:45

puneetlath previously approved these changes Oct 30, 2026

View reviewed changes

Merge branch main into dylann/101573-report-anchored-dropdown

6f44790

DylanDylann dismissed puneetlath’s stale review via 6f44790 October 30, 2026 15:44

puneetlath approved these changes Oct 30, 2026

View reviewed changes

puneetlath merged commit 22f5134 into Expensify:main Oct 30, 2026
38 of 39 checks passed

OSBotify mentioned this pull request Oct 31, 2026

Deploy Checklist: New Expensify 2026-10-31 #105544

Closed

77 tasks done

applause-bot Bot mentioned this pull request Oct 31, 2026

[Due for payment 2026-11-11] Android - Expense - Attendee field is empty after creating new report #105549

Open

1 of 7 tasks

jponikarchuk mentioned this pull request Oct 31, 2026

[CFI] Replace the full-page selectors for Category, tag, Tax rate, Attendees, and Report with anchored pop-overs #101573

Open

DylanDylann mentioned this pull request Nov 5, 2026

Refactor ReportField logic to simplify report editability condition #105939

Open

41 of 43 tasks

Conversation

DylanDylann commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 26, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

codecov Bot commented Oct 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

DylanDylann commented Oct 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ikevin127 commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Oct 28, 2026

Uh oh!

trjExpensify commented Oct 28, 2026

Uh oh!

DylanDylann commented Oct 29, 2026

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Oct 29, 2026

Uh oh!

puneetlath commented Oct 29, 2026

Uh oh!

github-actions Bot commented Oct 29, 2026

Uh oh!

This comment has been minimized.

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Oct 30, 2026

Uh oh!

puneetlath commented Oct 30, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

OSBotify commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

DylanDylann commented Oct 26, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 26, 2026 •

edited

Loading

codecov Bot commented Oct 26, 2026 •

edited by github-actions Bot

Loading

ikevin127 commented Oct 27, 2026 •

edited

Loading