Repository navigation
Fix Consolidated Travel Billing not turning back on after turning it off - #104820
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66917eb68b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (nested.isEnabled === false) { | ||
| continue; |
There was a problem hiding this comment.
When a pay-by-invoice feed has invoiceTo but no paymentBankAccountID, turning it off sets isEnabled to false and this branch removes it from accessibleTravelFeeds. The fallback in WorkspaceTravelBillingSection.continueToggleFlow then treats it as lacking a settlement account and routes to WorkspaceTravelBillingSettlementAccountPage, whose only activation path calls configureTravelBillingForPolicy with a selected bank account. As a result, invoice-only customers cannot turn Consolidated Travel Billing back on without adding or switching to an ACH account, so this disabled state needs an invoice-capable re-enable path rather than being unconditionally filtered out.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
a pay-by-invoice feed with no bank account gets removed when it's turned off, and turning it on needs a verified bank account anyway, so the settlement account page is right here
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.5.28-4 🚀
|
|
No help site update needed. This bug fix makes Consolidated Travel Billing turn back on the way users already expect, and no sentence in Enable Consolidated Travel Billing in a Workspace becomes incorrect. |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.5.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.5.30-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Turning Consolidated Travel Billing off leaves the travel feed with
isEnabled: false, but the feed still showed in the feed selector. Picking it only links the feed to the workspace and doesn't turn it back on, so the toggle stayed off. Now a turned off travel feed is hidden from the selector, so turning the toggle on goes through the regular enable flow.Fixed Issues
$ #102990
PROPOSAL:
Tests
Offline tests
N/A, no change to offline behavior.
QA Steps
ping @blimpich
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari