[Part 5] Remove Onyx.connect(ONYXKEYS.SESSION) in /Session/index.ts: thread sesion through isAnonymousUser by truph01 · Pull Request #104677 · Expensify/App

truph01 · 2026-10-22T05:12:10Z

Explanation of Change

Refactor these below chains:

- isAnonymousUser (libs/actions/Session/index.ts) -> getReportPrivateNote (libs/actions/Report/index.ts)
- isAnonymousUser (libs/actions/Session/index.ts) -> markAllMessagesAsRead (libs/actions/Report/MarkAllMessageAsRead.tsx)
- isAnonymousUser (libs/actions/Session/index.ts) -> updateTheme (libs/actions/User.ts)

Fixed Issues

$ #67782
PROPOSAL:

Tests

Go to Inbox > Right click on "Unread" tab > "Mark all as read"
Verify all unread reports are marked as read successfully

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include ""[No QA].""
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-10-28.at.09.07.49.mov

… and updateTheme

melvin-bot · 2026-10-22T05:12:18Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-22T05:12:26Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-22T05:26:49.742061Z	`4c5a71f`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c5a71f73d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

… isAnonymousUser

codecov · 2026-10-22T07:33:17Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/HighContrastModeSwitcher.tsx	`95.83% <100.00%> (+0.18%)`	⬆️
src/libs/actions/Report/MarkAllMessageAsRead.tsx	`71.87% <100.00%> (-18.75%)`	⬇️
src/libs/actions/Report/index.ts	`75.29% <100.00%> (+0.40%)`	⬆️
src/libs/actions/User.ts	`48.23% <100.00%> (+1.66%)`	⬆️
.../DynamicReportDetailsPage/ReportDetailsContent.tsx	`100.00% <100.00%> (ø)`
src/pages/inbox/sidebar/InboxTabSelector.tsx	`86.51% <100.00%> (+0.15%)`	⬆️
src/selectors/Session.ts	`100.00% <100.00%> (ø)`
src/hooks/useReconcileHighContrastIntent.ts	`72.22% <50.00%> (ø)`
...dShortcutsHandler/MarkAllMessagesAsReadHandler.tsx	`95.65% <83.33%> (+1.20%)`	⬆️
...box/report/withReportAndPrivateNotesOrNotFound.tsx	`0.00% <0.00%> (ø)`
... and 1 more
... and 7 files with indirect coverage changes

trjExpensify · 2026-10-22T20:38:18Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

shubham1206agra · 2026-10-27T14:10:33Z

@truph01 Add tests please

shubham1206agra · 2026-10-27T14:28:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-10-27.at.7.56.59.PM.mov

truph01 · 2026-10-28T02:09:26Z

@shubham1206agra I added tests

mountiny

Lgtm, thanks

mountiny · 2026-10-30T05:32:12Z

@MelvinBot is the failing reasurre test related to this pr's changes or is that flaky?

MelvinBot · 2026-10-30T05:35:27Z

The failing Reassure check looks flaky. It is not caused by this PR.

Evidence

The failing measurement is [ReportActionsList] should re-render when only a heartbeat field of the report changes. Its render count went from 27 to 27.60, a +0.6 difference against an allowed deviation of 0. (run log)
A fractional average like 27.60 means the count changed between repeated runs of the same code. That points to nondeterministic re-renders, not a real regression.
In the same run, other ReportActionsList counts moved the other way. For example, "unrelated report is written" went from 8.70 to 8.10.
In the last day, the same group of ReportActionsList render-count tests failed on unrelated PRs with the same ~0.6–0.7 difference. Those tests include "unrelated report is written" and "report name changes".
This PR does not change ReportActionsList or the Reassure tests.

You can rerun the check. It will likely pass.

view run

mountiny · 2026-11-02T03:54:35Z

@truph01 was this PR merged to main through different PR?

truph01 · 2026-11-02T03:57:25Z

@truph01 was this PR merged to main through different PR?

@mountiny No, this PR refactors different call chains.

OSBotify · 2026-11-02T18:22:35Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

refactor: pass session to getReportPrivateNote, markAllMessagesAsRead…

4c5a71f

… and updateTheme

truph01 requested review from a team as code owners October 22, 2026 05:12

melvin-bot Bot assigned truph01 Oct 22, 2026

melvin-bot Bot requested review from shubham1206agra and removed request for a team October 22, 2026 05:12

melvin-bot Bot requested review from trjExpensify and removed request for a team October 22, 2026 05:12

chatgpt-codex-connector Bot reviewed Oct 22, 2026

View reviewed changes

Comment thread src/libs/actions/Report/MarkAllMessageAsRead.tsx Resolved

fix: let an explicit session override the cached anonymous session in…

37a02d7

… isAnonymousUser

truph01 mentioned this pull request Oct 22, 2026

Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Session/index.ts #67782

Open

trjExpensify removed their request for review October 22, 2026 20:38

Merge branch 'Expensify:main' into fix/67782-v5

f29eaa5

shubham1206agra approved these changes Oct 28, 2026

View reviewed changes

melvin-bot Bot requested review from danieldoglas and mountiny October 28, 2026 06:13

mountiny approved these changes Oct 30, 2026

View reviewed changes

stephanieelliott closed this pull request by merging all changes into Expensify:main in 3e1a3fd Oct 30, 2026

marufsharifi pushed a commit to marufsharifi/App that referenced this pull request Oct 30, 2026

Merge pull request Expensify#104677 from truph01/fix/67782-v5

c6e9be4

OSBotify mentioned this pull request Oct 31, 2026

Deploy Checklist: New Expensify 2026-10-31 #105544

Closed

77 tasks done

MelvinBot mentioned this pull request Oct 31, 2026

[Due for payment 2026-11-11] Android - Expense - Attendee field is empty after creating new report #105549

Open

1 of 7 tasks

Conversation

truph01 commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 22, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Oct 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify commented Oct 22, 2026

Uh oh!

shubham1206agra commented Oct 27, 2026

Uh oh!

shubham1206agra commented Oct 27, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Oct 28, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Oct 30, 2026

Uh oh!

MelvinBot commented Oct 30, 2026

Uh oh!

mountiny commented Nov 2, 2026

Uh oh!

truph01 commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

truph01 commented Oct 22, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 22, 2026 •

edited

Loading

codecov Bot commented Oct 22, 2026 •

edited by github-actions Bot

Loading