[No QA] Send NPS score and response date to FullStory by c3024 · Pull Request #104452 · Expensify/App

c3024 · 2026-10-20T07:53:24Z

Explanation of Change

Sends the new userMetadata fields from Auth PR 25673 to FullStory as nps_score and nps_response_date. The date is converted to Date like free_trial_end_date. Web declares it as a date in the setProperties schema and native adds the _date suffix, so FullStory types it as a date on both. Users who never answered an NPS survey have no fields, so nothing is sent for them.

Fixed Issues

$ #103321
PROPOSAL: N/A

Tests

Run npm test -- tests/unit/FullstoryUtilsTest.ts.
Verify all tests pass, including the check that nps_score and nps_response_date are built from userMetadata.

Verify that no errors appear in the JS console

Offline tests

N/A. No network behavior changes.

QA Steps

FullStory only runs on production, so this can't be tested on staging.

After deploy, sign in on production as a user who has answered an NPS survey.
Open that user's profile in FullStory.
Verify nps_score and nps_response_date are set.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A, no UI change.

Android: mWeb Chrome

N/A, no UI change.

iOS: Native

N/A, no UI change.

iOS: mWeb Safari

N/A, no UI change.

MacOS: Chrome / Safari

N/A, no UI change.

…story-nps-migrated-date

inimaga

Thanks for raising this PR. Could you also update the call inside setUserVars, In the web adapter at src/libs/Fullstory/index.ts,

From:

FullStory(CONST.FULLSTORY.OPERATION.SET_PROPERTIES, {
    type: 'user',
    properties: userVars,
});

To:

FullStory(CONST.FULLSTORY.OPERATION.SET_PROPERTIES, {
    type: 'user',
    properties: userVars,
    schema: {
        properties: {
            nps_response_date: 'date',
        },
    },
});

This would explicitly tell FullStory to treat the property as a date.

c3024 · 2026-11-02T12:01:32Z

Done, web now declares nps_response_date as a date in the setProperties schema. Thanks!

codecov · 2026-11-02T12:04:33Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Fullstory/utils.ts	`89.53% <100.00%> (ø)`
src/libs/Fullstory/index.ts	`0.00% <0.00%> (ø)`
... and 4871 files with indirect coverage changes

inimaga · 2026-11-02T13:23:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-11-02T14:10:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-11-02T14:32:06Z

🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-11-02T14:37:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104452 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-be13feaf-d007e13-822ae8a76e93205bccdb9c52c597eb3f32d6a25c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-be13feaf-d007e13-8392d755c416846fe8451a6df4f5dc65f2a3b85e/index.html

Web 🕸️
https://104452.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-11-02T18:52:04Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.5.28-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-11-02T18:57:51Z

No help site update needed. This PR only sends NPS score and response date to FullStory for internal analytics, so nothing changes in the app that users can see or do.

view run

OSBotify · 2026-11-03T17:57:10Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.5.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-11-03T19:03:02Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

c3024 added 2 commits October 20, 2026 13:21

Send NPS score, NPS response date and NewDot migrated date to FullStory

b8a8d11

Merge remote-tracking branch 'origin/main' into chaitanya/103321-full…

97fabf9

…story-nps-migrated-date

melvin-bot Bot assigned c3024 Oct 20, 2026

c3024 changed the title ~~Send NPS score and NewDot migrated date to FullStory~~ [HOLD Auth#25673] Send NPS score and NewDot migrated date to FullStory Oct 20, 2026

Remove new_dot_migrated_date from FullStory user vars

c4bcbf9

c3024 changed the title ~~[HOLD Auth#25673] Send NPS score and NewDot migrated date to FullStory~~ [No QA] Send NPS score and response date to FullStory Oct 30, 2026

c3024 marked this pull request as ready for review October 30, 2026 14:22

c3024 requested review from a team as code owners October 30, 2026 14:22

melvin-bot Bot requested review from garrettmknight and thelullabyy and removed request for a team October 30, 2026 14:22

c3024 requested a review from inimaga October 30, 2026 14:29

inimaga requested changes Nov 2, 2026

View reviewed changes

Declare nps_response_date as a date in the web FullStory schema

14feff7

c3024 requested a review from inimaga November 2, 2026 12:01

inimaga approved these changes Nov 2, 2026

View reviewed changes

inimaga removed the request for review from thelullabyy November 2, 2026 13:22

inimaga merged commit be13fea into Expensify:main Nov 2, 2026
38 of 40 checks passed

OSBotify mentioned this pull request Nov 2, 2026

Deploy Checklist: New Expensify 2026-11-02 #105665

Closed

75 tasks done

melvin-bot Bot mentioned this pull request Nov 3, 2026

Add NPS score and date and NewDot migrated date as FullStory custom user properties #103321

Open

Navigation Menu

Repository navigation

[No QA] Send NPS score and response date to FullStory - #104452

[No QA] Send NPS score and response date to FullStory#104452
inimaga merged 4 commits into
Expensify:mainfrom
c3024:chaitanya/103321-fullstory-nps-migrated-date

c3024 commented Oct 20, 2026 •

edited

Loading

Uh oh!

inimaga left a comment

Uh oh!

c3024 commented Nov 2, 2026

Uh oh!

codecov Bot commented Nov 2, 2026 •

edited by github-actions Bot

Loading

Uh oh!

inimaga commented Nov 2, 2026

Uh oh!

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

MelvinBot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 3, 2026

Uh oh!

OSBotify commented Nov 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

c3024 commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

inimaga left a comment

Choose a reason for hiding this comment

Uh oh!

c3024 commented Nov 2, 2026

Uh oh!

codecov Bot commented Nov 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

inimaga commented Nov 2, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 2, 2026

Uh oh!

MelvinBot commented Nov 2, 2026

Uh oh!

OSBotify commented Nov 3, 2026

Uh oh!

OSBotify commented Nov 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

c3024 commented Oct 20, 2026 •

edited

Loading

codecov Bot commented Nov 2, 2026 •

edited by github-actions Bot

Loading