Skip to content

feat: show Expensify Card wording for added card feed policy #admin changelog actions - #104202

Merged
puneetlath merged 8 commits into
Expensify:mainfrom
rayane-d:expensify-card-feed-changelog
Oct 29, 2026
Merged

puneetlath merged 8 commits into
Expensify:mainfrom
rayane-d:expensify-card-feed-changelog

Conversation

@rayane-d

@rayane-d rayane-d commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When an admin shares an Expensify Card feed to a workspace, the backend will post the existing POLICYCHANGELOG_ADD_CARD_FEED action in #admins. The action has a new originalMessage.feedType set to ExpensifyCard.

This PR shows those actions as added "<feed name>" Expensify Card feed. Actions without feedType keep the current added card feed text.

The action type does not change, so every place that renders it already goes through getAddedCardFeedMessage: the report action, LHN preview, thread title and copy to clipboard. That is why only that function changes.

The App does not create this action optimistically. It can't tell a new link from an already-linked feed, and only a new link should post.

Fixed Issues

$ #104089
PROPOSAL:

Tests

  1. Create a domain and an Expensify Card for it.
  2. Sign in with a domain admin account for that domain.
  3. In OldDot, open the domain's Company Cards settings and verify the Expensify Card domain feed shows.
  4. In NewDot, create a workspace and enable Expensify Card in More features.
  5. Open the workspace's Expensify Card page.
  6. Choose View cards.
  7. Choose the Expensify Card domain feed in the Expensify Card selector.
  8. Open the workspace's #admins room.
  9. Verify it shows the added "<feed name>" Expensify Card feed message.
Screen.Recording.mov
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  1. In Expensify Classic, sign in with an account whose email uses your company's private domain.
  2. If the domain is not claimed yet, go to Settings > Domains, click New Domain, enter the domain, and click Submit.
  3. If the account has no verified US business bank account, go to Settings > Account > Wallet and click Add Verified Bank Account under Bank Accounts.
  4. If the domain has no Expensify Card program yet, go to Settings > Domains > [Domain Name] > Company Cards, click Get the Card, and wait for approval.
  5. Go to Settings > Domains > [Domain Name] > Company Cards and verify the Expensify Card domain feed shows.
  6. In New Expensify, create a workspace.
  7. Go to Settings > Workspaces > [Workspace Name] > More features and turn on Expensify Card under Spend.
  8. Go to Workspaces > [Workspace Name] > Expensify Card.
  9. Choose View cards.
  10. Choose the Expensify Card domain feed in the Expensify Card selector.
  11. Open the workspace's #admins room.
  12. Verify it shows the added "<domain name>" Expensify Card feed message.

Help articles:

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot

melvin-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@rayane-d rayane-d changed the title feat: show Expensify Card wording for added card feed policy #admin changelog actions [Hold Auth#25578 Web-E#57205] feat: show Expensify Card wording for added card feed policy #admin changelog actions Oct 22, 2026
@rayane-d
rayane-d requested a review from puneetlath October 22, 2026 23:43
@rayane-d
rayane-d marked this pull request as ready for review October 22, 2026 23:43
@rayane-d
rayane-d requested review from a team as code owners October 22, 2026 23:43
@melvin-bot
melvin-bot Bot requested review from Ollyws and removed request for a team October 22, 2026 23:43
@melvin-bot

melvin-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 22, 2026 23:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T00:00:40.571744Z 77a4196 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77a4196719

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/ReportActionsUtils.ts Resolved
@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

i'll test this once the backend is out 🫡

@rayane-d rayane-d changed the title [Hold Auth#25578 Web-E#57205] feat: show Expensify Card wording for added card feed policy #admin changelog actions [Hold Auth#25578] feat: show Expensify Card wording for added card feed policy #admin changelog actions Oct 26, 2026
@rayane-d rayane-d changed the title [Hold Auth#25578] feat: show Expensify Card wording for added card feed policy #admin changelog actions feat: show Expensify Card wording for added card feed policy #admin changelog actions Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me. Good for product 👍

@Ollyws

Ollyws commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp Android_Native
Android: mWeb Chrome Android_Chrome
iOS: HybridApp iOS_Native
iOS: mWeb Safari iOS_Safari
MacOS: Chrome / Safari MacOS_Chrome

@Ollyws

Ollyws commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

@rayane-d is the expected behaviour for it to be a reply to "enabled Expensify cards" like this?:

Screen.Recording.2026-10-28.at.19.54.18.mov

@rayane-d

Copy link
Copy Markdown
Contributor Author

@rayane-d is the expected behaviour for it to be a reply to "enabled Expensify cards" like this?:

Screen.Recording.2026-10-28.at.19.54.18.mov

@Ollyws, yes, this is expected behavior. Policy changelog system messages are supposed to be posted as replies in a thread in the admins room, rather than as standalone messages.

@Ollyws Ollyws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@puneetlath
puneetlath merged commit 3b3e8db into Expensify:main Oct 29, 2026
36 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@rayane-d
rayane-d deleted the expensify-card-feed-changelog branch October 29, 2026 23:25
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.27-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. This PR only changes the wording of the system message in the workspace #admins room when an Expensify Card feed is shared, and that in-app message explains itself; no help article sentence names or describes this message.


view run

@OSBotify

OSBotify commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants