Repository navigation
feat: show Expensify Card wording for added card feed policy #admin changelog actions - #104202
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77a4196719
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
i'll test this once the backend is out 🫡 |
|
🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Tests well for me. Good for product 👍
Reviewer Checklist
Screenshots/Videos |
|
@rayane-d is the expected behaviour for it to be a reply to "enabled Expensify cards" like this?: Screen.Recording.2026-10-28.at.19.54.18.mov |
@Ollyws, yes, this is expected behavior. Policy changelog system messages are supposed to be posted as replies in a thread in the admins room, rather than as standalone messages. |
|
🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.27-0 🚀
|
|
No help site update needed. This PR only changes the wording of the system message in the workspace #admins room when an Expensify Card feed is shared, and that in-app message explains itself; no help article sentence names or describes this message. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀
Bundle Size Analysis (Sentry): |





Explanation of Change
When an admin shares an Expensify Card feed to a workspace, the backend will post the existing
POLICYCHANGELOG_ADD_CARD_FEEDaction in #admins. The action has a neworiginalMessage.feedTypeset toExpensifyCard.This PR shows those actions as
added "<feed name>" Expensify Card feed. Actions withoutfeedTypekeep the currentadded card feedtext.The action type does not change, so every place that renders it already goes through
getAddedCardFeedMessage: the report action, LHN preview, thread title and copy to clipboard. That is why only that function changes.The App does not create this action optimistically. It can't tell a new link from an already-linked feed, and only a new link should post.
Fixed Issues
$ #104089
PROPOSAL:
Tests
added "<feed name>" Expensify Card feedmessage.Screen.Recording.mov
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
added "<domain name>" Expensify Card feedmessage.Help articles:
https://help.expensify.com/articles/expensify-classic/expensify-card/Set-Up-the-Expensify-Visa-Commercial-Card-for-your-Company
https://help.expensify.com/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-US
https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/bank-accounts/Connect-US-Business-Bank-Account
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari