Repository navigation
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@MelvinBot review |
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| createDynamicRoute(DYNAMIC_ROUTES.MONEY_REQUEST_STEP_CATEGORY.getRoute({action: actionName, iouType: CONST.IOU.TYPE.SUBMIT, transactionID, reportID: expenseChatReportID})), | ||
| ); | ||
| } else { | ||
| Navigation.setNavigationActionToMicrotaskQueue(() => { |
There was a problem hiding this comment.
❌ CONSISTENCY-18 (docs)
This change wraps the navigation in Navigation.setNavigationActionToMicrotaskQueue(...), but there is no comment explaining why the deferral is needed. Deferral calls like this are exactly the kind of non-obvious workaround the next contributor cannot recover from the code alone: it reads as an arbitrary indirection, and someone could easily "simplify" it back to a direct Navigation.navigate(...) and silently reintroduce the recipient-picker flash. The crucial reasoning lives only in the PR description.
Add a comment directly above the call capturing the why, for example:
// The recipient participant is written with Onyx.merge, which lands a microtask after this press
// handler. Navigating synchronously would render the confirmation screen before the merge, so it
// would see no participants and auto-open the Choose recipient picker. Defer navigation by a
// microtask plus an animation frame so the merge is applied first.
Navigation.setNavigationActionToMicrotaskQueue(() => {Reviewed at: 6733889 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
|
The fix looks correct, and I found no blocking issues. It matches the twin no-workspace flow in Two suggestions:
What I checked
I reviewed the code only. I did not run the manual test steps. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
I added comment with explanation + regression test |
garrettmknight
left a comment
garrettmknight
left a comment
There was a problem hiding this comment.
Looks good from a product perspective.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariScreen.Recording.2026-10-18.at.15.32.58.movMacOS: Chrome / SafariScreen.Recording.2026-10-18.at.15.31.58.mov |
|
🚧 deetergp has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.5.15-1 🚀
|
|
No help site update needed. This PR fixes a brief flash of the Choose recipient page in the "Submit to my employer" flow, so the app now does what users already expect, and no article sentence becomes incorrect. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Onyx.set(participants[]), then writes the new workspace as recipient withOnyx.merge, then navigates. The merge lands a microtask later, but navigation from a press handler renders the confirmation page synchronously, so it first sees no participants and auto-opens the picker. Onyx 3.0.117 no longer reportsloadingfor a cached key with a pending merge, which used to hide this.createDraftWorkspaceAndNavigateToConfirmationScreennow navigates throughNavigation.setNavigationActionToMicrotaskQueue(microtask + one animation frame), the same helper the twin flow inuseParticipantSubmission.tsalready uses. Measured delay is about 9ms; awaiting the merge promise instead would wait for the storage write (about 240ms).setNavigationActionToMicrotaskQueueinCreateDraftTransactionTest.tsnow invokes its callback, so existing navigation assertions still run.Fixed Issues
$ #104131
PROPOSAL:
Tests
###Test 1: Submit to my employer without a workspace
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Uploading ios.mov…
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov