Repository navigation
[No QA] Docs updates for E/A#103652 Add Join my company workspace onboarding option - #103991
Conversation
Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
MelvinBot
added
the
HelpDot
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? cc @heyjennahay |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@heyjennahay Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| If you're signing up without an invite, select **Join my company workspace** when asked **What do you want to do today?** After you add and verify your work email, Expensify shows the workspaces at your company that you can join. Click **Join now**, or **Ask to join** if the workspace needs admin approval. | ||
| If you're creating your Expensify account, you can also find your company's workspace yourself: | ||
|
|
||
| 1. When asked **What do you want to do today?**, choose **Join my company workspace**. |
There was a problem hiding this comment.
Naming violation (select vs choose): Use select here, not choose. Per HELPSITE_NAMING_CONVENTIONS.md, choose is only for deciding between options; activating a UI element/option like Join my company workspace should use select. Suggest: "select Join my company workspace".
| ## Can I try a different work email on the same account? | ||
|
|
||
| Yes, while the work email step is still open. If the message appears under the field, correct the address and click **Add work email** again. Once you click **Skip** or **Got it**, the step doesn’t appear again — add the address you want as a contact method after setup instead. | ||
| Yes, while the work email step is still open. If the message appears under the field, correct the address and click **Add work email** again. Once you click **Skip** or **Got it**, the step only appears again if you choose **Join my company workspace** during setup or open the **Add your work email** task from Concierge. Otherwise, add the address you want as a contact method after setup instead. |
There was a problem hiding this comment.
Naming violations in modified line: Per HELPSITE_NAMING_CONVENTIONS.md, do not use click — use select (e.g., "select Add work email", "select Skip or Got it"). Also choose **Join my company workspace** should be select since it activates a UI option, not a decision between options.
HelpDot Documentation ReviewOverall AssessmentThis PR makes two small, targeted content edits in the New Expensify "Getting started" hub. It documents the self-serve path for joining a company workspace (including the new Join my company workspace / Skip / Concierge task behavior) and updates a related FAQ answer in the work-email troubleshooting article. Both changes are accurate, scoped to a single workflow, and improve clarity. The edits themselves are largely compliant; the main gaps are inherited from surrounding content rather than introduced here. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
A preview of your ExpensifyHelp changes have been deployed to https://4871ef1c.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.15-1 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Updates the help site for the new Join my company workspace onboarding option, added in Add the join-workspace onboarding intent and Concierge follow up tasks. The option has no beta gate, so all users who reach What do you want to do today? can see it.
Join-your-company's-workspace.mdonly described joining by admin invite. It now has three short steps for finding the workspace yourself during account setup.Troubleshoot-Adding-Your-Work-Email.mdsaid: "Once you click Skip or Got it, the step doesn’t appear again — add the address you want as a contact method after setup instead." That's no longer true. Choosing Join my company workspace reopens What’s your work email?, and skipping it creates an Add your work email Concierge task that links back to the step. The sentence now names both cases.Labels were checked against
src/languages/en.tsand the live web UI (What do you want to do today?, Join my company workspace, What’s your work email?, Skip, Join now, Ask to join, Add your work email).@carlosmiceli, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/672346
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari