Repository navigation
[Payment due @nyomanjyotisa] [No QA] Bump compression from 1.7.4 to 1.8.2 - #103757
Conversation
|
@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
npm has a |
Reviewer Checklist
Screenshots/VideosMedia checklist items are N/A under the reviewer-confirmed dev-server-only scope. The Android Metro/Fast Refresh recording below is the supporting evidence; no other-platform media is attached. Android: HybridAppPR-103757-android-native-metro-fast-refresh.mp4Android: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@nyomanjyotisa is this approved? |
|
🎯 @nyomanjyotisa, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 flodnv has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/flodnv in version: 9.5.15-1 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #104621 |
Explanation of Change
Bumps transitive
compression1.7.4 → 1.8.2 (lockfile only) to fix GHSA-vc2v-76pw-4v95 (DoS via memory leak). Also pullson-headers1.1.0 (GHSA-76c9-3jph-rj3q).Usage: dev-only. Gzip middleware for the Metro dev server, pulled in by
@react-native-community/cli-server-apiand@expo/cli. Not bundled into the app.Change Log
1.8.2
Cache-Control: no-transformcase-insensitively1.8.1
1.8.0
res.headersSentwhen available_implicitHeaderwithwriteHeadpropertyenforceEncodingoption1.7.5
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/690937
PROPOSAL:
Tests
npm ci, thennpm ls compression→ only1.8.2npm run start(Metro); openhttp://localhost:8081/status→packager-status:runningOffline tests
QA Steps
None. Dev-server-only dependency.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari