Repository navigation
[cp staging] Revert https://github.com/Expensify/App/pull/102106 - #103612
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🔁 Filed a Staging retest request for deploy blockers #103555 after this PR was cherry-picked to staging. |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.5.6-4 🚀
|
|
No help site update is needed. This PR reverts [Rules Engine Release 1] Use the new SetRule and DeleteRule commands, which only switches merchant rule saves and deletes back to the earlier backend commands, so it changes no labels, steps, or user-facing behavior. |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.5.7-0 🚀
|
|
No help site update is needed. This PR reverts [Rules Engine Release 1] Use the new SetRule and DeleteRule commands, which only switches merchant rule saves and deletes back to the earlier backend commands, so no article sentence, label, or step becomes incorrect. |
Explanation of Change
Revert #102106
Fixed Issues
$ #103555
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
N/A
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos