Repository navigation
Revert "Add imported vendor enable and disable controls" - #103607
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0afd6ce086
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dismissError: () => clearVendorErrors(policyID, vendor.externalID), | ||
| }; | ||
| }); | ||
| const vendorRows: WorkspaceVendorTableRowData[] = useMemo( |
There was a problem hiding this comment.
This production component is processed by React Compiler, so reintroducing useMemo violates the repository's explicit compiler convention and can fail the React Compiler compliance gate. It also provides no caching here because sortedVendors is recreated immediately above on every render; map directly to vendorRows instead. CLAUDE.mdL57-L61
Useful? React with 👍 / 👎.
|
🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
…ng-enable-disable Revert "Add imported vendor enable and disable controls" (cherry picked from commit 55f9953) (cherry-picked to staging by Beamanator)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.5.6-1 🚀
|
|
No help site update is needed. This PR reverts Add imported vendor enable and disable controls, and no article on One follow-up: the draft docs PR [No QA] Docs updates for E/A#102756 Explain how to enable or disable imported vendors documents the reverted feature. It is still open, so close it or put it on hold until the feature ships again. |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.5.7-0 🚀
|
|
No help site update is needed. This PR reverts Add imported vendor enable and disable controls, and no article on The draft docs PR for the reverted feature, [No QA] Docs updates for E/A#102756 Explain how to enable or disable imported vendors, is already closed, so nothing else needs to change. |
4 participants
Reverts #102756
Fixes
$ #103529
$ #103556