Use useDecisionModal for Search bulk actions and SelectionToolbar alerts by MelvinBot · Pull Request #103554 · Expensify/App

MelvinBot · 2026-10-09T07:08:09Z

Explanation of Change

Batch 2 of the DecisionModal → useDecisionModal migration. Search bulk actions and the report SelectionToolbar each mounted their own one-button DecisionModal alerts and kept visibility state for them. These five alerts now open through the global useDecisionModal():

Search bulk actions (useSearchBulkActions / SearchBulkActionsButton):
- "You appear to be offline": every trigger site now calls showOfflineModal(). The deferModalPresentationAfterPopoverDismiss wrapper in bulk pay is kept, so iOS still waits for the popover to close.
- "Download failed": each trigger site now passes its prompt explicitly. Empty-report exports use downloadFailedEmptyReportDescription with the count. All other failures use downloadFailedDescription. Before, the prompt read a shared emptyReportsCount that was reset in only one place. A later, unrelated failure could show the stale "empty report" text.
- "Expensify Card statement PDF: one feed at a time": shown from exportExpensifyCardStatementPDF.
SelectionToolbar:
- "Download failed" from onExportFailed. This also fixes a bug. On wide layouts the toolbar unmounts after a CSV export starts, so the inline modal never appeared when the export failed. The global modal does not depend on the toolbar staying mounted.
- "You appear to be offline": same text as the already-migrated MoneyReportHeaderModals.

Removed the old visibility state, close handlers, emptyReportsCount, and the related return fields. SearchBulkActionsButton.tsx no longer imports DecisionModal. The ProcessMoneyReportHoldMenu block in SelectionToolbar is left for Batch 3.

Behavior notes:

shouldHandleNavigationBack is now true, so browser Back closes these alerts.
Props are a snapshot taken when the modal opens, which is why each call site passes its own prompt.

Tests: the bulk-action hook tests now mock useDecisionModal (as useExportActionsTest does) and assert the title and prompt shown. A new test covers the empty-report prompt.

AI Tests (run by MelvinBot):

npm run typecheck: passed
ESLint on changed files: no new errors. The 11 remaining no-unsafe-type-assertion errors already exist on main.
oxfmt and npm run spell-changed: clean
React Compiler check: SearchBulkActionsButton and SelectionToolbar compile. useSearchBulkActions fails with the same errors on main (refs accessed during render), so this PR doesn't regress it.
Jest: useSearchBulkActionsPayTest, useSearchBulkActionsDownloadReceiptsTest, useSearchBulkActionsDownloadPDFTest, useSearchBulkActionsExportTest, and SearchBulkActionsButtonTest passed (114 tests). The full Jest suite and Storybook smoke test were not run locally.
Manual checks: web passed, except closing an alert with browser Back, which wasn't tested. On Android, the selection-toolbar Export offline alert got stuck and couldn't be closed. See Screenshots/Videos.

Fixed Issues

$ #102976
PROPOSAL:

Tests

Sign in with an account that has a workspace, 2 or more unreported expenses, an expense report with 2 or more expenses, and an empty report (no expenses).
Go to Account > Troubleshoot and turn on Force offline (or turn off the device network).
Go to Search > Expenses, select one or more expenses, open the bulk-actions dropdown, and choose Export > any CSV template (for example, Basic export).
Verify a "You appear to be offline." alert appears with the prompt "You can't take this action right now." and a "Got it" button.
Press browser Back (web) or the hardware Back button (Android). Verify the alert closes and you stay on Search with the selection kept.
Go to Search > Reports, select a report, and choose Download report from the bulk-actions dropdown.
Verify the same offline alert appears, and clicking "Got it" closes it.
Open the expense report with 2 or more expenses. Select the expenses (long-press on mobile), then choose More > Export > any CSV template from the selection toolbar.
Verify the same offline alert appears and clicking "Got it" closes it. Verify the report still responds to taps and scrolling after the alert closes.
Turn off Force offline (or turn the network back on).
Go to Search > Reports, select only the empty report, and choose Export > Basic export.
Verify a "Download failed" alert appears with the message "You can't export an empty report." and not the generic "Your download couldn't be completed. Please try again later." text. Click "Got it" and verify it closes.
Verify that no errors appear in the JS console

Offline tests

Turn on Force offline in Account > Troubleshoot (or turn off the device network).
In Search > Expenses, select expenses and choose Export > any CSV template. Verify the "You appear to be offline." alert appears and closes with "Got it" and with Back.
In Search > Reports, select a report and choose Download report. Verify the same offline alert appears and closes.
In an expense report, select 2 or more expenses and choose More > Export > any CSV template from the selection toolbar. Verify the same offline alert appears and closes, and the report still responds afterward.

QA Steps

Same as Tests, on staging. For the offline steps, use Force offline in Account > Troubleshoot or turn off the device network.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Tested by MelvinBot on an Android emulator (standalone NewDot) at commit 0a22005. Recording · Run

⚠️ Tests step 9 failed: the selection-toolbar Export offline alert appeared, but "Got it" and hardware Back stopped responding. It stayed stuck after reconnecting. The Search bulk-action alerts worked.

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Tested by MelvinBot on web (Chrome, dev build) at commit 0a22005. Recording · Run

Every alert showed the right text and closed with "Got it". Tests step 5 (browser Back) was not tested because the test tool can't press Back.

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot · 2026-10-09T07:08:22Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-migrateSearchBulkActionsDecisionModals
git checkout -b claude-migrateSearchBulkActionsDecisionModals upstream/claude-migrateSearchBulkActionsDecisionModals
git push -u origin claude-migrateSearchBulkActionsDecisionModals

Then you can close this PR and open a new one from your fork.

codecov · 2026-10-09T07:11:27Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
.../MoneyRequestReportView/SelectionToolbar/index.tsx	`71.59% <100.00%> (-3.66%)`	⬇️
src/components/Search/SearchBulkActionsButton.tsx	`91.25% <100.00%> (-1.15%)`	⬇️
src/hooks/useSelectedTransactionsActions.ts	`79.56% <ø> (ø)`
src/hooks/useSearchBulkActions.ts	`80.75% <68.75%> (+0.53%)`	⬆️
... and 72 files with indirect coverage changes

MelvinBot · 2026-10-09T07:32:33Z

🤖 Android test steps verification results: ❌ fail

The offline alerts from Search bulk Export and Download report work, but the offline alert opened from the report SelectionToolbar Export became stuck and blocked all input, even after reconnecting. The PR's Tests section is still a TODO, so I derived these steps from the PR description.

Step	Status
1. Search > Expenses: select an item, go offline, choose Export > CSV template. The "You appear to be offline." alert appears with a confirm button. Selected 1 expense, turned on airplane mode, chose Export > Current view. The alert showed the title "You appear to be offline.", the prompt "You can't take this action right now.", and a "Got it" button.	✅
2. Android hardware Back closes the alert and the app stays on Search. Back closed the alert. The app returned to Search > Expenses with 1 item still selected. No crash.	✅
3. Search > Reports: select a report, choose Download report. The same offline alert appears and its confirm button closes it. The alert appeared right away. Tapping "Got it" closed it and returned to the report list.	✅
4. Inside a report with 2 expenses: select both expenses, choose Export > CSV template from the SelectionToolbar. The same offline alert appears and can be closed. The alert showed the correct title, prompt, and button. Tapping "Got it" did not close it. Hardware Back did nothing. It stayed stuck after turning airplane mode off and waiting more than 90 seconds.	❌
5. Online, Search > Reports: select only an empty report, choose Export > CSV template. A "Download failed" alert shows the empty-report message. Not reached. The app stayed frozen after step 4, and the tester could not relaunch the session.	❌
6. No red-box error, crash, or stuck overlay appears in any flow. No red-box error appeared, but the step 4 alert froze the UI. A separate, short freeze on the first Search Export attempt cleared once the network state caught up, so it was likely caused by toggling airplane mode on the emulator.	❌

view run · view recording

MelvinBot · 2026-10-09T07:50:27Z

🤖 Web test steps verification results: ⚠️ partial

The offline and empty-report "Download failed" alerts work on web in Search bulk actions and the report selection toolbar, including the selection-toolbar Export that froze on Android. I could not test closing an alert with the browser Back button because the web test tool can't press Back. The PR's Tests section is still a TODO, so I derived these steps from the PR description.

Step	Status
1. Search > Expenses: select an item, go offline, choose Export > CSV template. The "You appear to be offline." alert appears with a confirm button. With Troubleshoot > Force offline on, chose Export > Basic export. The alert showed the title "You appear to be offline.", the prompt "You can't take this action right now.", and a "Got it" button.	✅
2. Browser Back closes the alert and the app stays on Search. Not tested. The web test tool has no browser Back action (it returned UNSUPPORTED_OPERATION). The alert's confirm button closed it in steps 1, 3, 4, and 5.	❌
3. Search > Reports: select a report, choose Download report. The same offline alert appears and its confirm button closes it. The same alert appeared. Clicking "Got it" closed it, and the app stayed on the Reports list.	✅
4. Inside a report with 2 expenses: select both expenses, choose Export > CSV template from the selection toolbar. The same offline alert appears and its confirm button closes it. Chose More > Export > Basic export with both expenses selected. The same alert appeared. Clicking "Got it" closed it, and the app stayed on the report with both expenses still selected.	✅
5. Online, Search > Reports: select only an empty report, choose Export > CSV template. A "Download failed" alert shows the empty-report message. With Force offline off, chose Export > Basic export on the $0.00 empty report. The alert showed the title "Download failed" and the message "You can't export an empty report." instead of the generic text. Clicking "Got it" closed it.	✅
6. No new JS console errors, crash, or stuck overlay appears in any flow. No crash or stuck overlay appeared, and every alert closed. All network responses returned status 200. The web test tool can't read the JS console, so this result is based on app behavior and network traffic.	✅

view run · view recording

ZhenjaHorbach · 2026-10-12T09:02:21Z

@MelvinBot
Complete author checklist and add test cases

MelvinBot · 2026-10-12T09:09:00Z

I updated the PR description. It now has Tests, Offline tests, and QA steps, plus the web and Android screenshots and recordings from my earlier test runs on commit 0a22005.

Still open before this is ready for review:

Android bug: the offline alert from the report selection toolbar's Export (Tests step 9) can't be closed on Android. It stayed stuck after reconnecting. The same flow works on web. This may be a timing problem, because the alert opens while the dropdown menu is still closing. I haven't confirmed that cause.
Checklist items I left unchecked because nobody has done them yet:
- High Traffic account test
- Screenshots for all platforms (iOS and mWeb are missing)
- Tests passing on all platforms
- No console errors (my test tool can't read the console)
- Testing other affected components

What I checked and why

Done: Fixed Issues link, test steps (Tests, Offline, QA, and failure cases), offline testing, and unit tests.
Copy and code pattern: checked because the PR adds no new copy and follows the agreed useDecisionModal migration.
Checked as not applicable: assets, message editing, generic components, Storybook, deeplinks, UI and form styling, the accessibility block (the alerts look the same as before), and the main-merge retest.
MacOS: Chrome: left unchecked because step 5 (closing an alert with browser Back) wasn't tested.

view run

ZhenjaHorbach · 2026-10-12T09:39:55Z

Reviewer Checklist

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-10-14.at.11.31.37.mov

Screen.Recording.2026-10-14.at.11.32.13.mov

Screen.Recording.2026-10-14.at.11.32.51.mov

Android: mWeb Chrome

Screen.Recording.2026-10-14.at.11.31.37.mov

Screen.Recording.2026-10-14.at.11.32.13.mov

Screen.Recording.2026-10-14.at.11.32.51.mov

iOS: HybridApp

Screen.Recording.2026-10-14.at.11.43.53.mov

Uploading Screen Recording 2026-10-14 at 11.44.44.mov…

iOS: mWeb Safari

Screen.Recording.2026-10-14.at.11.25.09.mov

Screen.Recording.2026-10-14.at.11.25.41.mov

Screen.Recording.2026-10-14.at.11.26.24.mov

MacOS: Chrome / Safari

Screen.Recording.2026-10-14.at.11.20.58.mov

Screen.Recording.2026-10-14.at.11.21.05.mov

Screen.Recording.2026-10-14.at.11.21.14.mov

Screen.Recording.2026-10-14.at.11.21.28.mov

Screen.Recording.2026-10-14.at.11.21.48.mov

Screen.Recording.2026-10-14.at.11.22.07.mov

ZhenjaHorbach · 2026-10-14T08:25:59Z

@MelvinBot
Fix conflicts

Keep main's removal of the offline guard on bulk Remove hold, and update the new offline unhold test to assert via the useDecisionModal mock. Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot · 2026-10-14T08:38:54Z

I fixed the conflicts by merging main into this branch. The PR is now mergeable (a77a7dc).

src/hooks/useSearchBulkActions.ts: I kept main's change from Show Remove hold in Search bulk actions while offline. It removes the offline guard on bulk Remove hold, so that handler no longer calls showOfflineModal().
tests/unit/hooks/useSearchBulkActionsTest.ts: main added a test that checks isOfflineModalVisible, which this PR removes. I mocked useDecisionModal and changed the test to check that showDecisionModal is not called.

I couldn't run Jest, lint, or typecheck locally. They fail at startup in my environment, including on unrelated test suites. CI will run them on the new commit.

MelvinBot · 2026-10-14T08:45:45Z

The failing check is unrelated to this PR, so I didn't push a fix.

Analysis: test (job 7) failed on one test: IOURequestStepConfirmationPageTest › Report selection guard tests › should use the transaction report when it is allowed, even if it differs from the route. This PR doesn't touch that test or the IOU confirmation page. The test is flaky.

Evidence:

On this branch (a77a7dc), the full test file passes locally: 39 of 39 tests.
The same test failed today on unrelated PRs, including Make onboarding "Back" caret header consistent (sticky) and a reusable component and Hide Pay and Unapprove while a cancelled payment is processing.
All other Jest tests passed: 3,358 passed, 1 failed.

Check independent approval needs a reviewer approval, not a code change. Re-run test (job 7) to clear it.

view run

MelvinBot · 2026-10-14T08:49:58Z

Nothing has changed since my earlier comment. The failing check is still unrelated to this PR, so I didn't push a fix.

Analysis: test (job 7) failed on one flaky test: IOURequestStepConfirmationPageTest › Report selection guard tests › should use the transaction report when it is allowed, even if it differs from the route. This PR doesn't touch that test or the IOU confirmation page.

Evidence:

On this branch (a77a7dc), the full test file passes locally: 39 of 39 tests.
The same test failed today on unrelated PRs, including Make onboarding "Back" caret header consistent (sticky) and a reusable component and Hide Pay and Unapprove while a cancelled payment is processing.

Next step: Re-run the failed test (job 7) job. I tried, but my token can't re-run Actions jobs. Check independent approval clears once a reviewer approves.

view run

ZhenjaHorbach · 2026-10-14T09:47:51Z

@MelvinBot
Open the PR

MelvinBot · 2026-10-14T09:51:56Z

I marked this PR as ready for review.

melvin-bot · 2026-10-14T09:51:59Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-14T09:52:03Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-14T09:58:33.226503Z	`a77a7dc`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a77a7dca94

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-10-14T09:58:30Z

+    const {showDecisionModal} = useDecisionModal();
+
+    const showOfflineModal = () => {
+        showDecisionModal({


Delay the global alert until the export popover closes

On Android, when an offline user selects an export option from the report selection toolbar, this synchronously presents the global native modal before ButtonWithDropdownMenu finishes dismissing its popover. The overlapping modals leave the alert stuck: neither “Got it” nor hardware Back responds, and the report remains blocked. Present this alert from the popover's post-dismiss callback or otherwise defer it until the originating menu has fully closed.

Useful? React with 👍 / 👎.

@MelvinBot
Can't reproduce
But makes sense, and we can add these changes just in case

diff --git a/src/hooks/useSelectedTransactionsActions.ts b/src/hooks/useSelectedTransactionsActions.ts index bd88e40df03f40..904ab27f5107ca 100644 --- a/src/hooks/useSelectedTransactionsActions.ts +++ b/src/hooks/useSelectedTransactionsActions.ts @@ -466,6 +466,7 @@ function useSelectedTransactionsActions({ clearSelectedTransactions(true); } : () => beginExportWithTemplate(template.templateName, template.type, selectedTransactionIDs, template.name, template.policyID), + shouldCallAfterModalHide: true, addSeparatorBefore, }; };

MelvinBot · 2026-10-14T10:03:54Z

Nothing has changed since my last check. The only real failure is still a flaky test that this PR doesn't touch, so there's no code to fix. Please re-run test (job 7). I tried, but my token can't re-run jobs (HTTP 403).

Evidence:

The PR head is still a77a7dc. The failure is the same job run as before, and it hasn't been re-run.
The failing test is IOURequestStepConfirmationPageTest › Report selection guard tests › should use the transaction report when it is allowed, even if it differs from the route. It passes locally on this branch.
The same test group also fails on main and on unrelated PRs. Investigate workflow job failing on main: test / test (job 7) tracks the failure on main.

Check independent approval needs a reviewer approval, not a code change.

view run

ZhenjaHorbach · 2026-10-14T10:08:06Z

@MelvinBot
Add these changes

diff --git a/src/hooks/useSelectedTransactionsActions.ts b/src/hooks/useSelectedTransactionsActions.ts
index bd88e40df03f40..904ab27f5107ca 100644
--- a/src/hooks/useSelectedTransactionsActions.ts
+++ b/src/hooks/useSelectedTransactionsActions.ts
@@ -466,6 +466,7 @@ function useSelectedTransactionsActions({
                               clearSelectedTransactions(true);
                           }
                         : () => beginExportWithTemplate(template.templateName, template.type, selectedTransactionIDs, template.name, template.policyID),
+                    shouldCallAfterModalHide: true,
                     addSeparatorBefore,
                 };
             };

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot · 2026-10-14T10:09:18Z

I added shouldCallAfterModalHide: true to the export menu items in src/hooks/useSelectedTransactionsActions.ts:469 and pushed it in 931c484. The file now matches your diff exactly. It applies to both the basic CSV export and template exports.

melvin-bot · 2026-10-14T10:09:21Z

@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-10-14T10:11:34Z

Nothing has changed since my last comment. The only real failure is still the flaky IOURequestStepConfirmationPageTest test in test (job 7), so there's no code fix to push.

What you need to do: Re-run the failed test (job 7) job from the Jest run. I tried to re-run it, but my token can't re-run jobs (HTTP 403).

Why it's unrelated:

This PR doesn't touch that test or the IOU confirmation page.
The test passes locally on this branch (a77a7dc).
The same test failed today on unrelated PRs.
No fix for the test has landed on main since yesterday.

Check independent approval needs a reviewer's approval, not a code change.

view run

MelvinBot · 2026-10-14T10:13:12Z

This change is already on the PR, so I didn't add a new commit.

Commit 931c484 ("Run export template actions after the popover menu hides") adds shouldCallAfterModalHide: true at src/hooks/useSelectedTransactionsActions.ts:469. It is the current head of the branch, and its diff matches the one you posted.

ZhenjaHorbach · 2026-10-14T10:13:45Z

TS issue is not from this PR

roryabraham · 2026-10-14T14:47:08Z

ts issue is unrelated

OSBotify · 2026-10-14T14:52:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-14T14:56:34Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-14T15:01:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103554.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c00d280-a62bb28-45d1f24786c72dfd1088f8ad13c2b4a54a679f04/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c00d280-a62bb28-ae17351bda7f867973a4e02cfcbcc0911403f8d2/index.html

Web 🕸️
https://103554.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-15T17:03:30Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-15T17:10:33Z

No help site update needed. This PR moves existing offline and "Download failed" alerts to the shared decision modal, which only changes how in-app error messages are shown, so no help article becomes incorrect.

view run

OSBotify · 2026-10-15T22:09:23Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.12-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-15T22:15:39Z

No help site update needed. This PR moves existing offline and "Download failed" alerts to the shared decision modal, which only changes how in-app error messages are shown, so no help article becomes incorrect.

view run

OSBotify · 2026-10-16T11:54:39Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot and others added 2 commits October 9, 2026 07:02

Use useDecisionModal for Search bulk actions and SelectionToolbar alerts

369f840

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

Separate decision modal helpers from the hooks below them

0a22005

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot assigned ZhenjaHorbach Oct 9, 2026

MelvinBot requested a review from a team October 9, 2026 07:08

melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Oct 9, 2026

MelvinBot mentioned this pull request Oct 9, 2026

[Due for payment 2026-10-23] [$175] [Batch 2] Refactor DecisionModal usage to useDecisionModal in Search bulk actions and SelectionToolbar alerts (5 modals) #102976

Closed

MelvinBot mentioned this pull request Oct 12, 2026

[Due for payment 2026-10-28] [$175] Migrate the Expensify Card statement PDF modal to the global modal stack #103508

Closed

MelvinBot mentioned this pull request Oct 12, 2026

Move the Expensify Card statement PDF modal to the global modal stack #103708

Merged

36 of 38 tasks

Merge main into claude-migrateSearchBulkActionsDecisionModals

a77a7dc

Keep main's removal of the offline guard on bulk Remove hold, and update the new offline unhold test to assert via the useDecisionModal mock. Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot mentioned this pull request Oct 14, 2026

Let ArrowUp reach the search input on the workspace invite member list #103955

Merged

38 tasks done

MelvinBot marked this pull request as ready for review October 14, 2026 09:51

MelvinBot requested a review from a team as a code owner October 14, 2026 09:51

melvin-bot Bot requested review from ZhenjaHorbach and flaviadefaria and removed request for a team October 14, 2026 09:51

melvin-bot Bot removed the request for review from a team October 14, 2026 09:52

chatgpt-codex-connector Bot reviewed Oct 14, 2026

View reviewed changes

Run export template actions after the popover menu hides

931c484

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot requested a review from a team as a code owner October 14, 2026 10:09

melvin-bot Bot requested review from roryabraham and removed request for a team October 14, 2026 10:09

ZhenjaHorbach approved these changes Oct 14, 2026

View reviewed changes

roryabraham approved these changes Oct 14, 2026

View reviewed changes

roryabraham merged commit c00d280 into main Oct 14, 2026
42 of 44 checks passed

roryabraham deleted the claude-migrateSearchBulkActionsDecisionModals branch October 14, 2026 14:47

OSBotify mentioned this pull request Oct 15, 2026

Deploy Checklist: New Expensify 2026-10-15 #104123

Closed

81 tasks done

applause-bot Bot mentioned this pull request Oct 15, 2026

[Due for payment 2026-10-27] Web- Browser back button doesn't dismiss "You appear to be offline" alert #104154

Closed

1 of 7 tasks

MelvinBot mentioned this pull request Oct 20, 2026

Consolidate DecisionModals into a global component #80285

Open

Conversation

MelvinBot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Oct 9, 2026

Uh oh!

codecov Bot commented Oct 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MelvinBot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Oct 12, 2026

Uh oh!

MelvinBot commented Oct 12, 2026

Uh oh!

ZhenjaHorbach commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Oct 14, 2026

Uh oh!

MelvinBot commented Oct 14, 2026

Uh oh!

MelvinBot commented Oct 14, 2026

Uh oh!

MelvinBot commented Oct 14, 2026

Uh oh!

ZhenjaHorbach commented Oct 14, 2026

Uh oh!

MelvinBot commented Oct 14, 2026

Uh oh!

melvin-bot Bot commented Oct 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Oct 14, 2026

Uh oh!

ZhenjaHorbach commented Oct 14, 2026

Uh oh!

MelvinBot commented Oct 14, 2026

Uh oh!

melvin-bot Bot commented Oct 14, 2026

Uh oh!

MelvinBot commented Oct 14, 2026

Uh oh!

MelvinBot commented Oct 14, 2026

Uh oh!

ZhenjaHorbach commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roryabraham commented Oct 14, 2026

Uh oh!

Uh oh!

OSBotify commented Oct 14, 2026

MelvinBot commented Oct 9, 2026 •

edited

Loading

codecov Bot commented Oct 9, 2026 •

edited by github-actions Bot

Loading

MelvinBot commented Oct 9, 2026 •

edited

Loading

MelvinBot commented Oct 9, 2026 •

edited

Loading

ZhenjaHorbach commented Oct 12, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 14, 2026 •

edited

Loading

ZhenjaHorbach Oct 14, 2026 •

edited

Loading

ZhenjaHorbach commented Oct 14, 2026 •

edited

Loading