Fix Onboarding modal does not appear until clearing cache by hungvu193 · Pull Request #103550 · Expensify/App

hungvu193 · 2026-10-09T05:51:49Z

Explanation of Change

Navigation.isValidateLoginFlow() reads navigationRef.getRootState() during render, so it isn't reactive. Previously, the isOnboardingCompleted === false part of the condition made AuthScreens re-render and re-check it once the onboarding NVP loaded.
This PR subscribes AuthScreens to navigation state with useRootNavigationState(Navigation.isValidateLoginFlow). The navigator gets registered as soon as the user leaves the validate login screen, while onboarding still doesn't open over it. Navigation.isValidateLoginFlow now takes the navigation state as a parameter so it can be used as the selector.

Fixed Issues

$ #103545
PROPOSAL:

Tests

Uninstall the app (or clear all app data) so the next launch is a fresh install.
On the sign-in page, enter a brand-new email address that has never been used with Expensify.
Open the magic link from the sign-in email on the same device.
Verify the onboarding flow is displayed after signing in, without clearing cache or restarting the app.
Sign out, clear app data, and repeat steps 2-4 with another brand-new email, this time signing in by entering the magic code instead of opening the link.
Verify the onboarding flow is displayed after signing in.
Sign out and sign in with an account that has already completed onboarding.
Verify onboarding is not displayed and the app lands on the usual home screen.

Verify that no errors appear in the JS console

Offline tests

N/A. This change only affects when the onboarding navigator is registered after navigation state changes; sign-in requires a network connection.

QA Steps

Freshly install the app.
Sign in with a brand-new Gmail account.
Verify the onboarding flow is displayed right after signing in, without clearing cache.
Repeat steps 1-3 signing in through the magic link from the sign-in email.
Verify the onboarding flow is displayed after signing in.
Sign in with an account that has already completed onboarding.
Verify onboarding is not displayed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-10-09.at.12.32.13.mov

iOS: mWeb Safari

Screen.Recording.2026-10-09.at.12.57.54.mov

MacOS: Chrome / Safari

Screen.Recording.2026-10-09.at.12.55.11.mov

…ogin screen

melvin-bot · 2026-10-09T05:52:44Z

@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-09T05:52:49Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-09T06:12:40.388592Z	`b017bbf`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

hungvu193 · 2026-10-09T05:53:33Z

@marufsharifi Sorry for the ping. This is a DB, @abzokhattab will handle it

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b017bbf0f8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…en is pushed over it

abzokhattab · 2026-10-09T10:45:49Z

reviewing

abzokhattab · 2026-10-09T11:41:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-10-09.at.13.45.22.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-10-09.at.13.26.54.mov

iOS: mWeb Safari

Screen.Recording.2026-10-09.at.13.30.41.mov

MacOS: Chrome / Safari

Screen.Recording.2026-10-09.at.13.20.45.mov

abzokhattab

LGTM

joekaufmanexpensify

Good for product

OSBotify · 2026-10-09T14:24:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Fix Onboarding modal does not appear until clearing cache (cherry picked from commit 693cab0) (cherry-picked to staging by puneetlath)

github-actions · 2026-10-09T14:41:55Z

🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-09T14:46:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103550.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-693cab0-a7c42c1-b53661bfe3107ded60ce70613d75cb5ce9512581/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-693cab0-a7c42c1-d386086f222ee2dc930c4120e81ce36c70ae9331/index.html

Web 🕸️
https://103550.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-09T14:51:54Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.5.6-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-10-09T14:56:09Z

No help site update is needed. This bug fix restores the expected behavior: new accounts see onboarding right after they sign in. It only changes internal navigation code and does not add, rename or remove anything an article describes.

This reverts commit 693cab0, reversing changes made to 8679ca4.

OSBotify · 2026-10-09T20:32:48Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Register the onboarding navigator once the user leaves the validate l…

b017bbf

…ogin screen

melvin-bot Bot assigned hungvu193 Oct 9, 2026

hungvu193 marked this pull request as ready for review October 9, 2026 05:52

hungvu193 requested review from a team as code owners October 9, 2026 05:52

melvin-bot Bot requested review from joekaufmanexpensify and marufsharifi and removed request for a team October 9, 2026 05:52

melvin-bot Bot removed the request for review from a team October 9, 2026 05:52

hungvu193 requested review from abzokhattab and removed request for marufsharifi October 9, 2026 05:53

chatgpt-codex-connector Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreens.tsx Outdated

Keep the onboarding navigator registered when the validate login scre…

66ccee6

…en is pushed over it

abzokhattab approved these changes Oct 9, 2026

View reviewed changes

melvin-bot Bot requested review from carlosmiceli and iwiznia October 9, 2026 11:46

joekaufmanexpensify approved these changes Oct 9, 2026

View reviewed changes

carlosmiceli approved these changes Oct 9, 2026

View reviewed changes

carlosmiceli merged commit 693cab0 into Expensify:main Oct 9, 2026
36 of 38 checks passed

OSBotify pushed a commit that referenced this pull request Oct 9, 2026

Merge pull request #103550 from hungvu193/fix-103545

98d44e0

Fix Onboarding modal does not appear until clearing cache (cherry picked from commit 693cab0) (cherry-picked to staging by puneetlath)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 9, 2026

OSBotify mentioned this pull request Oct 9, 2026

Deploy Checklist: New Expensify 2026-10-08 #103502

Closed

90 tasks done

This was referenced Oct 9, 2026

Revert "Fix Onboarding modal does not appear until clearing cache" #103644

Closed

Revert "Fix Onboarding modal does not appear until clearing cache" #103645

Open

Revert join-workspace onboarding changes #103649

Merged

allgandalf pushed a commit to allgandalf/App that referenced this pull request Oct 9, 2026

Revert "Merge pull request Expensify#103550 from hungvu193/fix-103545"

9d27184

This reverts commit 693cab0, reversing changes made to 8679ca4.

melvin-bot Bot mentioned this pull request Oct 9, 2026

Onboarding-Onboarding modal does not appear until clearing cache #103545

Open

1 of 7 tasks

Conversation

hungvu193 commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

hungvu193 commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

abzokhattab commented Oct 9, 2026

Uh oh!

abzokhattab commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

OSBotify commented Oct 9, 2026

Uh oh!

MelvinBot commented Oct 9, 2026

Uh oh!

OSBotify commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hungvu193 commented Oct 9, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading

abzokhattab commented Oct 9, 2026 •

edited

Loading