Skip to content

[No QA] Fix ESLint errors in popover save callbacks #103540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
francoisl wants to merge 1 commit into from
Closed

[No QA] Fix ESLint errors in popover save callbacks #103540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/EditableCell/usePopoverEditState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import type {ValueOf} from 'type-fest';

import {useEffect, useRef, useState} from 'react';

import type {InlineEditSaveResult} from './types';

type PopoverPosition = {
horizontal: number;
vertical: number;
Expand All @@ -21,7 +23,7 @@ type UsePopoverEditStateOptions = {
value?: unknown;

/** Callback when the value is saved */
onSave?: (value: unknown) => void;
onSave?: (value: unknown) => InlineEditSaveResult;

/** Custom equality function. If not provided, Object.is is used. */
isEqual?: (newValue: unknown, originalValue: unknown) => boolean;
Expand Down Expand Up @@ -116,7 +118,7 @@ function usePopoverEditStateImpl({
type UsePopoverEditStateOptionsGeneric<T> = {
canEdit: boolean | undefined;
value?: T;
onSave?: (value: T) => void;
onSave?: (value: T) => InlineEditSaveResult;
isEqual?: (newValue: T, originalValue: T) => boolean;
popoverHeight?: number;
padding?: number;
Expand Down
Loading