Repository navigation
Conversation
Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://ad29851c.helpdot.pages.dev ⚡️ Updated articles: |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
|
@garrettmknight Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a single short paragraph to Join-your-company's-workspace.md describing how users can join a workspace during sign-up by selecting Join my company workspace on the onboarding screen, as an alternative to the existing admin-invite flow. The change is small, well-scoped, and consistent with the article single-workflow focus. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: The change is a single added paragraph, so detailed inline commentary is not warranted beyond this summary. |
Explanation of Change
Help site update for Add the join-workspace onboarding intent and Concierge follow up tasks.
New feature: that PR adds a Join my company workspace option to the What do you want to do today? onboarding screen. It isn't behind a beta, so all new users see it. After they add and verify a work email, Expensify shows the workspaces at their company that they can join.
Change: Join Your Company's Workspace only describes joining through an admin invite:
I added one short paragraph after the invite steps that tells users they can select Join my company workspace during sign-up instead, then click Join now or Ask to join. There are no new sections or FAQs.
The labels What do you want to do today? and Join my company workspace were confirmed in the live web app. Join now and Ask to join match the English strings in
src/languages/en.ts.@carlosmiceli, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #99833
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
UI label check (web), not a test of the docs change: