Skip to content

[No QA] Docs updates for E/A#99833 Add Join my company workspace option to help article - #103519

Open
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsJoinMyCompanyWorkspace
Open

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsJoinMyCompanyWorkspace

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site update for Add the join-workspace onboarding intent and Concierge follow up tasks.

New feature: that PR adds a Join my company workspace option to the What do you want to do today? onboarding screen. It isn't behind a beta, so all new users see it. After they add and verify a work email, Expensify shows the workspaces at their company that they can join.

Change: Join Your Company's Workspace only describes joining through an admin invite:

Ask one of your company's Expensify workspace admins to send you an invite using these steps:

I added one short paragraph after the invite steps that tells users they can select Join my company workspace during sign-up instead, then click Join now or Ask to join. There are no new sections or FAQs.

The labels What do you want to do today? and Join my company workspace were confirmed in the live web app. Join now and Ask to join match the English strings in src/languages/en.ts.

@carlosmiceli, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #99833
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

UI label check (web), not a test of the docs change:

Onboarding purpose screen showing Join my company workspace Work email screen after selecting Join my company workspace

Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 8, 2026 19:57
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 8, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#99833 Add Join my company workspace option to help article [No QA] Docs updates for E/A#99833 Add Join my company workspace option to help article Oct 8, 2026
@OSBotify

OSBotify commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://ad29851c.helpdot.pages.dev ⚡️

Updated articles:

@carlosmiceli
carlosmiceli marked this pull request as ready for review October 8, 2026 22:29
@melvin-bot

melvin-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @garrettmknight

@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team October 8, 2026 22:29
@melvin-bot

melvin-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

@garrettmknight Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T22:39:44.538037Z f8accf8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single short paragraph to Join-your-company's-workspace.md describing how users can join a workspace during sign-up by selecting Join my company workspace on the onboarding screen, as an alternative to the existing admin-invite flow. The change is small, well-scoped, and consistent with the article single-workflow focus.

Scores Summary

  • Readability: 9/10 - Clear, concise, scannable sentence. Logical flow from the alternative entry point to the follow-up actions. Correctly placed after the invite steps as an explanatory paragraph (not inside numbered steps), per authoring guidelines.
  • AI Readiness: 9/10 - Uses full, UI-exact feature names (Join my company workspace, What do you want to do today?) that match real search intent. No new headings or metadata introduced, so existing heading hierarchy and YAML frontmatter remain intact.
  • Style Compliance: 9/10 - UI labels correctly bolded in sentence case with no quotation marks, matching the Button Naming and Section Reference standards. The PR confirms labels were verified against the live web app and the Join now / Ask to join strings against src/languages/en.ts.

Key Findings

  • The new paragraph is placed correctly as explanatory prose after the procedural steps, respecting the rule against embedding conditional/alternative actions inside numbered steps.
  • UI terminology is exact and bold-formatted; no paraphrasing, synonyms, or prohibited vague navigation phrases.
  • The change stays within the article single workflow and does not expand scope or introduce multi-feature coverage.
  • Minor: the conditional phrasing (Click Join now, or Ask to join if the workspace needs admin approval) is acceptable here because it reflects state-dependent product behavior, not platform-specific navigation (which would require split instructions).

Recommendations

  • No blocking issues. The author should complete the empty Tests / QA Steps sections in the PR body before marking ready for review (currently placeholder TODOs).
  • Optional: consider a short inline cross-link to a getting-started / onboarding article when describing the What do you want to do today? screen, if a suitable dedicated article exists, to reinforce the prerequisite sign-up context.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Join-your-company's-workspace.md - Approved. One added explanatory paragraph; compliant with naming, authoring, and template governance.

Note: The change is a single added paragraph, so detailed inline commentary is not warranted beyond this summary.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants