Repository navigation
Conversation
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
|
@MelvinBot Mark this as ready |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🤖 Done. I marked this PR as ready for review. |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
|
@garrettmknight Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| 3. Select **Settings**. | ||
| 4. Enable **Auto-update government rates**. | ||
| 4. Enable **Auto-update government rate**. | ||
| 5. If the workspace default currency is EUR, select a country and click **Save**. |
There was a problem hiding this comment.
UI referencing / consistency: "select a country" is vague and doesn't match the exact UI control, which this article later refers to as Country (line 107). Per HELPSITE_NAMING_CONVENTIONS (Core UI Referencing Rules: use the exact label, don't generalize), reference the control consistently, e.g. "select a country from Country and click Save."
| When **Auto-update government rate** is enabled, Expensify adds a new effective-dated distance rate when a supported government publishes a new rate. This means admins don't need to manually update the standard rate each time it changes. | ||
|
|
||
| Expensify uses the workspace default currency to determine which government publishes the rate: USD for the United States, CAD for Canada, GBP for Great Britain, AUD for Australia, NOK for Norway, SEK for Sweden, and ZAR for South Africa. | ||
| Expensify uses the workspace default currency to determine which government publishes the rate: USD for the United States, CAD for Canada, GBP for Great Britain, AUD for Australia, NOK for Norway, SEK for Sweden, and ZAR for South Africa. Because several countries use EUR, workspaces with a default currency of EUR select the country instead: Austria, Belgium, Finland, Germany, the Netherlands, Portugal, or Spain. |
There was a problem hiding this comment.
UI referencing: "select the country instead" generalizes the UI control. Per HELPSITE_NAMING_CONVENTIONS, reference the exact label (the Country selector shown under Auto-update government rate) rather than a generic "the country."
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
Explanation of Change
Updates the Set Distance Rates help article for the changes in [Payment due
@jayeshmangwani] Add country selection for EUR auto-update government rates.New feature: EUR workspaces can now turn on government rate auto-updates by selecting a country (Austria, Belgium, Finland, Germany, the Netherlands, Portugal, or Spain).
Sentences that became incorrect:
@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #101809
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari