remove the last two report metadata Onyx fallbacks from the ReportUtils by daledah · Pull Request #103434 · Expensify/App

daledah · 2026-10-08T08:52:49Z

Explanation of Change

Fixed Issues

$ #66421
PROPOSAL:

Tests

Open a group chat with at least 3 members.
Open the group chat header > Members.
Turn on Offline mode.
Select one member and remove them
Verify that: they stay listed with a pending (greyed out) state.
Go back and tap Invite.
Verify the member pending removal is offered in the list and can be selected again.
Turn Offline mode off and verify the list stays correct after the removal goes through.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-10-08.at.15.53.31.mov

chatgpt-codex-connector · 2026-10-08T08:54:10Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

melvin-bot · 2026-10-08T08:54:14Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-10-08T08:57:36Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ReportWelcomeText.tsx	`96.72% <100.00%> (ø)`
src/libs/DebugUtils.ts	`68.71% <100.00%> (ø)`
src/libs/OptionsListUtils/index.ts	`91.80% <100.00%> (ø)`
src/libs/ReportAlternateTextUtils.ts	`92.12% <100.00%> (ø)`
src/libs/ReportUtils.ts	`88.57% <100.00%> (+0.04%)`	⬆️
src/libs/SidebarUtils.ts	`93.15% <100.00%> (ø)`
src/libs/actions/Task.ts	`67.03% <100.00%> (ø)`
src/pages/Debug/Report/DebugReportActions.tsx	`89.13% <100.00%> (ø)`
src/pages/ShareCodePage.tsx	`80.28% <100.00%> (ø)`
src/pages/inbox/HeaderView.tsx	`94.24% <100.00%> (ø)`
... and 7 more
... and 13 files with indirect coverage changes

DylanDylann · 2026-10-14T08:47:34Z

 };

+const pendingExpenseActionSelector = (reportMetadata: OnyxEntry<ReportMetadata>): OnyxEntry<ReportMetadata> =>
+    reportMetadata ? {pendingExpenseAction: reportMetadata.pendingExpenseAction} : undefined;


Why do we need to put it into an object?

I kept it as an object to limit the size of this change, switching to a scalar would mean over 100 call sites across the chain. Happy to do it in a follow-up PR if you'd prefer.

Ok let's keep it now

DylanDylann · 2026-10-15T04:09:28Z

+        // Passing reportMetadata as undefined is intentional, this fallback only runs when reportAttributes has not
+        // precomputed `requiresAttention` yet, and threading it here means a param on every shouldReportBeInOptionList caller.


@daledah Could you explain in more detail why we should pass undefined here?

I looked into it again and you're right, this needs the real reportMetadata. Fixing it properly here would blow up the PR, so I'll do it in the next one.
For now I've brought back the fallback in getReasonAndReportActionThatRequiresAttention with a TODO, It'll be removed in that follow-up once every caller passes a real value.

DylanDylann · 2026-10-15T04:12:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-10-15.at.11.14.23.mov

JmillsExpensify · 2026-10-17T11:00:25Z

No product review required.

github-actions · 2026-10-19T18:26:26Z

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-19T18:31:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103434.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-efcb120-cc6833e-2db88b476e26734f35a2e11132c0c0371538df9a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-efcb120-cc6833e-5a6df867c0f17d22b68a0cdab983ffdbc586c4f5/index.html

Web 🕸️
https://103434.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-19T18:31:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-10-20T19:41:36Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.5.15-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-20T19:47:53Z

No help site update is needed. This PR is an internal refactor that passes report metadata to ReportUtils instead of reading it from Onyx fallbacks, and it doesn't change any feature, label, or workflow that a help article describes.

view run

OSBotify · 2026-10-21T19:30:26Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

remove the last two report metadata Onyx fallbacks from the ReportUtils

478e3a9

melvin-bot Bot assigned daledah Oct 8, 2026

daledah marked this pull request as ready for review October 8, 2026 08:54

daledah requested review from a team as code owners October 8, 2026 08:54

melvin-bot Bot requested review from DylanDylann and JmillsExpensify and removed request for a team October 8, 2026 08:54

melvin-bot Bot removed the request for review from a team October 8, 2026 08:54

daledah added 2 commits October 12, 2026 15:21

resolve conflict

766bc95

fix tests

6cd7b8f

DylanDylann reviewed Oct 14, 2026

View reviewed changes

daledah added 4 commits October 14, 2026 16:33

Merge branch 'main' into refactor/66421-5

cd6cd7c

address comments

420e055

rename variables

6bf5f66

Merge branch 'main' into refactor/66421-5

6a250d2

DylanDylann reviewed Oct 15, 2026

View reviewed changes

daledah added 3 commits October 15, 2026 15:32

address comment

d767a26

address comment

cafe862

Merge branch 'main' into refactor/66421-5

2b46911

DylanDylann approved these changes Oct 19, 2026

View reviewed changes

melvin-bot Bot requested a review from blimpich October 19, 2026 08:12

blimpich approved these changes Oct 19, 2026

View reviewed changes

blimpich merged commit efcb120 into Expensify:main Oct 19, 2026
35 of 37 checks passed

OSBotify mentioned this pull request Oct 20, 2026

Deploy Checklist: New Expensify 2026-10-20 #104495

Closed

81 tasks done

melvin-bot Bot mentioned this pull request Oct 21, 2026

[Partial Payment] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_METADATA in src/libs/ReportUtils.ts #66421

Open

		// Passing reportMetadata as undefined is intentional, this fallback only runs when reportAttributes has not
		// precomputed `requiresAttention` yet, and threading it here means a param on every shouldReportBeInOptionList caller.

Conversation

daledah commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot commented Oct 8, 2026

Uh oh!

melvin-bot Bot commented Oct 8, 2026

Uh oh!

codecov Bot commented Oct 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

daledah Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DylanDylann Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

daledah Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

JmillsExpensify commented Oct 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

OSBotify commented Oct 19, 2026

Uh oh!

OSBotify commented Oct 20, 2026

Uh oh!

MelvinBot commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

daledah commented Oct 8, 2026 •

edited

Loading

codecov Bot commented Oct 8, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Oct 15, 2026 •

edited

Loading