Repository navigation
[No QA] Add Zoho Books App constants, Onyx types, API parameters, and actions - #103429
Merged
Merged
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
nkdengineer
force-pushed
the
fix/103230
branch
from
October 8, 2026 08:18
befac6f to
f5fe1cb
Compare
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
nkdengineer
marked this pull request as ready for review
October 8, 2026 08:25
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
melvin-bot
Bot
requested review from
flaviadefaria and
truph01
and removed request for
a team and
flaviadefaria
October 8, 2026 08:25
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index d25584e2..a3f350e8 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7315,9 +7315,9 @@ Der Control-Tarif beginnt bei 9 $ pro aktivem Mitglied und Monat.`,
case CONST.POLICY.CONNECTIONS.NAME.RILLET:
return 'Rillet';
case CONST.POLICY.CONNECTIONS.NAME.DUALENTRY:
- return 'DualEntry';
+ return 'Doppelte Buchung';
case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
- return 'Campfire';
+ return 'Lagerfeuer';
case CONST.POLICY.CONNECTIONS.NAME.ZOHO_BOOKS:
return 'Zoho Books';
case CONST.POLICY.CONNECTIONS.NAME.BUSINESS_CENTRAL:
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 821c8ab6..136301b6 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -7120,9 +7120,9 @@ El plan Controlar empieza en 9 $ por miembro activo al mes.`,
case CONST.POLICY.CONNECTIONS.NAME.RILLET:
return 'Rillet';
case CONST.POLICY.CONNECTIONS.NAME.DUALENTRY:
- return 'DualEntry';
+ return 'Asiento doble';
case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
- return 'Campfire';
+ return 'Fogata';
case CONST.POLICY.CONNECTIONS.NAME.ZOHO_BOOKS:
return 'Zoho Books';
case CONST.POLICY.CONNECTIONS.NAME.BUSINESS_CENTRAL:
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 32bbac70..3dee13a7 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7333,7 +7333,7 @@ Le forfait Control commence à 9 $ par Membre actif et par mois.`,
case CONST.POLICY.CONNECTIONS.NAME.RILLET:
return 'Rillet';
case CONST.POLICY.CONNECTIONS.NAME.DUALENTRY:
- return 'DualEntry';
+ return 'SaisieDouble';
case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
return 'Campfire';
case CONST.POLICY.CONNECTIONS.NAME.ZOHO_BOOKS:
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 408e05ee..58d2f967 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7273,9 +7273,9 @@ Il piano Control parte da 9 $ al mese per ogni membro attivo.`,
case CONST.POLICY.CONNECTIONS.NAME.RILLET:
return 'Rillet';
case CONST.POLICY.CONNECTIONS.NAME.DUALENTRY:
- return 'DualEntry';
+ return 'Partita doppia';
case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
- return 'Campfire';
+ return 'Falò';
case CONST.POLICY.CONNECTIONS.NAME.ZOHO_BOOKS:
return 'Zoho Books';
case CONST.POLICY.CONNECTIONS.NAME.BUSINESS_CENTRAL:
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index d640880e..7254d824 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -7183,9 +7183,9 @@ Control プランは、アクティブメンバー1人あたり月額 $9 から
case CONST.POLICY.CONNECTIONS.NAME.RILLET:
return 'Rillet';
case CONST.POLICY.CONNECTIONS.NAME.DUALENTRY:
- return 'DualEntry';
+ return '複式仕訳';
case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
- return 'Campfire';
+ return 'キャンプファイヤー';
case CONST.POLICY.CONNECTIONS.NAME.ZOHO_BOOKS:
return 'Zoho Books';
case CONST.POLICY.CONNECTIONS.NAME.BUSINESS_CENTRAL:
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 4e2b8fb8..74e5c695 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -7257,9 +7257,9 @@ Het Control-abonnement begint bij $9 per actieve deelnemer per maand.`,
case CONST.POLICY.CONNECTIONS.NAME.RILLET:
return 'Rillet';
case CONST.POLICY.CONNECTIONS.NAME.DUALENTRY:
- return 'DualEntry';
+ return 'Dubbel boekhouden';
case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
- return 'Campfire';
+ return 'Kampvuur';
case CONST.POLICY.CONNECTIONS.NAME.ZOHO_BOOKS:
return 'Zoho Books';
case CONST.POLICY.CONNECTIONS.NAME.BUSINESS_CENTRAL:
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 960ab49b..57b44021 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -7281,9 +7281,9 @@ Plan Control zaczyna się od 9 USD za aktywnego członka miesięcznie.`,
case CONST.POLICY.CONNECTIONS.NAME.RILLET:
return 'Rillet';
case CONST.POLICY.CONNECTIONS.NAME.DUALENTRY:
- return 'DualEntry';
+ return 'Podwójny zapis';
case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
- return 'Campfire';
+ return 'Ognisko';
case CONST.POLICY.CONNECTIONS.NAME.ZOHO_BOOKS:
return 'Zoho Books';
case CONST.POLICY.CONNECTIONS.NAME.BUSINESS_CENTRAL:
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 577cbf5f..5186afa8 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -7259,9 +7259,9 @@ O plano Control começa em US$ 9 por membro ativo por mês.`,
case CONST.POLICY.CONNECTIONS.NAME.RILLET:
return 'Rillet';
case CONST.POLICY.CONNECTIONS.NAME.DUALENTRY:
- return 'DualEntry';
+ return 'LançamentoDuplo';
case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
- return 'Campfire';
+ return 'Fogueira';
case CONST.POLICY.CONNECTIONS.NAME.ZOHO_BOOKS:
return 'Zoho Books';
case CONST.POLICY.CONNECTIONS.NAME.BUSINESS_CENTRAL:
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index ae80eeb5..ff3a93f8 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7005,7 +7005,7 @@ _如需更详细的说明，请[访问我们的帮助网站](${CONST.NETSUITE_IM
case CONST.POLICY.CONNECTIONS.NAME.RILLET:
return 'Rillet';
case CONST.POLICY.CONNECTIONS.NAME.DUALENTRY:
- return 'DualEntry';
+ return '双重记账';
case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
return 'Campfire';
case CONST.POLICY.CONNECTIONS.NAME.ZOHO_BOOKS:
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
nkdengineer
force-pushed
the
fix/103230
branch
from
October 8, 2026 08:36
ac68efb to
cd65170
Compare
Contributor
Author
|
Look like no translation need to be updated. |
Contributor
Author
|
@truph01 The PR is ready for review. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
|
App/src/libs/actions/connections/index.ts Line 131 in 0430fe3 Should we add the Zoho book case here, like Campfire and Business Central do? |
Contributor
Author
|
@truph01 I updated. |
truph01
approved these changes
Oct 8, 2026
lakchote
reviewed
Oct 8, 2026
lakchote
left a comment
lakchote
left a comment
Contributor
There was a problem hiding this comment.
Thanks, the wiring looks right. Most of the Zoho constants and types came over from Campfire as is, though, and a couple of them don't match Zoho's API or the export plan in the predesign. Left comments on those, plus the knip ignore.
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
90 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.5.6-0 🚀
|
Contributor
|
No help site update is needed: this |
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
[No QA] Add Zoho Books App constants, Onyx types, API parameters, and actions
Fixed Issues
$ #103230
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari