-
Notifications
You must be signed in to change notification settings - Fork 4k
Refactor - Answer Questions for Wallet #10320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
eb76669
add the method
sketchydroide 46567a4
adding the OnyxData
sketchydroide 77f30de
calling api from the right js file
sketchydroide 29ae567
adding onyxKey
sketchydroide 30ad2f1
using the isLoading
sketchydroide 86fe203
linter requested changes
sketchydroide c31819f
using the errors and error code
sketchydroide ed809ba
need to json stringify first?
sketchydroide 7477c23
I think this is where the error code will be used
sketchydroide 02cf2ca
Merge branch 'main' into afonseca_wallet_questions_refactor
sketchydroide eb67376
remove import duplicated
sketchydroide c67d184
linter removing extra line (bad merge?)
sketchydroide ed6a04a
fixing linter, I think it's good this time
sketchydroide 1d76934
Merge branch 'main' into afonseca_wallet_questions_refactor
sketchydroide 06c1432
Merge branch 'main' into afonseca_wallet_questions_refactor
sketchydroide ccf63b3
correcting the name to walletAdditionalDetails
sketchydroide 66fc734
adding some TODO so when I'm done. I can remove this mehtod
sketchydroide b9c7d67
adding some handling for what happens when the answers were correct.
sketchydroide d9153aa
fix jest hopefully
sketchydroide f0d04db
adding some more logic
sketchydroide de24b00
localize is not a mehtod
sketchydroide 4cf33e7
Merge branch 'main' into afonseca_wallet_questions_refactor
sketchydroide 31b42d9
fixing linter
sketchydroide 160da4e
Remove TODOs and cleanup
MariaHCD 539ecee
Clean up props and remove un-needed logic
MariaHCD f42ed2a
Fix command params for answerQuestionsForWallet
MariaHCD 3595d65
Don't show redundant error
MariaHCD f1f621e
Fix lint errors
MariaHCD bc6be2d
Add offline indicator and display error messages
MariaHCD a8bc734
Update param type
MariaHCD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.