Repository navigation
Conversation
Contributor
Author
|
Small fix for agent-device @Julesssss @rlinoz @kacper-mikolajczak |
Contributor
|
LGTM! |
Julesssss
approved these changes
Oct 8, 2026
Contributor
|
LGTM @BartekObudzinski is this ready to be merged? |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
BartekObudzinski
marked this pull request as ready for review
October 8, 2026 06:06
melvin-bot
Bot
requested review from
shubham1206agra
and removed request for
a team
October 8, 2026 06:07
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@Julesssss yes, just needed an issue. Marked as ready to review |
Julesssss
approved these changes
Oct 8, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
90 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.6-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The
agent-deviceskill's preflight checks for$(npm root -g)/agent-device/skills/agent-device/SKILL.md. Upstream stopped publishing that folder to npm in 0.20.8 (callstack/agent-device#1730), so on any current version the check prints FAIL on every skill load. The skill says to stop on any FAIL before running a device command, and the suggested fix (npm install -g agent-device@latest) can't help because the latest version doesn't ship the folder either. Line 120 pointed agents at the same missing folder, so they never got the upstream guidance.The CLI now serves that guidance itself through
agent-device help workflow. This PR:agent-device help workflow, which exits 0 when the guide is available and 1 otherwiseagent-device help workflowand the topic guidesBash(npm root *)from the skill'sallowed-toolsand the matchingechoentry from.claude/settings.json, since nothing uses them anymorehelp workflowworks from 0.20.0 onwards, so the minimum version stays the same.Fixed Issues
$ #103401
Tests
.claude/skills/agent-device/SKILL.md:agent-device help workflow >/dev/null 2>&1 && echo "OK (agent-device help workflow)" || echo "FAIL (agent-device help workflow unavailable). Fix: npm install -g agent-device@latest"OK (agent-device help workflow)mainand verify it printsFAIL (missing .../agent-device/skills/agent-device/SKILL.md)PATH(PATH=/usr/bin:/bin bash -c '<line>') and verify it prints the FAIL messageagent-device help react-native,help debugging,help scriptingandhelp batchand verify each prints a guideOffline tests
N/A, this only changes agent skill docs and Claude Code permissions.
QA Steps
No QA, this only changes agent skill docs and Claude Code permissions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari