Remove legacy violations suggested searches from the Spend UI by nkdengineer · Pull Request #103143 · Expensify/App

nkdengineer · 2026-10-06T07:16:25Z

Explanation of Change

We're going to move the Insight to a separate tab, then we want to remove Insight suggested searches from Spend page

Fixed Issues

$ #102811
PROPOSAL:

Tests

Precondition: insightsPage beta is enabled

Go to the Spend page
Verify that the Insight suggested searches don't appear anymore

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-10-06.at.14.09.42.mov

Android: mWeb Chrome

Screen.Recording.2026-10-06.at.14.08.01.mov

iOS: Native

Screen.Recording.2026-10-06.at.14.08.16.mov

iOS: mWeb Safari

Screen.Recording.2026-10-06.at.14.10.07.mov

MacOS: Chrome / Safari

codecov · 2026-10-06T07:20:16Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/SearchUIUtils.ts	`72.38% <100.00%> (+0.06%)`	⬆️
src/hooks/useSearchTypeMenuSections.ts	`97.29% <0.00%> (+9.20%)`	⬆️
... and 11 files with indirect coverage changes

melvin-bot · 2026-10-06T07:23:02Z

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2026-10-06T14:27:17Z

    CONST.SEARCH.SEARCH_KEYS.TOP_MERCHANTS,
 ] as const satisfies SearchKey[];

+const insightsPageMenuKeys = new Set<SearchKey>([...SPEND_INSIGHT_KEYS, CONST.SEARCH.SEARCH_KEYS.VIOLATIONS_BY_SUBMITTER]);


(Neil's AI agent)

NAB: insightsPageMenuKeys and insightsSearchKeys in createTypeMenuSections hold the same list. Can the Insights section loop iterate insightsPageMenuKeys instead (a Set keeps insertion order), so a future insight can't be added to one and missed in the other?

neil-marcellini · 2026-10-06T14:27:17Z

+            expect(menuKeys).not.toContain(CONST.SEARCH.SEARCH_KEYS.VIOLATIONS_BY_SUBMITTER);
+            expect(menuKeys).toContain(CONST.SEARCH.SEARCH_KEYS.EXPENSES);
+            expect(menuSections.find((section) => section.translationPath === 'search.tabs.insights')).toBeUndefined();
+            expect(SearchUIUtils.getSuggestedSearches(adminAccountID)[CONST.SEARCH.SEARCH_KEYS.VIOLATIONS_BY_SUBMITTER].key).toBe(CONST.SEARCH.SEARCH_KEYS.VIOLATIONS_BY_SUBMITTER);


(Neil's AI agent)

NAB: this only checks that the entry's key equals the constant it's defined with in getSuggestedSearches, so it doesn't test any behavior. The new useSearchKeyParam test already proves the search still resolves, so I think this line can be removed.

neil-marcellini

Good to go, thank you. I don't think we need a C+.

neil-marcellini · 2026-10-06T14:28:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

No C+ needed for a simple removal. Pasting this to pass the check.

github-actions · 2026-10-06T14:35:25Z

🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-06T14:35:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-06T14:40:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103143.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-64caa98-146e604-33be1e3d5a7ecd14ff2622e9316a052a3bbd385d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-64caa98-146e604-97dbb5f0700942b0bd8dc0d6e5a5d50c729d56d8/index.html

Web 🕸️
https://103143.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-06T22:29:32Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.4-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-10-07T19:40:38Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Remove legacy violations suggested searches from the Spend UI

982cb7c

melvin-bot Bot assigned nkdengineer Oct 6, 2026

nkdengineer marked this pull request as ready for review October 6, 2026 07:22

nkdengineer requested review from a team as code owners October 6, 2026 07:22

melvin-bot Bot requested review from thelullabyy and trjExpensify and removed request for a team October 6, 2026 07:23

neil-marcellini self-requested a review October 6, 2026 14:10

neil-marcellini reviewed Oct 6, 2026

View reviewed changes

neil-marcellini approved these changes Oct 6, 2026

View reviewed changes

neil-marcellini removed the request for review from thelullabyy October 6, 2026 14:27

neil-marcellini merged commit 64caa98 into Expensify:main Oct 6, 2026
42 of 45 checks passed

OSBotify mentioned this pull request Oct 6, 2026

Deploy Checklist: New Expensify 2026-10-06 #103248

Closed

100 tasks done

melvin-bot Bot mentioned this pull request Oct 7, 2026

[Due for payment 2026-10-14] [Insights][R4][App] Remove legacy violations suggested searches from the Spend UI #102811

Closed

3 tasks

Navigation Menu

Repository navigation

Remove legacy violations suggested searches from the Spend UI - #103143

Remove legacy violations suggested searches from the Spend UI#103143
neil-marcellini merged 1 commit into
Expensify:mainfrom
nkdengineer:fix/102811

nkdengineer commented Oct 6, 2026

Uh oh!

codecov Bot commented Oct 6, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Oct 6, 2026

Uh oh!

neil-marcellini Oct 6, 2026

Uh oh!

neil-marcellini Oct 6, 2026

Uh oh!

neil-marcellini left a comment

Uh oh!

neil-marcellini commented Oct 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nkdengineer commented Oct 6, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 6, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 6, 2026

Uh oh!

neil-marcellini Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 6, 2026

Uh oh!

OSBotify commented Oct 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Oct 6, 2026 •

edited by github-actions Bot

Loading

neil-marcellini commented Oct 6, 2026 •

edited

Loading