MenuItem decomposition - remove `containerStyle` by war-in · Pull Request #103039 · Expensify/App

war-in · 2026-10-05T13:45:32Z

Explanation of Change

Removes containerStyle from the legacy MenuItem. FeatureList's [m0, wAuto] was overridden by popoverMenuItem, so it was a no-op (verified 0px diff). The custom status rows' pr2 narrowed the right gutter by 12px. It is dropped so those rows align with every other row, a small intentional visual change.

Fixed Issues

$ #100159
PROPOSAL:

Tests

Go to Settings > Profile > Status
Verify that the chevron on the "Clear after" row lines up with the chevrons of other standard rows (20px right padding)
Tap "Clear after", choose "Custom", and verify that the Date and Time rows' chevrons (and the red dot when the value is invalid) are aligned the same way

Open a page that shows a feature list (e.g. Workspace > Company cards on a workspace without cards)
Verify that the feature rows look exactly as before

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

popoverMenuItem's width: '100%' and wrapperStyle's p0 come after containerStyle in the pressable style array, and nothing sets a margin, so [m0, wAuto] never applied (pixel-identical in storybook diff).

FeatureList's [m0, wAuto] was overridden by popoverMenuItem. The status rows' pr2 narrowed the right gutter by 12px; it is dropped so they match every other row. The story card wraps the row in a View for its outer margin.

codecov · 2026-10-05T13:51:11Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/FeatureList.tsx	`0.00% <ø> (ø)`
src/components/MenuItem/MenuItem.tsx	`90.70% <ø> (ø)`
...ings/Profile/CustomStatus/StatusClearAfterPage.tsx	`0.00% <ø> (ø)`
...pages/settings/Profile/CustomStatus/StatusPage.tsx	`0.00% <ø> (ø)`
src/stories/MenuItemComparison.stories.tsx	`0.00% <0.00%> (ø)`
... and 69 files with indirect coverage changes

melvin-bot · 2026-10-05T15:42:36Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2026-10-06T12:37:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-10-06.at.18.06.42.mov

Pujan92

LGTM!

github-actions · 2026-10-08T15:53:52Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-08T15:58:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103039.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-de9ac5b-b8010af-63fae9e5619642ac74506825a462da306ad58ec4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-de9ac5b-b8010af-e6ab656984e1fbacb21d083703336c1491d7dfcd/index.html

Web 🕸️
https://103039.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-08T16:00:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-10-08T19:45:40Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-08T19:49:52Z

No help site update needed. This PR only removes an unused containerStyle prop and adjusts right padding on the custom status rows. No feature, label, or workflow that an article describes has changed.

view run

OSBotify · 2026-10-09T20:31:17Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

war-in added 2 commits October 5, 2026 15:35

Drop no-op containerStyle from FeatureList MenuItem

50ac8a4

popoverMenuItem's width: '100%' and wrapperStyle's p0 come after containerStyle in the pressable style array, and nothing sets a margin, so [m0, wAuto] never applied (pixel-identical in storybook diff).

Remove containerStyle prop from legacy MenuItem

05f2bae

FeatureList's [m0, wAuto] was overridden by popoverMenuItem. The status rows' pr2 narrowed the right gutter by 12px; it is dropped so they match every other row. The story card wraps the row in a View for its outer margin.

melvin-bot Bot assigned war-in Oct 5, 2026

war-in marked this pull request as ready for review October 5, 2026 15:42

war-in requested review from a team as code owners October 5, 2026 15:42

melvin-bot Bot requested review from Pujan92 and flaviadefaria and removed request for a team October 5, 2026 15:42

MelvinBot mentioned this pull request Oct 5, 2026

MenuItem — composition over configuration #96202

Open

Pujan92 approved these changes Oct 6, 2026

View reviewed changes

melvin-bot Bot requested a review from roryabraham October 6, 2026 12:40

roryabraham approved these changes Oct 8, 2026

View reviewed changes

roryabraham merged commit de9ac5b into Expensify:main Oct 8, 2026
44 of 47 checks passed

OSBotify mentioned this pull request Oct 8, 2026

Deploy Checklist: New Expensify 2026-10-08 #103502

Closed

90 tasks done

melvin-bot Bot mentioned this pull request Oct 9, 2026

MenuItem decomposition Phase 4 — style-prop remnants #100159

Open

Navigation Menu

Repository navigation

MenuItem decomposition - remove `containerStyle` - #103039

MenuItem decomposition - remove `containerStyle`#103039
roryabraham merged 2 commits into
Expensify:mainfrom
software-mansion-labs:war-in/menuitem-remove-container-style

war-in commented Oct 5, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Oct 5, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Oct 5, 2026

Uh oh!

Pujan92 commented Oct 6, 2026 •

edited

Loading

Uh oh!

Pujan92 left a comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 8, 2026

Uh oh!

MelvinBot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

war-in commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 5, 2026

Uh oh!

Pujan92 commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 8, 2026

Uh oh!

MelvinBot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

war-in commented Oct 5, 2026 •

edited

Loading

codecov Bot commented Oct 5, 2026 •

edited by github-actions Bot

Loading

Pujan92 commented Oct 6, 2026 •

edited

Loading