Keep the preview uri when resizing large image attachments on web by MelvinBot · Pull Request #102852 · Expensify/App

MelvinBot · 2026-10-02T08:54:26Z

Explanation of Change

On web, images over 24 MiB are resized before the attachment preview opens. resizeImageIfNeeded passes the resized file through createFile, whose web branch clones it with new File(...). The File constructor doesn't copy the custom uri property, so the resized file lost its blob uri. The preview then rendered an image with an empty source, which never fires onLoad, so the spinner never went away.

This PR fixes the root cause in createFile: the web branch now copies uri onto the cloned File, matching the native branch, which already keeps uri. Every other step that creates a web attachment sets uri, so createFile was the only place that dropped it. Fixing it there also covers the other caller of resizeImageIfNeeded (the "add additional receipt" flow) and the workspace-avatar callers in Policy.ts, where the extra property is harmless.

I also added unit tests for createFile (web and native) and for resizeImageIfNeeded on web with an image over the max size. The new web tests fail without the fix and pass with it.

Fixed Issues

$ #102470
PROPOSAL: #102470 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Resized attachments over 24 MiB lost their blob uri, so the attachment preview had no source and showed an endless spinner. Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>

MelvinBot · 2026-10-02T08:54:45Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-preserveResizedImageUri
git checkout -b claude-preserveResizedImageUri upstream/claude-preserveResizedImageUri
git push -u origin claude-preserveResizedImageUri

Then you can close this PR and open a new one from your fork.

MelvinBot · 2026-10-02T09:05:55Z

🤖 Android test steps verification results: ⚠️ partial

On standalone Android, the image attached, previewed, and sent with no stuck spinner and no related JS errors. However, this PR only changes the web branch of createFile, which Android never runs. I also couldn't create an image over 24 MiB in this session, so the resize path wasn't exercised. Treat this as a smoke test of the attachment flow, not a test of the fix.

Step	Status
Navigate to a DM chat Opened a one-on-one DM with Concierge through + > Start chat. The chat header and composer loaded.	✅
Tap + > Add attachment and select the image file Tapped + > Add attachment > Choose from gallery and picked the test PNG (about 440 KB, since a file over 24 MiB couldn't be created) from the Android photo picker.	✅
The attachment preview shows the image, not an endless spinner On Android, picking one gallery image sends it right away, with no separate preview modal. The image loaded within about 2 seconds in the thread, and the full-screen attachment viewer showed it with no spinner.	✅
The image can be sent and appears in the chat The image appears as a sent message in the Concierge DM, and Concierge replied to it as a receipt scan.	✅
No errors appear in the JS console during the flow The `AddAttachment` request returned jsonCode 200 with no attachment-related exceptions. The only errors were unrelated: an `AuthenticatePusher` 403 (expected in the test environment) and a "dismissModal failed" navigation warning.	✅

view run · view recording

MelvinBot · 2026-10-02T09:12:07Z

🤖 Web test steps verification results: ⚠️ partial

I reached a DM chat and opened the Add attachment menu, but the web test tool can't select files in the browser's file picker. No image over 24 MiB could be attached, so the resize and preview fix (steps 2–4) wasn't tested, and the tool can't read the JS console.

Step	Status
Navigate to a DM chat After finishing onboarding, the app opened the Concierge DM with the composer and the + menu visible.	✅
Click + > Add attachment and select the >24 MiB image file The + menu opened and showed Add attachment. Clicking it opens the browser's native file picker, which the web test tool can't use, since file uploads aren't supported. No file was selected.	❌
The attachment preview shows the image, not an endless spinner Not tested. No file could be attached.	❌
The image can be sent and appears in the chat Not tested. No file could be attached.	❌
No errors appear in the JS console during the flow Not checked. The web test tool can't read browser console logs. No error banners or broken UI appeared during onboarding or navigation.	❌

view run · view recording

QichenZhu · 2026-10-06T05:05:44Z

+            const file = new File(['content'], 'image.jpeg', {type: 'image/jpeg'});
+            file.uri = 'blob:http://localhost/image';
+
+            // When the file is cloned


@MelvinBot, please remove comments that don't add value like this.

Done in d7af11b. I removed the 5 comments in the new tests that only restated the next line: both "When the file is cloned" comments, "When the image is resized", and the native test's Given/Then comments.

I kept the comments that explain why, for example that previews read uri to show the image. FileUtilsTest.ts passes (44/44) and ESLint is clean.

Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>

QichenZhu · 2026-10-06T05:41:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
MelvinBot PRs don't require this.
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
MelvinBot PRs don't require this.
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
https://expensify.slack.com/archives/C049HHMV9SM/p1764642854883869
https://expensify.slack.com/archives/C049HHMV9SM/p1790051358940179
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-native.mov

Android: mWeb Chrome

android-web.mov

iOS: HybridApp

ios-native.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

mac-web.mov

QichenZhu

LGTM.

MelvinBot doesn't provide test steps. My suggestion is:

Precondition: Have an image larger than 24 MiB in size and less than 50 megapixels in resolution.

Steps:

Navigate to a DM.
Click + > Add attachment.
Select the image and upload it.
Verify that the file uploads successfully. The test fails if the screen loads indefinitely.

QichenZhu · 2026-10-08T06:17:35Z

@MelvinBot mark this PR ready for review

MelvinBot · 2026-10-08T06:21:14Z

I marked this PR ready for review.

view run

chatgpt-codex-connector · 2026-10-08T06:21:15Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

melvin-bot · 2026-10-08T06:21:18Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

QichenZhu · 2026-10-08T07:48:07Z

I already reviewed.

QichenZhu · 2026-10-08T07:49:46Z

@grgia, this is ready for your second review.

github-actions · 2026-10-08T10:05:12Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-08T10:05:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-08T10:09:28Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102852.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-76e0805-a57d040-245dd6fcadf4477f52977b9c9c7da4be5d500f51/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-76e0805-a57d040-ccdc075a04f7221062c0b69eb154b58fcff94ca1/index.html

Web 🕸️
https://102852.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-08T19:45:10Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.5.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-08T19:49:22Z

No help site update needed. This bug fix makes large image previews on web load as users expect instead of spinning forever, so no article sentence is now wrong.

view run

IuliiaHerets · 2026-10-08T21:07:20Z

Any QA steps here?

cc @grgia @QichenZhu @dylanexpensify

QichenZhu · 2026-10-08T22:11:06Z

@IuliiaHerets QA steps:

Precondition: Have an image larger than 24 MiB in size and less than 50 megapixels in resolution.

Steps:

Navigate to a DM.

Click + > Add attachment.

Select the image and upload it.

Verify that the file uploads successfully. The test fails if the screen loads indefinitely.

Thanks!

OSBotify · 2026-10-09T20:30:47Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Keep the preview uri when createFile clones a file on web

288247f

Resized attachments over 24 MiB lost their blob uri, so the attachment preview had no source and showed an endless spinner. Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>

MelvinBot assigned QichenZhu Oct 2, 2026

MelvinBot requested a review from a team October 2, 2026 08:54

melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Oct 2, 2026

MelvinBot mentioned this pull request Oct 2, 2026

[Due for payment 2026-10-16] [$175] Endless spinner when uploading image #102470

Open

2 of 7 tasks

QichenZhu suggested changes Oct 6, 2026

View reviewed changes

Remove test comments that restate the code

d7af11b

Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>

QichenZhu approved these changes Oct 6, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia October 6, 2026 05:50

MelvinBot marked this pull request as ready for review October 8, 2026 06:21

MelvinBot requested a review from a team as a code owner October 8, 2026 06:21

melvin-bot Bot requested review from QichenZhu and dylanexpensify and removed request for a team October 8, 2026 06:21

melvin-bot Bot removed the request for review from a team October 8, 2026 06:21

grgia approved these changes Oct 8, 2026

View reviewed changes

grgia merged commit 76e0805 into main Oct 8, 2026
40 of 43 checks passed

grgia deleted the claude-preserveResizedImageUri branch October 8, 2026 10:01

OSBotify mentioned this pull request Oct 8, 2026

Deploy Checklist: New Expensify 2026-10-08 #103502

Closed

90 tasks done

applause-bot Bot mentioned this pull request Oct 9, 2026

[$175] Attachments - Image flashes briefly after uploading #103619

Open

1 of 7 tasks

Conversation

MelvinBot commented Oct 2, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Oct 2, 2026

Uh oh!

MelvinBot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QichenZhu Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Oct 6, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Oct 8, 2026

Uh oh!

MelvinBot commented Oct 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 8, 2026

Uh oh!

melvin-bot Bot commented Oct 8, 2026

Uh oh!

QichenZhu commented Oct 8, 2026

Uh oh!

QichenZhu commented Oct 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 8, 2026

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 8, 2026

Uh oh!

MelvinBot commented Oct 8, 2026

Uh oh!

IuliiaHerets commented Oct 8, 2026

Uh oh!

QichenZhu commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented Oct 2, 2026 •

edited

Loading

MelvinBot commented Oct 2, 2026 •

edited

Loading

MelvinBot Oct 6, 2026 •

edited

Loading