[BC][Release 2] Add the Business Central per-card vendor override by c3024 · Pull Request #102670 · Expensify/App

c3024 · 2026-09-30T14:48:27Z

Explanation of Change

Adds a Business Central case to the company card export settings, so the Accounting section of the card details page shows an "Exports to" row with the Business Central icon, where admins can pick a vendor for that card or keep the workspace default vendor. The row follows the Card Details - Admin view Figma frame.

Fixed Issues

$ #101110
PROPOSAL: N/A

Tests

Enable the businessCentral beta for your account (on dev: Account > Troubleshoot > Beta overrides).
Open a Control workspace connected to Dynamics 365 Business Central whose first sync has finished, with company cards assigned and "Export company card expenses as" set to Purchase invoices (the default).
Open Workspace > Company cards and click an assigned card.
Verify the Accounting section shows a row with the Business Central icon that reads "Exports to Default vendor".
Click the row and verify the page title reads "Dynamics 365 Business Central purchase invoices export", and the list shows "Default vendor" followed by the company's vendors, without vendors blocked for all transactions.
Pick a vendor and verify the row reads "Exports to" followed by that vendor's name.
Open the row again, pick "Default vendor" and verify the row reads "Exports to Default vendor" again.
In Accounting > Export, change "Export company card expenses as" to General journal. Go back to the card, verify the "Exports to" row is still shown, then click it and verify the page title reads "Dynamics 365 Business Central general journal export".

Verify that no errors appear in the JS console

Offline tests

Go offline, open the card's "Exports to" row and pick a vendor.
Verify the row shows the new vendor with the pending style.
Go back online and verify the pending style clears and the vendor stays.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-09-30T14:48:54Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-09-30T14:53:07Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`95.83% <ø> (ø)`
src/pages/workspace/companyCards/utils.tsx	`88.55% <100.00%> (+0.29%)`	⬆️
... and 11 files with indirect coverage changes

…ness-central-card-vendor-override # Conflicts: # src/pages/workspace/companyCards/utils.tsx

melvin-bot · 2026-10-01T05:34:23Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2026-10-01T16:15:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-10-07.at.16.22.07.mov

trjExpensify

@Expensify/design @lakchote in terms of the styling here, I thought these rows in the card settings were going to look like this?

…ntegration icon

c3024 · 2026-10-01T17:31:17Z

In the Figma, every card has the card image at the top, but the action buttons differ between frames. The BofA card frame shows Last updated, then Update card and View transactions right below the card. The Expensify Card frame shows Freeze card and View transactions there. In the Visa card frames, View transactions, Update card and Unassign card are separate rows at the bottom.

App already follows the BofA layout for every company card and the Expensify Card layout for Expensify Cards. This PR doesn't touch those layouts.

…ness-central-card-vendor-override

lakchote · 2026-10-02T16:40:27Z

@trjExpensify the Campfire and Digits mocks show the same separate action rows as your screenshot, and I think we should follow those. I checked Campfire’s code, and it still uses the shared card image and action-button layout that this PR reuses.

@Expensify/design can you approve aligning the Card details layout and row styling with those mocks? Once confirmed, @c3024 can make the agreed changes here, and I’ll take care of aligning the remaining integrations too.

shawnborton · 2026-10-02T19:47:33Z

In the Figma, every card has the card image at the top, but the action buttons differ between frames. The BofA card frame shows Last updated, then Update card and View transactions right below the card. The Expensify Card frame shows Freeze card and View transactions there. In the Visa card frames, View transactions, Update card and Unassign card are separate rows at the bottom.

Yeah, that's on purpose - we can't freeze external cards, but we can freeze the Expensify Card. Hence why those buttons are slightly different. I am pretty sure what we have in the product today is what we landed on, since we recently went through and updated all of these views.

dannymcclain · 2026-10-02T20:11:36Z

I am pretty sure what we have in the product today is what we landed on, since we recently went through and updated all of these views.

This sounds right to me too.

trjExpensify · 2026-10-02T20:24:33Z

Yeah, to clarify @c3024 .... I was talking about the styling of this row/section.

c3024 · 2026-10-05T07:41:47Z

I was talking about the styling of this row/section.

Got it. Updated that.

daledah

LGTM

Screen.Recording.2026-10-07.at.16.22.07.mov

NikkiWines

github-actions · 2026-10-08T12:58:28Z

🚧 NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-08T13:00:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-08T13:02:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102670.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f532054-b8010af-123d5f25f6cbef4d6e38516b58d7193434b22774/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f532054-b8010af-a04ff8a040edbcb46cc50d4f82efdcd89befe7cc/index.html

Web 🕸️
https://102670.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-08T19:45:01Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.5.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-10-09T06:44:48Z

Hi @c3024. QA team is blocked from checking this PR because an authentication error appears when trying to connect to Dynamics 365 Business Central
Comment

OSBotify · 2026-10-09T20:30:38Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Let admins override the Business Central vendor on a company card

66758be

melvin-bot Bot assigned c3024 Sep 30, 2026

c3024 added 2 commits October 1, 2026 08:30

Merge remote-tracking branch 'origin/main' into chaitanya/101110-busi…

9047570

…ness-central-card-vendor-override # Conflicts: # src/pages/workspace/companyCards/utils.tsx

Shorten the Business Central card vendor comment

0e947f8

c3024 marked this pull request as ready for review October 1, 2026 05:34

c3024 requested review from a team as code owners October 1, 2026 05:34

melvin-bot Bot requested review from daledah and trjExpensify and removed request for a team October 1, 2026 05:34

melvin-bot Bot removed the request for review from a team October 1, 2026 05:34

trjExpensify reviewed Oct 1, 2026

View reviewed changes

Show the Business Central card vendor as an Exports to row with the i…

74e78a2

…ntegration icon

Merge remote-tracking branch 'origin/main' into chaitanya/101110-busi…

cba2b01

…ness-central-card-vendor-override

daledah approved these changes Oct 7, 2026

View reviewed changes

melvin-bot Bot requested a review from NikkiWines October 7, 2026 09:29

NikkiWines approved these changes Oct 8, 2026

View reviewed changes

NikkiWines merged commit f532054 into Expensify:main Oct 8, 2026
35 of 37 checks passed

OSBotify mentioned this pull request Oct 8, 2026

Deploy Checklist: New Expensify 2026-10-08 #103502

Closed

90 tasks done

IuliiaHerets mentioned this pull request Oct 9, 2026

[BC][Release 2] Add Customers and Projects, update Imports page UI #103178

Merged

45 tasks done

melvin-bot Bot mentioned this pull request Oct 9, 2026

[Due for payment 2026-10-16] [Release 2][BC] Add Business Central per-card vendor override UI #101110

Open

Conversation

c3024 commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 30, 2026

Uh oh!

codecov Bot commented Sep 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 1, 2026

Uh oh!

daledah commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

c3024 commented Oct 1, 2026

Uh oh!

lakchote commented Oct 2, 2026

Uh oh!

shawnborton commented Oct 2, 2026

Uh oh!

dannymcclain commented Oct 2, 2026

Uh oh!

trjExpensify commented Oct 2, 2026

Uh oh!

c3024 commented Oct 5, 2026

Uh oh!

daledah left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 8, 2026

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 8, 2026

Uh oh!

IuliiaHerets commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

c3024 commented Sep 30, 2026 •

edited

Loading

codecov Bot commented Sep 30, 2026 •

edited by github-actions Bot

Loading

daledah commented Oct 1, 2026 •

edited

Loading

IuliiaHerets commented Oct 9, 2026 •

edited

Loading