Repository navigation
Match the self DM by the localized You/Me in report search - #102668
Merged
Merged
Conversation
The current user's contact row is searchable by the localized You/Me, but New chat excludes that row and only shows the self DM, which the report matchers never matched against those terms. Add them for self DMs in filterReports and doesReportMatchSearchTerms. Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
melvin-bot
Bot
added
Melvin-Test-Android
Melvin-Test-Web
Contributor
Author
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
3 of 7 tasks
Contributor
Author
|
🤖 Web test steps verification results: The fix works on Web. In FAB > Start chat, both "Me" and "You" now show the self DM, labeled "(you)", and "No results found" no longer appears. The PR's Tests section is still a TODO, so I ran the reproduction steps from the linked issue. I couldn't check the JS console because the web test tooling can't read browser logs.
|
Contributor
Author
|
🤖 Android test steps verification results: ✅ pass The fix works on Android. In the global Search and in FAB > Start chat, both "Me" and "You" show the self DM, labeled "Melvin (you)", and "No results found" never appears. The PR's Tests section is still a TODO, so I ran the reproduction steps from the linked issue.
|
Member
|
@MelvinBot change the implementation to follow #102648 (comment) proposal. |
…M for "me" Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
Contributor
Author
|
The PR now follows Melvin's proposal. The fix itself already matched it: both proposals make the same change to
The full |
Member
|
@MelvinBot update the description to following |
Contributor
Author
|
|
Member
|
@MelvinBot Update the description #102668 (comment) |
Contributor
Author
|
I replaced the PR description with the text from your comment. It now includes your Tests, Offline tests, and QA Steps, plus the checked author checklist. |
parasharrajat
approved these changes
Oct 6, 2026
Member
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
06.10.2026_19.40.13_REC.mp4
06.10.2026_19.53.13_REC.mp4
06.10.2026_19.54.27_REC.mp4
🎀 👀 🎀 C+ reviewed
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #102648 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Member
|
@grgia All yours. |
Member
|
@MelvinBot mark it ready for review |
MelvinBot
marked this pull request as ready for review
October 8, 2026 16:53
Contributor
Author
|
I marked this PR as ready for review. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
dylanexpensify
and removed request for
a team
October 8, 2026 16:53
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| // Let the current user find their self DM by the localized "You"/"Me", like their own contact row | ||
| if (item.isSelfDM) { |
Contributor
There was a problem hiding this comment.
❌ PERF-13 (docs)
translate('common.you') and translate('common.me') are called inside the filterArrayByMatch mapper that filterReports runs via reduceRight (once per report per search term). Neither call uses the iterator variable item — they always return the same localized strings — so they recompute redundantly as the report list and term count grow.
Hoist the constants above the reduceRight loop and reuse them inside the callback:
const selfDMSearchValues = [StringUtils.normalizeForMatch(translate('common.you')), StringUtils.normalizeForMatch(translate('common.me'))];
// ...
if (item.isSelfDM) {
values.push(...selfDMSearchValues);
}Reviewed at: f4fb070 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
dylanexpensify
approved these changes
Oct 9, 2026
dylanexpensify
left a comment
dylanexpensify
left a comment
Contributor
There was a problem hiding this comment.
Looks good from a product perspective 👍
grgia
approved these changes
Oct 9, 2026
Contributor
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This was referenced Oct 9, 2026
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
38 tasks done
This was referenced Oct 9, 2026
74 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.5.7-0 🚀
|
Contributor
Author
|
No help site update is needed. This is a bug fix: searching "Me" or "You" in Start chat now finds your own chat, as users would expect, and no article under |
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.5.7-3 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Searching the localized "Me"/"You" in FAB > Start chat showed "No results found" instead of the self DM.
Those terms were only attached to the current user's contact row (
getCurrentUserSearchTerms). Start chat doesn't passincludeCurrentUser, so that row is excluded, and the self DM is the only row that represents the current user. The report matchers (filterReportsanddoesReportMatchSearchTerms) never matched the self DM against "You"/"Me".This PR adds the localized
common.you/common.meto the searchable values of self DMs in both matchers, so the cheap check indoesReportMatchSearchTermsstays a superset offilterReports. Both functions, plusfilterSelfDMChat, now taketranslate, which every caller already had in scope. The change also covers other report pickers that filter the self DM throughfilterReports, such as the Search "In" filter.AI checks run:
npm run typecheck,npm run linton the changed files,npm run fmt(oxfmt),npm run spell-changed, and the Jest suitesOptionsListUtilsTest,searchMatchUtilsTest,useSearchSelectorTest,SearchAutocompleteListTest(unit and UI),PersonalDetailOptionsListUtilsTest,useAutocompleteSuggestions,useGroupChatDraftParticipantSyncTest,InSelectorTest, andNewChatPageTest. All passed. New unit tests cover "me"/"you" matching the self DM and "me" not matching a non-self-DM report. Two more tests check that searching "me" withincludeSelfDM: truereturns the self DM from bothgetValidOptionsandfilterAndOrderOptions.Fixed Issues
$ #102648
PROPOSAL: #102648 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari