Skip to content

[CP Staging + Prod]Prevent Home page crashes from missing rail passenger IDs - #102646

Merged
rlinoz merged 1 commit into
mainfrom
rodrigo-fix-rail-passenger-crash
Sep 30, 2026
Merged

[CP Staging + Prod]Prevent Home page crashes from missing rail passenger IDs#102646
rlinoz merged 1 commit into
mainfrom
rodrigo-fix-rail-passenger-crash

Conversation

@rlinoz

@rlinoz rlinoz commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Prevent incomplete rail passenger IDs from crashing the Home page's Upcoming travel section. Guard both nested ID objects and make them optional in the rail passenger type. Reservations remain available without traveler details when the ID is absent.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/686616

Tests

Local validation:

  1. Use the adhoc build
  2. Login into the users account
  3. Verify it loads
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Use test bookings; do not modify a production customer's booking data.

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not tested; manual QA pending. No visual changes.

Android: mWeb Chrome

Not tested; manual QA pending. No visual changes.

iOS: Native

Not tested; manual QA pending. No visual changes.

iOS: mWeb Safari

Not tested; manual QA pending. No visual changes.

MacOS: Chrome / Safari

Not tested; manual QA pending. No visual changes.

@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Sign in to view
@rlinoz rlinoz added the InternalQA This pull request required internal QA label Sep 30, 2026
@rlinoz
rlinoz marked this pull request as ready for review September 30, 2026 11:54
@rlinoz
rlinoz requested review from a team as code owners September 30, 2026 11:54
@melvin-bot
melvin-bot Bot requested review from QichenZhu and removed request for a team September 30, 2026 11:54
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team September 30, 2026 11:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T12:04:40.131302Z 9120b12 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

NikkiWines
NikkiWines approved these changes Sep 30, 2026
View reviewed changes

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rlinoz
rlinoz merged commit 4948138 into main Sep 30, 2026
51 of 52 checks passed
@rlinoz
rlinoz deleted the rodrigo-fix-rail-passenger-crash branch September 30, 2026 12:08
@OSBotify

OSBotify commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@rlinoz rlinoz changed the title Prevent Home page crashes from missing rail passenger IDs [CP Staging + Prod]Prevent Home page crashes from missing rail passenger IDs Sep 30, 2026
OSBotify pushed a commit that referenced this pull request Sep 30, 2026
@rlinoz @OSBotify
Merge pull request #102646 from Expensify/rodrigo-fix-rail-passenger-…
6aa79a9 
…crash

Prevent Home page crashes from missing rail passenger IDs

(cherry picked from commit 4948138)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 30, 2026
@OSBotify OSBotify mentioned this pull request Sep 30, 2026
Closed
66 tasks done
@rlinoz rlinoz mentioned this pull request Sep 30, 2026
Merged
51 tasks done
@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102646.

Android 🤖 iOS 🍎
❌ FAILED ❌ https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4948138-8363003-f074ec1d839cc080f167b8a14e2ccb76c1fdb37f/index.html
The QR code can't be generated, because the Android build failed iOS
Web 🕸️
https://102646.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify

OSBotify commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.97-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

No help site update is needed: this PR is a crash fix for incomplete rail passenger IDs, and it doesn't change any feature, label, or workflow that a help article describes.

view run

OSBotify pushed a commit that referenced this pull request Sep 30, 2026
@rlinoz @OSBotify
Merge pull request #102646 from Expensify/rodrigo-fix-rail-passenger-…
0fdd0a2 
…crash

Prevent Home page crashes from missing rail passenger IDs

(cherry picked from commit 4948138)

(cherry-picked to production by mountiny)
@OSBotify

OSBotify commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.98-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.99-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

No help site update is needed: this PR is a crash fix for incomplete rail passenger IDs, and it doesn't change any feature, label, or workflow that a help article describes. The changed files are the same as when I last checked, so my earlier answer still applies.

view run

@OSBotify OSBotify mentioned this pull request Sep 30, 2026
Closed
70 tasks done
@OSBotify

OSBotify commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.5.0-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

No help site update is needed: this PR is a crash fix that adds optional chaining for missing rail passenger IDs, so the Home page loads as users expect, and no article sentence becomes incorrect.

view run

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes
@JS00001 JS00001 JS00001 approved these changes

Assignees

@rlinoz rlinoz

Labels

CP Production CP Staging marks PRs that have been CP'd to staging InternalQA This pull request required internal QA Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rlinoz @OSBotify @MelvinBot @NikkiWines @JS00001